1. 11 Apr, 2021 1 commit
    • repo: remove an inappropriate use of PASSTHROUGH · 6591deef
      This error code is for callbacks where we should act as though the callback was
      not set. This is not something that makes sense for a `_foreach` and checking
      for that error message to bubble up mostly is happenstance precisely because
      this is not an error code we expect in the callback.
      
      As part of removing this, let's also remove a use of foreach as we can open-code
      this check.
      Carlos Martín Nieto committed
  2. 02 Apr, 2021 1 commit
  3. 01 Apr, 2021 1 commit
  4. 20 Mar, 2021 1 commit
  5. 17 Mar, 2021 1 commit
  6. 10 Mar, 2021 2 commits
  7. 04 Mar, 2021 7 commits
  8. 03 Mar, 2021 2 commits
  9. 02 Mar, 2021 1 commit
    • winhttp: skip certificate check if unable to send request · edffea15
      In some circumstances (e.g. when proxies are involved), winhttp will fail to reach the WINHTTP_CALLBACK_STATUS_SENDING_REQUEST phase. If this occurs, we'll error with ERROR_WINHTTP_INCORRECT_HANDLE_STATE when attempting to query the server certificate context (see https://docs.microsoft.com/en-us/windows/win32/api/winhttp/nf-winhttp-winhttpsendrequest#remarks).
      
      To avoid this, verify that WinHttpSendRequest has reached the WINHTTP_CALLBACK_STATUS_SENDING_REQUEST phase before checking the certificate. Since we're using WinHTTP in synchronous mode, we know for sure that once WinHttpSendRequest returns we've either sent it successfully or not.
      
      NOTE: WINHTTP_CALLBACK_STATUS_SENDING_REQUEST appears to be deprecated with no direct replacement. WINHTTP_CALLBACK_STATUS_SENDREQUEST_COMPLETE is only available in async mode, and there doesn't appear to be a method of querying this flag outside of the status callback.
      Ian Hattendorf committed
  10. 01 Mar, 2021 1 commit
  11. 28 Feb, 2021 3 commits
  12. 22 Feb, 2021 2 commits
  13. 21 Feb, 2021 1 commit
  14. 19 Feb, 2021 1 commit
  15. 18 Feb, 2021 1 commit
  16. 17 Feb, 2021 2 commits
  17. 15 Feb, 2021 2 commits
  18. 11 Feb, 2021 2 commits
  19. 01 Feb, 2021 5 commits
  20. 31 Jan, 2021 2 commits
  21. 22 Jan, 2021 1 commit