1. 20 Jul, 2018 1 commit
  2. 13 Jul, 2018 1 commit
    • treewide: remove use of C++ style comments · 9994cd3f
      C++ style comment ("//") are not specified by the ISO C90 standard and
      thus do not conform to it. While libgit2 aims to conform to C90, we did
      not enforce it until now, which is why quite a lot of these
      non-conforming comments have snuck into our codebase. Do a tree-wide
      conversion of all C++ style comments to the supported C style comments
      to allow us enforcing strict C90 compliance in a later commit.
      Patrick Steinhardt committed
  3. 06 Jul, 2018 2 commits
  4. 29 Jun, 2018 1 commit
  5. 25 Jun, 2018 2 commits
  6. 24 Jun, 2018 1 commit
  7. 10 Jun, 2018 1 commit
  8. 03 Jul, 2017 1 commit
    • Make sure to always include "common.h" first · 0c7f49dd
      Next to including several files, our "common.h" header also declares
      various macros which are then used throughout the project. As such, we
      have to make sure to always include this file first in all
      implementation files. Otherwise, we might encounter problems or even
      silent behavioural differences due to macros or defines not being
      defined as they should be. So in fact, our header and implementation
      files should make sure to always include "common.h" first.
      
      This commit does so by establishing a common include pattern. Header
      files inside of "src" will now always include "common.h" as its first
      other file, separated by a newline from all the other includes to make
      it stand out as special. There are two cases for the implementation
      files. If they do have a matching header file, they will always include
      this one first, leading to "common.h" being transitively included as
      first file. If they do not have a matching header file, they instead
      include "common.h" as first file themselves.
      
      This fixes the outlined problems and will become our standard practice
      for header and source files inside of the "src/" from now on.
      Patrick Steinhardt committed
  9. 17 Apr, 2017 1 commit
  10. 29 Dec, 2016 1 commit
  11. 21 Apr, 2016 1 commit
  12. 19 Apr, 2016 2 commits
  13. 25 Sep, 2015 1 commit
  14. 24 Sep, 2015 4 commits
  15. 10 Sep, 2015 3 commits
  16. 08 Sep, 2015 1 commit
  17. 19 Aug, 2015 1 commit
  18. 18 Mar, 2015 1 commit
  19. 13 Feb, 2015 1 commit
  20. 10 Dec, 2014 1 commit
  21. 16 Sep, 2014 1 commit
  22. 22 May, 2014 1 commit
  23. 21 May, 2014 2 commits
  24. 20 May, 2014 1 commit
  25. 11 Dec, 2013 2 commits
    • Remove converting user error to GIT_EUSER · 25e0b157
      This changes the behavior of callbacks so that the callback error
      code is not converted into GIT_EUSER and instead we propagate the
      return value through to the caller.  Instead of using the
      giterr_capture and giterr_restore functions, we now rely on all
      functions to pass back the return value from a callback.
      
      To avoid having a return value with no error message, the user
      can call the public giterr_set_str or some such function to set
      an error message.  There is a new helper 'giterr_set_callback'
      that functions can invoke after making a callback which ensures
      that some error message was set in case the callback did not set
      one.
      
      In places where the sign of the callback return value is
      meaningful (e.g. positive to skip, negative to abort), only the
      negative values are returned back to the caller, obviously, since
      the other values allow for continuing the loop.
      
      The hardest parts of this were in the checkout code where positive
      return values were overloaded as meaningful values for checkout.
      I fixed this by adding an output parameter to many of the internal
      checkout functions and removing the overload.  This added some
      code, but it is probably a better implementation.
      
      There is some funkiness in the network code where user provided
      callbacks could be returning a positive or a negative value and
      we want to rely on that to cancel the loop.  There are still a
      couple places where an user error might get turned into GIT_EUSER
      there, I think, though none exercised by the tests.
      Russell Belfer committed
    • Further EUSER and error propagation fixes · dab89f9b
      This continues auditing all the places where GIT_EUSER is being
      returned and making sure to clear any existing error using the
      new giterr_user_cancel helper.  As a result, places that relied
      on intercepting GIT_EUSER but having the old error preserved also
      needed to be cleaned up to correctly stash and then retrieve the
      actual error.
      
      Additionally, as I encountered places where error codes were not
      being propagated correctly, I tried to fix them up.  A number of
      those fixes are included in the this commit as well.
      Russell Belfer committed
  26. 11 Nov, 2013 2 commits
  27. 02 Oct, 2013 1 commit
    • Support cancellation in push operation · 5b188225
      This commit adds cancellation for the push operation. This work consists of:
      
      1) Support cancellation during push operation
          - During object counting phase
          - During network transfer phase
              - Propagate GIT_EUSER error code out to caller
      2) Improve cancellation support during fetch
          - Handle cancellation request during network transfer phase
          - Clear error string when cancelled during indexing
      3) Fix error handling in git_smart__download_pack
      
      Cancellation during push is still only handled in the pack building and
      network transfer stages of push (and not during packbuilding).
      Jameson Miller committed
  28. 15 Apr, 2013 1 commit
  29. 17 Mar, 2013 1 commit