1. 10 May, 2020 6 commits
  2. 25 Apr, 2020 1 commit
  3. 19 Apr, 2020 1 commit
  4. 14 Apr, 2020 2 commits
  5. 05 Apr, 2020 5 commits
    • docs: add documentation for our coding style · ffb6a576
      For years, we've repeatedly had confusion about what our actual coding
      style is not only for newcomers, but also across the core contributors.
      This can mostly be attributed to the fact that we do not have any coding
      conventions written down. This is now a thing of the past with the
      introduction of a new document that gives an initial overview of our
      style and most important best practices for both our C codebase as well
      as for CMake.
      
      While the proposed coding style for our C codebase should be rather
      uncontroversial, the coding style for CMake might be. This can be
      attributed to multiple facts. First, the CMake code base doesn't really
      have any uniform coding style and is quite outdated in a lot of places.
      Second, the proposed coding style actually breaks with our existing one:
      we currently use all-uppercase function names and variables, but the
      documented coding style says we use all-lowercase function names but
      all-uppercase variables.
      
      It's common practice in CMake to write variables in all upper-case, and
      in fact all variables made available by CMake are exactly that. As
      variables are case-sensitive in CMake, we cannot and shouldn't break
      with this. In contrast, function calls are case insensitive, and modern
      CMake always uses all-lowercase ones. I argue we should do the same to
      get in line with other codebases and to reduce the likelihood of
      repetitive strain injuries.
      
      So especially for CMake, the proposed coding style says something we
      don't have yet. I'm fine with that, as the document explicitly says that
      it's what we want to have and not what we have right now.
      Patrick Steinhardt committed
    • Merge pull request #5485 from libgit2/ethomson/sysdir_unused · e9b0cfc0
      sysdir: remove unused git_sysdir_get_str
      Patrick Steinhardt committed
    • Merge pull request #5483 from xSetech/master · e56d48be
      Fix typo causing removal of symbol 'git_worktree_prune_init_options'
      Patrick Steinhardt committed
  6. 04 Apr, 2020 5 commits
  7. 03 Apr, 2020 1 commit
  8. 02 Apr, 2020 4 commits
  9. 01 Apr, 2020 11 commits
  10. 30 Mar, 2020 1 commit
  11. 28 Mar, 2020 2 commits
  12. 26 Mar, 2020 1 commit
    • patch: correctly handle mode changes for renames · 5f47cb48
      When generating a patch for a renamed file whose mode bits have changed
      in addition to the rename, then we currently fail to parse the generated
      patch. Furthermore, when generating a diff we output mode bits after the
      similarity metric, which is different to how upstream git handles it.
      
      Fix both issues by adding another state transition that allows
      similarity indices after mode changes and by printing mode changes
      before the similarity index.
      Patrick Steinhardt committed