- 19 Jun, 2015 2 commits
-
-
We currently use a timetamp to check whether an index file has been modified since we last read it, but this is racy. If two updates happen in the same second and we read after the first one, we won't detect the second one. Instead read the SHA-1 checksum of the file, which are its last 20 bytes which gives us a sure-fire way to detect whether the file has changed since we last read it. As we're now keeping track of it, expose an accessor to this data.
Carlos Martín Nieto committed -
This will tell us which numbers we were trying to compare, rather than just telling us that they're different.
Carlos Martín Nieto committed
-
- 17 Jun, 2015 1 commit
-
-
Zero out racily-clean entries' file_size
Carlos Martín Nieto committed
-
- 16 Jun, 2015 11 commits
-
-
When checking out some file 'foo' that has been modified in the working directory, allow the checkout to proceed (do not conflict) if 'foo' is identical to the target of the checkout.
Edward Thomson committed -
Edward Thomson committed
-
Provide functionality to set the time on a filesystem entry, using utimes or futimes on POSIX type systems or SetFileTime on Win32.
Edward Thomson committed -
commit: ignore multiple author fields
Edward Thomson committed -
remote: return EINVALIDSPEC when given an empty URL
Edward Thomson committed -
This is what we used to return in the settter and there's tests in bindings which ask for this. There's no particular reason to stop doing so.
Carlos Martín Nieto committed -
Fixed Xcode 6.1 build warnings
Carlos Martín Nieto committed -
These tests want to test that we don't recalculate entries which match the index already. This is however something we force when truncating racily-clean entries. Tick the index forward as we know that we don't perform the modifications which the racily-clean code is trying to avoid.
Carlos Martín Nieto committed -
In order to avoid racy-git, we zero out the file size for entries with the same timestamp as the index (or during the initial checkout). This is the case in a couple of crlf tests, as the code is fast enough to do everything in the same second. As we know that we do not perform the modification just after writing out the index, which is what this is designed to work around, tick the mtime of the index file such that it doesn't agree with the files anymore, and we do not zero out these entries.
Carlos Martín Nieto committed -
If a file entry has the same timestamp as the index itself, it is considered racily-clean, as it may have been modified after the index was written, but during the same second. We take extra steps to check the contents, but this is just one part of avoiding races. For files which do have changes but have not been updated in the index, updating the on-disk index means updating its timestamp, which means we would no longer recognise these entries as racy and we would trust the timestamp to tell us whether they have changed. In order to work around this, git zeroes out the file-size field in entries with the same timestamp as the index in order to force the next diff to check the contents. Do so in libgit2 as well.
Carlos Martín Nieto committed -
We update the index and then immediately change the contents of the file. This makes the diff think there are no changes, as the timestamp of the file agrees with the cached data. This is however a bug, as the file has obviously changed contents. The test is a bit fragile, as it assumes that the index writing and the following modification of the file happen in the same second, but it's enough to show the issue.
Carlos Martín Nieto committed
-
- 15 Jun, 2015 8 commits
-
-
Fix visibility of transaction symbol
Edward Thomson committed -
Pierre-Olivier Latour committed
-
path: remove unnecessary readdir_r usage
Edward Thomson committed -
Arguably all uses of readdir_r are unnecessary, but in this case especially so, as the directory handle only exists within this function, so we don't race with anybody.
Carlos Martín Nieto committed -
clone: fall back to copying when linking does not work
Carlos Martín Nieto committed -
Fix in stransport_stream.c for usage of SecCopyErrorMessageString(), which is unavailable to iOS targets.
Logan Collins committed -
Binary diffs: store deltas in the diff structure, include binary data in diff callbacks
Carlos Martín Nieto committed -
Fix leaks in tests/checkout/icase
Carlos Martín Nieto committed
-
- 12 Jun, 2015 15 commits
-
-
Fix memory leak on windows in diriter.
Carlos Martín Nieto committed -
Jeff Hostetler committed
-
Transaction.c did not include the visibility definition of its symbol (that are in git2/transaction.h) and so was by default hidden.
Damien PROFETA committed -
Jeff Hostetler committed
-
Edward Thomson committed
-
Edward Thomson committed
-
Edward Thomson committed
-
Introduce a new binary diff callback to provide the actual binary delta contents to callers. Create this data from the diff contents (instead of directly from the ODB) to support binary diffs including the workdir, not just things coming out of the ODB.
Edward Thomson committed -
Edward Thomson committed
-
Fixed some Secure Transport issues on OS X
Carlos Martín Nieto committed -
travis: fail if we fail the push tests
Carlos Martín Nieto committed -
Carlos Martín Nieto committed
-
We need to pass these options in order to have the credentials callback set.
Carlos Martín Nieto committed -
These tests were not being taken into consideration for the failure of the test. They've been failing for a while now, but we hadn't noticed as Travis was reporting the builds successful.
Carlos Martín Nieto committed -
The read and write callbacks passed to SSLSetIOFuncs() have been rewritten to match the implementation used on opensource.apple.com and other open source projects like VLC. This change also fixes a bug where the read callback could get into an infinite loop when 0 bytes were read.
Pierre-Olivier Latour committed
-
- 11 Jun, 2015 3 commits
-
-
cred_helpers: Add 'const' qualifiers to git_cred_userpass_payload
Carlos Martín Nieto committed -
Some tools create multiple author fields. git is rather lax when parsing them, although fsck does complain about them. This means that they exist in the wild. As it's not too taxing to check for them, and there shouldn't be a noticeable slowdown when dealing with correct commits, add logic to skip over these extra fields when parsing the commit.
Carlos Martín Nieto committed -
Introduce `git_filter_list_contains`
Carlos Martín Nieto committed
-