1. 03 Jun, 2014 1 commit
  2. 28 May, 2014 5 commits
  3. 22 May, 2014 1 commit
  4. 21 May, 2014 2 commits
  5. 20 May, 2014 1 commit
  6. 19 May, 2014 2 commits
  7. 02 May, 2014 1 commit
  8. 26 Mar, 2014 1 commit
  9. 06 Mar, 2014 2 commits
  10. 05 Feb, 2014 1 commit
  11. 30 Jan, 2014 4 commits
  12. 27 Jan, 2014 1 commit
  13. 11 Dec, 2013 3 commits
    • Update clone doc and tests for callback return val · 8f1066a0
      Clone callbacks can return non-zero values to cancel the clone.
      This adds some tests to verify that this actually works and updates
      the documentation to be clearer that this can happen and that the
      return value will be propagated back by the clone function.
      Russell Belfer committed
    • Remove converting user error to GIT_EUSER · 25e0b157
      This changes the behavior of callbacks so that the callback error
      code is not converted into GIT_EUSER and instead we propagate the
      return value through to the caller.  Instead of using the
      giterr_capture and giterr_restore functions, we now rely on all
      functions to pass back the return value from a callback.
      
      To avoid having a return value with no error message, the user
      can call the public giterr_set_str or some such function to set
      an error message.  There is a new helper 'giterr_set_callback'
      that functions can invoke after making a callback which ensures
      that some error message was set in case the callback did not set
      one.
      
      In places where the sign of the callback return value is
      meaningful (e.g. positive to skip, negative to abort), only the
      negative values are returned back to the caller, obviously, since
      the other values allow for continuing the loop.
      
      The hardest parts of this were in the checkout code where positive
      return values were overloaded as meaningful values for checkout.
      I fixed this by adding an output parameter to many of the internal
      checkout functions and removing the overload.  This added some
      code, but it is probably a better implementation.
      
      There is some funkiness in the network code where user provided
      callbacks could be returning a positive or a negative value and
      we want to rely on that to cancel the loop.  There are still a
      couple places where an user error might get turned into GIT_EUSER
      there, I think, though none exercised by the tests.
      Russell Belfer committed
    • Further EUSER and error propagation fixes · dab89f9b
      This continues auditing all the places where GIT_EUSER is being
      returned and making sure to clear any existing error using the
      new giterr_user_cancel helper.  As a result, places that relied
      on intercepting GIT_EUSER but having the old error preserved also
      needed to be cleaned up to correctly stash and then retrieve the
      actual error.
      
      Additionally, as I encountered places where error codes were not
      being propagated correctly, I tried to fix them up.  A number of
      those fixes are included in the this commit as well.
      Russell Belfer committed
  14. 11 Nov, 2013 1 commit
    • remote: make _ls return the list directly · 359dce72
      The callback-based method of listing remote references dates back to the
      beginning of the network code's lifetime, when we didn't know any
      better.
      
      We need to keep the list around for update_tips() after disconnect() so
      let's make use of this to simply give the user a pointer to the array so
      they can write straightforward code instead of having to go through a
      callback.
      Carlos Martín Nieto committed
  15. 10 Nov, 2013 1 commit
  16. 08 Nov, 2013 1 commit
  17. 07 Nov, 2013 1 commit
  18. 03 Oct, 2013 1 commit
    • Initial iconv hookup for precomposed unicode · 219d3457
      This hooks up git_path_direach and git_path_dirload so that they
      will take a flag indicating if directory entry names should be
      tested and converted from decomposed unicode to precomposed form.
      This code will only come into play on the Apple platform and even
      then, only when certain types of filesystems are used.
      
      This involved adding a flag to these functions which involved
      changing a lot of places in the code.
      
      This was an opportunity to do a bit of code cleanup here and there,
      for example, getting rid of the git_futils_cleanupdir_r function in
      favor of a simple flag to git_futils_rmdir_r to not remove the top
      level entry.  That ended up adding depth tracking during rmdir_r
      which led to a safety check for infinite directory recursion.  Yay.
      
      This hasn't actually been tested on the Mac filesystems where the
      issue occurs.  I still need to get test environment for that.
      Russell Belfer committed
  19. 02 Oct, 2013 10 commits