- 21 Feb, 2019 4 commits
-
-
Prevent reading out of bounds memory
Patrick Steinhardt committed -
Previously, we would fail to correctly truncate the source buffer if the source has more than one line and ends with a non-newline character. In the following call, we thus truncate the source string in the middle of the second line. Without the bug fixed, we would successfully apply the patch to the source and return success. With the overflow being fixed, we should return an error now.
Patrick Steinhardt committed -
When parsing the patch image from a string, we split the string by newlines to get a line-based view of it. To split, we use `memchr` on the buffer and limit the buffer length by the original length provided by the caller. This works just fine for the first line, but for every subsequent line we need to actually subtract the amount of bytes that we have already read. The above issue can be easily triggered by having a source buffer with at least two lines, where the second line does _not_ end in a newline. Given a string "foo\nb", we have an original length of five bytes. After having extracted the first line, we will point to 'b' and again try to `memchr(p, '\n', 5)`, resulting in an out-of-bounds read of four bytes. Fix the issue by correctly subtracting the amount of bytes already read.
Erik Aigner committed -
Fix a memory leak in odb_otype_fast()
Patrick Steinhardt committed
-
- 20 Feb, 2019 4 commits
-
-
This change frees a copy of a cached object in odb_otype_fast().
lhchavez committed -
Make stdalloc__reallocarray call stdalloc__realloc
Patrick Steinhardt committed -
Remove `git_time_monotonic`
Patrick Steinhardt committed -
Fix a _very_ improbable memory leak in git_odb_new()
Patrick Steinhardt committed
-
- 17 Feb, 2019 8 commits
-
-
`git_time_monotonic` was added so that non-native bindings like rugged could get high-resolution timing for benchmarking. However, this is outside the scope of libgit2 *and* rugged decided not to use this function in the first place. Google suggests that absolutely _nobody_ is using this function and we don't want to be in the benchmarking business. Remove the function.
Edward Thomson committed -
ci: publish documentation on merge
Edward Thomson committed -
When a commit is pushed or merged into one of the release branches (master, maint/*) then push the documentation update to gh-pages.
Edward Thomson committed -
This reverts commit 2a4e866a.
Edward Thomson committed -
Edward Thomson committed
-
Edward Thomson committed
-
When a continuous integration build runs (ie a commit is pushed or merged into one of the CI branches, `master` or `maint/*`) then push the rebuilt documentation into the `gh-pages` branch.
Edward Thomson committed -
This change fixes a mostly theoretical memory leak in got_odb_new() that can only manifest if git_cache_init() fails due to running out of memory or not being able to acquire its lock.
lhchavez committed
-
- 16 Feb, 2019 1 commit
-
-
This change avoids calling realloc(3) in more than one place.
lhchavez committed
-
- 14 Feb, 2019 15 commits
-
-
Enable creation of worktree from bare repo's default branch
Edward Thomson committed -
Allow bypassing check for '.keep' file
Edward Thomson committed -
Deprecation: export the deprecated functions properly
Edward Thomson committed -
In a bare repository, HEAD usually points to the branch that is considered the "default" branch. As the current implementation for `git_branch_is_checked_out` only does a comparison of HEAD with the branch that is to be checked, it will say that the branch pointed to by HEAD in such a bare repo is checked out. Fix this by skipping the main repo's HEAD when it is bare.
Patrick Steinhardt committed -
Right now, the function `git_repository_foreach_head` will always iterate over all HEADs of the main repository and its worktrees. In some cases, it might be required to skip either of those, though. Add a flag in preparation for the following commit that enables this behaviour.
Patrick Steinhardt committed -
Libraries should use assert(3P) only very scarcely. First, we usually shouldn't cause the caller of our library to abort in case where the assert fails. Second, if code is compiled with -DNDEBUG, then the assert will not be included at all. In our `git_branch_is_checked_out` function, we have an assert that verifies that the given reference parameter is non-NULL and in fact a branch. While the first check is fine, the second is not. E.g. when compiled with -DNDEBUG, we'd proceed and treat the given reference as a branch in all cases. Fix the issue by instead treating a non-branch reference as not being checked out. This is the obvious solution, as references other than branches cannot be directly checked out.
Patrick Steinhardt committed -
We currently do not have any tests at all for the `git_branch_is_checked_out` function. Add some basic ones.
Patrick Steinhardt committed -
When adding a new worktree, we only verify that an optionally given reference is valid half-way through the function. At this point, some data structures have already been created on-disk. If we bail out due to an invalid reference, these will be left behind and need to be manually cleaned up by the user. Improve the situation by moving the reference checks to the function's preamble. Like this, we error out as early as possible and will not leave behind any files.
Patrick Steinhardt committed -
Enable hard deprecation in our builds to ensure that we do not call deprecated functions internally.
Edward Thomson committed -
Add a CMake option to enable hard deprecation; the resultant library will _not_ include any deprecated functions. This may be useful for internal CI builds that create libraries that are not shared with end-users to ensure that we do not use deprecated bits internally.
Edward Thomson committed -
Although the error functions were deprecated, we did not properly mark them as deprecated. We need to include the `deprecated.h` file in order to ensure that the functions get their export attributes. Similarly, do not define `GIT_DEPRECATE_HARD` within the library, or those functions will also not get their export attributes. Define that only on the tests and examples.
Edward Thomson committed -
ci: skip ssh tests on macOS nightly
Edward Thomson committed -
Like 811c1c0f, disable the SSH tests on macOS until we can resolve the newly introduced infrastructure issues.
Edward Thomson committed -
CI build fixups
Edward Thomson committed -
SSH tests on macOS have begun failing for an unknown reason after an infrastructure upgrade to macOS 10.13.6. Disable those tests temporarily, until we can resolve it.
Edward Thomson committed
-
- 13 Feb, 2019 2 commits
-
-
Subtle changes in the host OS can have impacts in the CI system that may be hard to debug. We previously showed the results of `uname` which can be difficult to interpret. Provide more information where available.
Edward Thomson committed -
The URL was incorrect for the nightly badge image; it was erroneously showing the master branch continuous integration build badge.
Edward Thomson committed
-
- 12 Feb, 2019 1 commit
-
-
Include a build badge for `maint/v0.28` builds.
Edward Thomson committed
-
- 02 Feb, 2019 2 commits
-
-
Dhruva Krishnamurthy committed
-
v0.28 rc1
Edward Thomson committed
-
- 31 Jan, 2019 3 commits
-
-
Edward Thomson committed
-
Edward Thomson committed
-
Docs
Edward Thomson committed
-