- 16 Sep, 2014 19 commits
-
-
This brings us back in line with the other transports.
Carlos Martín Nieto committed -
The user may have the data hashed as MD5 or SHA-1, so we should provide both types for consumption.
Carlos Martín Nieto committed -
Instead of using the libssh2 defines, provide our own, which eases usage as we do not need to check whether libgit2 was built with libssh2 or not.
Carlos Martín Nieto committed -
Carlos Martín Nieto committed
-
Instead of spreading the data in function arguments, some of which aren't used for ssh and having a struct only for ssh, use a struct for both, using a common parent to pass to the callback.
Carlos Martín Nieto committed -
Carlos Martín Nieto committed
-
Test that the certificate check callback gets the right fingerprint from the host we're connecting to.
Carlos Martín Nieto committed -
This option make it easy to ignore anything about the server we're connecting to, which is bad security practice. This was necessary as we didn't use to expose detailed information about the certificate, but now that we do, we should get rid of this. If the user wants to ignore everything, they can still provide a callback which ignores all the information passed.
Carlos Martín Nieto committed -
This should make the mingw compiler happy.
Carlos Martín Nieto committed -
If the user returns 0 from the certificate check and we had certificate issues, set the options to ignore certificate errors and resend the request.
Carlos Martín Nieto committed -
We need to call WinHttpSendRequest() in three different places. Unify all in a single function to have a single place for the certificate check.
Carlos Martín Nieto committed -
If we're not using SSL, don't call the user's certificate check callback.
Carlos Martín Nieto committed -
On successful connection, still ask the user whether they accept the server's certificate, indicating that WinHTTP would let it though.
Carlos Martín Nieto committed -
Returning 0 lets the certificate check succeed. An error code is bubbled up to the user.
Carlos Martín Nieto committed -
We know the host's key as soon as we connect, so we should perform the check as soon as we can, before we bother with the user's credentials.
Carlos Martín Nieto committed -
We should let the user decide whether to cancel the connection or not regardless of whether our checks have decided that the certificate is fine. We provide our own assessment to the callback to let the user fall back to our checks if they so desire.
Carlos Martín Nieto committed -
Carlos Martín Nieto committed
-
Instead of the parsed data, we can ask OpenSSL to give us the DER-encoded version of the certificate, which the user can then parse and validate.
Carlos Martín Nieto committed -
If the certificate validation fails (or always in the case of ssh), let the user decide whether to allow the connection. The data structure passed to the user is the native certificate information from the underlying implementation, namely OpenSSL or WinHTTP.
Carlos Martín Nieto committed
-
- 15 Sep, 2014 3 commits
-
-
Add Rust to the language bindings list
Vicent Marti committed -
Alex Crichton committed
-
When auto follow tags, FETCH_HEAD should list only newly followed tags
Vicent Marti committed
-
- 10 Sep, 2014 2 commits
-
-
signature: don't allow empty emails
Vicent Marti committed -
A signature is made up of a non-empty name and a non-empty email so let's validate that. This also brings us more in line with git, which also rejects ident with an empty email.
Carlos Martín Nieto committed
-
- 09 Sep, 2014 1 commit
-
-
Restrict which refs can be the default branch
Vicent Marti committed
-
- 05 Sep, 2014 3 commits
-
-
Linquize committed
-
Vicent Marti committed
-
ssh: store error message immediately after a failed agent call
Vicent Marti committed
-
- 04 Sep, 2014 1 commit
-
-
When the call to the agent fails, we must retrieve the error message just after the function call, as other calls may overwrite it. As the agent authentication is the only one which has a teardown and there does not seem to be a way to get the error message from a stored error number, this tries to introduce some small changes to store the error from the agent. Clearing the error at the beginning of the loop lets us know whether the agent has already set the libgit2 error message and we should skip it, or if we should set it.
Carlos Martín Nieto committed
-
- 03 Sep, 2014 5 commits
-
-
Clean up transport lookup
Vicent Marti committed -
Teach repository to use relative paths for git symbolic links
Vicent Marti committed -
Several CppCat warnings fixed
Vicent Marti committed -
Teach git_repository_init_ext to use relative paths for the gitlink to the work directory. This is used when creating a sub repository where the sub repository resides in the parent repository's .git directory.
Jameson Miller committed -
Edward Thomson committed
-
- 02 Sep, 2014 6 commits
-
-
.editorconfig added to repository
Vicent Marti committed -
Skip SSH clone tests if libgit2 not built with GIT_SSH defined
Vicent Marti committed -
Arkady Shapkin committed
-
Arkadiy Shapkin committed
-
When the fetch refspec does not include the remote's default branch, it indicates an error in user expectations or programmer error. Error out in that case. This lets us get rid of the dummy refspec which can never work as its zeroed out. In the cases where we did not find a default branch, we set HEAD detached immediately, which lets us refactor the "normal" path, removing `found_branch`.
Carlos Martín Nieto committed -
If the remote does not advertise HEAD, then it is unborn and we cannot checkout that branch. Handle it the same way as an empty repo.
Carlos Martín Nieto committed
-