The plain function will return an iterator, so move this one out of
the way.

Really report an error in foreach if we fail to allocate the iterator,
and don't fail if the config is emtpy.

Make the iterator structure opaque and make sure it compiles.

new functions in struct git_config_backend:
  * iterator_new(...)
  * iterator_free(...)
  * next(...)

The old callback based foreach style can still be used with `git_config_backend_foreach_match`

This step is needed to easily add iterators to git_config_backend
As well use these new git_strmap functions to implement foreach

* git_strmap_iter
* git_strmap_has_data(...)
* git_strmap_begin(...)
* git_strmap_end(...)
* git_strmap_next(...)

Parse config headers with quoted quotes

Parse config headers that have the last quote on the
line quoted instead of walking off the end.

More tests for ambiguous OIDs across packs

The test coverage for ambiguous OIDs was pretty thin.  This adds
a bunch of new objects both in packs, across packs, and loose that
match to 8 characters so that we can test various cases of
ambiguous lookups.

submodule: check alloc and name presence

Fixes #1762

Allow Makefile.embed to be used when cross-compiling

This option is already present in the CMake config, but was missing from `Makefile.embed` and would cause all kinds of weird failures when compiling rugged on windows with the ruby devkit.

Fix possible double close

Fix -n bug; default to all ancestors

Signed-off-by: Sven Strickroth <email@cs-ware.de>

Close p->mwf.fd only if necessary

This fixes a regression introduced in revision 9d2f841a.

Signed-off-by: Sven Strickroth <email@cs-ware.de>

This allows libgit2 to be cross-compiled (e.g. when building native rugged binaries for windows from Linux or OS X).

```
CROSS_COMPILE=i686-w64-mingw32 make -f Makefile.embed
```

Doc fixes

The description of what the function does hasn't been true for quite a
while. Change it to reflect the way it currently works.

While here, remove an even older comment about missing features that
have been implemented.

clang's docparser highlighted these.

Invalid refs on disk cause revwalk globbing to fail

The new tests don't always want to use the same fixture data as
the old ones so this makes it configurable on a per-test basis.

Instead of using lots of strdup calls, this adds a memory pool to
the loose refs iteration code and uses it for keeping track of the
loose refs array.  Memory usage could probably be reduced even
further by eliminating the vector and just scanning by adding the
strlen of each ref, but that would be a more intrusive changes.

This also updates the error handling to be more thorough about
checking for failed allocations, etc.

The git_reference_next API silently skips invalid references when
scanning the loose refs.  The git_reference_next_name API should
skip the same ones even though it isn't creating the reference
object.

This adds a test with a an invalid loose reference and makes sure
that both APIs skip the same entries and generate the same results.

Clarify when to use github issues

git_buf_text_gather_stats doesn't work for multi-byte characters

Suggest that github issues are to be used for bug reports, while questions about usage should be directed to StackOverflow.

Refresh readme and contributing guidance

Updating the contributing guidance to explain a bit more about how we use
PR's

Updated the methods of getting involved with the project and asking
questions.

Switch default calling convention to cdecl

git_revparse_ext: should return a NULL reference  when the revparse expression doesn't lead to a reference