1. 03 Jul, 2017 1 commit
    • Make sure to always include "common.h" first · 0c7f49dd
      Next to including several files, our "common.h" header also declares
      various macros which are then used throughout the project. As such, we
      have to make sure to always include this file first in all
      implementation files. Otherwise, we might encounter problems or even
      silent behavioural differences due to macros or defines not being
      defined as they should be. So in fact, our header and implementation
      files should make sure to always include "common.h" first.
      
      This commit does so by establishing a common include pattern. Header
      files inside of "src" will now always include "common.h" as its first
      other file, separated by a newline from all the other includes to make
      it stand out as special. There are two cases for the implementation
      files. If they do have a matching header file, they will always include
      this one first, leading to "common.h" being transitively included as
      first file. If they do not have a matching header file, they instead
      include "common.h" as first file themselves.
      
      This fixes the outlined problems and will become our standard practice
      for header and source files inside of the "src/" from now on.
      Patrick Steinhardt committed
  2. 26 Jun, 2014 1 commit
    • ssh: make sure to ask for a username and use the same one · ccb85c8f
      In order to know which authentication methods are supported/allowed by
      the ssh server, we need to send a NONE auth request, which needs a
      username associated with it.
      
      Most ssh server implementations do not allow switching the username
      between authentication attempts, which means we cannot use a dummy
      username and then switch. There are two ways around this.
      
      The first is to use a different connection, which an earlier commit
      implements, but this increases how long it takes to get set up, and
      without knowing the right username, we cannot guarantee that the
      list we get in response is the right one.
      
      The second is what's implemented here: if there is no username specified
      in the url, ask for it first. We can then ask for the list of auth
      methods and use the user's credentials in the same connection.
      Carlos Martín Nieto committed
  3. 04 Feb, 2013 1 commit
  4. 31 Jan, 2013 1 commit
  5. 09 Jan, 2013 1 commit