1. 23 Feb, 2022 1 commit
  2. 17 Oct, 2021 1 commit
    • str: introduce `git_str` for internal, `git_buf` is external · f0e693b1
      libgit2 has two distinct requirements that were previously solved by
      `git_buf`.  We require:
      
      1. A general purpose string class that provides a number of utility APIs
         for manipulating data (eg, concatenating, truncating, etc).
      2. A structure that we can use to return strings to callers that they
         can take ownership of.
      
      By using a single class (`git_buf`) for both of these purposes, we have
      confused the API to the point that refactorings are difficult and
      reasoning about correctness is also difficult.
      
      Move the utility class `git_buf` to be called `git_str`: this represents
      its general purpose, as an internal string buffer class.  The name also
      is an homage to Junio Hamano ("gitstr").
      
      The public API remains `git_buf`, and has a much smaller footprint.  It
      is generally only used as an "out" param with strict requirements that
      follow the documentation.  (Exceptions exist for some legacy APIs to
      avoid breaking callers unnecessarily.)
      
      Utility functions exist to convert a user-specified `git_buf` to a
      `git_str` so that we can call internal functions, then converting it
      back again.
      Edward Thomson committed
  3. 24 Jan, 2020 1 commit
    • http: send probe packets · 76fd406a
      When we're authenticating with a connection-based authentication scheme
      (NTLM, Negotiate), we need to make sure that we're still connected
      between the initial GET where we did the authentication and the POST
      that we're about to send.  Our keep-alive session may have not kept
      alive, but more likely, some servers do not authenticate the entire
      keep-alive connection and may have "forgotten" that we were
      authenticated, namely Apache and nginx.
      
      Send a "probe" packet, that is an HTTP POST request to the upload-pack
      or receive-pack endpoint, that consists of an empty git pkt ("0000").
      If we're authenticated, we'll get a 200 back.  If we're not, we'll get a
      401 back, and then we'll resend that probe packet with the first step of
      our authentication (asking to start authentication with the given
      scheme).  We expect _yet another_ 401 back, with the authentication
      challenge.
      
      Finally, we will send our authentication response with the actual POST
      data.  This will allow us to authenticate without draining the POST data
      in the initial request that gets us a 401.
      Edward Thomson committed
  4. 10 Jun, 2019 1 commit