1. 27 Nov, 2020 1 commit
  2. 11 Oct, 2020 4 commits
  3. 29 Nov, 2019 1 commit
    • global: convert to fiber-local storage to fix exit races · 5c6180b5
      On Windows platforms, we automatically clean up the thread-local storage
      upon detaching a thread via `DllMain()`. The thing is that this happens
      for every thread of applications that link against the libgit2 DLL, even
      those that don't have anything to do with libgit2 itself. As a result,
      we cannot assume that these unsuspecting threads make use of our
      `git_libgit2_init()` and `git_libgit2_shutdow()` reference counting,
      which may lead to racy situations:
      
          Thread 1                    Thread 2
      
          git_libgit2_shutdown()
                                      DllMain(DETACH_THREAD)
                                      git__free_tls_data()
          git_atomic_dec() == 0
          git__free_tls_data()
          TlsFree(_tls_index)
                                      TlsGetValue(_tls_index)
      
      Due to the second thread never having executed `git_libgit2_init()`, the
      first thread will clean up TLS data and as a result also free the
      `_tls_index` variable. When detaching the second thread, we
      unconditionally access the now-free'd `_tls_index` variable, which is
      obviously not going to work out well.
      
      Fix the issue by converting the code to use fiber-local storage instead
      of thread-local storage. While FLS will behave the exact same as TLS if
      no fibers are in use, it does allow us to specify a destructor similar
      to the one that is accepted by pthread_key_create(3P). Like this, we do
      not have to manually free indices anymore, but will let the FLS handle
      calling the destructor. This allows us to get rid of `DllMain()`
      completely, as we only used it to keep track of when threads were
      exiting and results in an overall simplification of TLS cleanup.
      Patrick Steinhardt committed
  4. 24 Jun, 2019 1 commit
    • win32: cast GetProcAddress to void * before casting · 759ec7d4
      GetProcAddress is prototyped to return a `FARPROC`, which is meant to be
      a generic function pointer.  It's literally `int (FAR WINAPI * FARPROC)()`
      which gcc complains if you attempt to cast to a `void (*)(GIT_SRWLOCK *)`.
      Cast to a `void *` before casting to avoid warnings about the arguments.
      Edward Thomson committed
  5. 03 Jul, 2017 1 commit
    • Make sure to always include "common.h" first · 0c7f49dd
      Next to including several files, our "common.h" header also declares
      various macros which are then used throughout the project. As such, we
      have to make sure to always include this file first in all
      implementation files. Otherwise, we might encounter problems or even
      silent behavioural differences due to macros or defines not being
      defined as they should be. So in fact, our header and implementation
      files should make sure to always include "common.h" first.
      
      This commit does so by establishing a common include pattern. Header
      files inside of "src" will now always include "common.h" as its first
      other file, separated by a newline from all the other includes to make
      it stand out as special. There are two cases for the implementation
      files. If they do have a matching header file, they will always include
      this one first, leading to "common.h" being transitively included as
      first file. If they do not have a matching header file, they instead
      include "common.h" as first file themselves.
      
      This fixes the outlined problems and will become our standard practice
      for header and source files inside of the "src/" from now on.
      Patrick Steinhardt committed
  6. 18 Nov, 2016 1 commit
    • threads: introduce `git_thread_exit` · 82f15896
      Introduce `git_thread_exit`, which will allow threads to terminate at an
      arbitrary time, returning a `void *`.  On Windows, this means that we
      need to store the current `git_thread` in TLS, so that we can set its
      `return` value when terminating.
      
      We cannot simply use `ExitThread`, since Win32 returns `DWORD`s from
      threads; we return `void *`.
      Edward Thomson committed
  7. 20 Jun, 2016 8 commits
  8. 18 Apr, 2015 1 commit
  9. 17 Apr, 2015 1 commit
  10. 07 Jun, 2014 2 commits
  11. 17 Sep, 2013 2 commits
    • Bug fixes and cleanups · eefc32d5
      This contains a few bug fixes and some header and API cleanups.
      
      The main API change is that filters should now use GIT_PASSTHROUGH
      to indicate that they wish to skip processing a file instead of
      GIT_ENOTFOUND.
      
      The bug fixes include a possible out-of-range buffer access in
      the ident filter, a filter ordering problem I introduced into the
      custom filter tests on Windows, and a filter buf NUL termination
      issue that was coming up on Linux.
      Russell Belfer committed
    • Add simple global shutdown hooks · a3aa5f4d
      Increasingly there are a number of components that want to do some
      cleanup at global shutdown time (at least if there are not going
      to be memory leaks).  This creates a very simple system of shutdown
      hooks that will be invoked by git_threads_shutdown.  Right now, the
      maximum number of hooks is hardcoded, but since adding a hook is
      not a public API, it should be fine and I thought it was better to
      start off with really simple code.
      Russell Belfer committed
  12. 27 Aug, 2013 1 commit
  13. 26 Aug, 2013 1 commit
  14. 22 Aug, 2013 1 commit
  15. 30 May, 2013 1 commit
  16. 22 Apr, 2013 2 commits
  17. 08 Jan, 2013 1 commit
  18. 17 Oct, 2012 1 commit
  19. 16 Oct, 2012 1 commit
  20. 15 Mar, 2012 1 commit
    • Continue error conversion · deafee7b
      This converts blob.c, fileops.c, and all of the win32 files.
      Also, various minor cleanups throughout the code.  Plus, in
      testing the win32 build, I cleaned up a bunch (although not
      all) of the warnings with the 64-bit build.
      Russell Belfer committed
  21. 02 Mar, 2012 1 commit
    • Clean up GIT_UNUSED macros on all platforms · 854eccbb
      It turns out that commit 31e9cfc4cbcaf1b38cdd3dbe3282a8f57e5366a5
      did not fix the GIT_USUSED behavior on all platforms.  This commit
      walks through and really cleans things up more thoroughly, getting
      rid of the unnecessary stuff.
      
      To remove the use of some GIT_UNUSED, I ended up adding a couple
      of new iterators for hashtables that allow you to iterator just
      over keys or just over values.
      
      In making this change, I found a bug in the clar tests (where we
      were doing *count++ but meant to do (*count)++ to increment the
      value).  I fixed that but then found the test failing because it
      was not really using an empty repo.  So, I took some of the code
      that I wrote for iterator testing and moved it to clar_helpers.c,
      then made use of that to make it easier to open fixtures on a
      per test basis even within a single test file.
      Russell Belfer committed
  22. 13 Feb, 2012 1 commit
  23. 19 Sep, 2011 1 commit
    • Tabify everything · 87d9869f
      There were quite a few places were spaces were being used instead of
      tabs. Try to catch them all. This should hopefully not break anything.
      Except for `git blame`. Oh well.
      Vicent Marti committed
  24. 18 Sep, 2011 1 commit
    • Cleanup legal data · bb742ede
      1. The license header is technically not valid if it doesn't have a
      copyright signature.
      
      2. The COPYING file has been updated with the different licenses used in
      the project.
      
      3. The full GPLv2 header in each file annoys me.
      Vicent Marti committed
  25. 23 May, 2011 1 commit
  26. 08 May, 2011 1 commit
  27. 20 Mar, 2011 1 commit