1. 18 Mar, 2015 1 commit
  2. 10 Dec, 2014 1 commit
  3. 27 Oct, 2014 2 commits
  4. 22 Sep, 2014 1 commit
  5. 16 Sep, 2014 8 commits
  6. 04 Sep, 2014 1 commit
    • ssh: store error message immediately after a failed agent call · 2dc399a8
      When the call to the agent fails, we must retrieve the error message
      just after the function call, as other calls may overwrite it.
      
      As the agent authentication is the only one which has a teardown and
      there does not seem to be a way to get the error message from a stored
      error number, this tries to introduce some small changes to store the
      error from the agent.
      
      Clearing the error at the beginning of the loop lets us know whether the
      agent has already set the libgit2 error message and we should skip it,
      or if we should set it.
      Carlos Martín Nieto committed
  7. 05 Aug, 2014 1 commit
  8. 16 Jul, 2014 1 commit
  9. 07 Jul, 2014 1 commit
  10. 03 Jul, 2014 1 commit
  11. 02 Jul, 2014 1 commit
    • ssh: libssh2_channel_write() behaves like send() · 0963716b
      When the stream writing function was written, it assume that
      libssh2_channel_write() would always write all of the data to the
      wire. This is only true for the first 32k of data, which it tries to
      fit into one ssh packet.
      
      Since it can perform short writes, call it in a loop like we do for
      send(), advancing the buffer offset.
      Carlos Martín Nieto committed
  12. 26 Jun, 2014 2 commits
    • ssh: make sure to ask for a username and use the same one · ccb85c8f
      In order to know which authentication methods are supported/allowed by
      the ssh server, we need to send a NONE auth request, which needs a
      username associated with it.
      
      Most ssh server implementations do not allow switching the username
      between authentication attempts, which means we cannot use a dummy
      username and then switch. There are two ways around this.
      
      The first is to use a different connection, which an earlier commit
      implements, but this increases how long it takes to get set up, and
      without knowing the right username, we cannot guarantee that the
      list we get in response is the right one.
      
      The second is what's implemented here: if there is no username specified
      in the url, ask for it first. We can then ask for the list of auth
      methods and use the user's credentials in the same connection.
      Carlos Martín Nieto committed
    • ssh: request credentials again on authentication failure · d7f962f4
      Instead of completely giving up on the first failure, ask for
      credentials as long as we fail to authenticate.
      Carlos Martín Nieto committed
  13. 17 Jun, 2014 2 commits
  14. 22 Apr, 2014 1 commit
  15. 18 Apr, 2014 3 commits
    • Introduce git_cred_ssh_interactive_new() · 478408c0
      This allows for keyboard-interactive based SSH authentication
      Jacques Germishuys committed
    • cred: tighten username rules · bd270b70
      The ssh-specific credentials allow the username to be missing. The idea
      being that the ssh transport will then use the username provided in the
      url, if it's available. There are two main issues with this.
      
      The credential callback already knows what username was provided by the
      url and needs to figure out whether it wants to ask the user for it or
      it can reuse it, so passing NULL as the username means the credential
      callback is suspicious.
      
      The username provided in the url is not in fact used by the
      transport. The only time it even considers it is for the user/pass
      credential, which asserts the existence of a username in its
      constructor. For the ssh-specific ones, it passes in the username stored
      in the credential, which is NULL. The libssh2 macro we use runs strlen()
      against this value (which is no different from what we would be doing
      ourselves), so we then crash.
      
      As the documentation doesn't suggest to leave out the username, assert
      the need for a username in the code, which removes this buggy behavior
      and removes implicit state.
      
      git_cred_has_username() becomes a blacklist of credential types that do
      not have a username. The only one at the moment is the 'default' one,
      which is meant to call up some Microsoft magic.
      Carlos Martín Nieto committed
  16. 25 Feb, 2014 1 commit
  17. 20 Nov, 2013 1 commit
  18. 05 Nov, 2013 1 commit
  19. 04 Nov, 2013 1 commit
  20. 31 Oct, 2013 1 commit
  21. 23 Oct, 2013 1 commit
  22. 21 Oct, 2013 1 commit
  23. 16 Sep, 2013 2 commits
  24. 09 Sep, 2013 1 commit
  25. 08 Sep, 2013 1 commit
  26. 14 Aug, 2013 1 commit
  27. 12 Aug, 2013 1 commit