1. 28 Dec, 2012 2 commits
    • Invalid ref name normalization leaked memory · 3865f7f6
      When normalizing a reference name, if there is an error because
      the name is invalid, then the memory allocated for storing the
      name could be leaked if the caller was not careful and assumed
      that the error return code meant that no allocation had occurred.
      
      This fixes that by explicitly deallocating the reference name
      buffer if there is an error in normalizing the name.
      Russell Belfer committed
    • Make spoolandsort a pushable iterator behavior · f616a36b
      An earlier change to `git_diff_from_iterators` introduced a
      memory leak where the allocated spoolandsort iterator was not
      returned to the caller and thus not freed.
      
      One proposal changes all iterator APIs to use git_iterator** so
      we can reallocate the iterator at will, but that seems unexpected.
      This commit makes it so that an iterator can be changed in place.
      The callbacks are isolated in a separate structure and a pointer
      to that structure can be reassigned by the spoolandsort extension.
      
      This means that spoolandsort doesn't create a new iterator; it
      just allocates a new block of callbacks (along with space for its
      own extra data) and swaps that into the iterator.
      
      Additionally, since spoolandsort is only needed to switch the
      case sensitivity of an iterator, this simplifies the API to only
      take the ignore_case boolean and to be a no-op if the iterator
      already matches the requested case sensitivity.
      Russell Belfer committed
  2. 27 Dec, 2012 1 commit
  3. 26 Dec, 2012 2 commits
  4. 22 Dec, 2012 1 commit
  5. 21 Dec, 2012 2 commits
  6. 20 Dec, 2012 2 commits
  7. 19 Dec, 2012 21 commits
  8. 18 Dec, 2012 7 commits
  9. 17 Dec, 2012 2 commits