1. 23 Feb, 2022 1 commit
  2. 05 Jan, 2022 1 commit
  3. 17 Oct, 2021 1 commit
    • str: introduce `git_str` for internal, `git_buf` is external · f0e693b1
      libgit2 has two distinct requirements that were previously solved by
      `git_buf`.  We require:
      
      1. A general purpose string class that provides a number of utility APIs
         for manipulating data (eg, concatenating, truncating, etc).
      2. A structure that we can use to return strings to callers that they
         can take ownership of.
      
      By using a single class (`git_buf`) for both of these purposes, we have
      confused the API to the point that refactorings are difficult and
      reasoning about correctness is also difficult.
      
      Move the utility class `git_buf` to be called `git_str`: this represents
      its general purpose, as an internal string buffer class.  The name also
      is an homage to Junio Hamano ("gitstr").
      
      The public API remains `git_buf`, and has a much smaller footprint.  It
      is generally only used as an "out" param with strict requirements that
      follow the documentation.  (Exceptions exist for some legacy APIs to
      avoid breaking callers unnecessarily.)
      
      Utility functions exist to convert a user-specified `git_buf` to a
      `git_str` so that we can call internal functions, then converting it
      back again.
      Edward Thomson committed
  4. 01 Aug, 2019 2 commits
  5. 20 Jul, 2019 1 commit
  6. 15 Jun, 2019 2 commits
    • config_file: use `wildmatch` to evaluate conditionals · 5811e3ba
      We currently use `p_fnmatch` to compute whether a given "gitdir:"
      or "gitdir/i:" conditional matches the current configuration file
      path. As git.git has moved to use `wildmatch` instead of
      `p_fnmatch` throughout its complete codebase, we evaluate
      conditionals inconsistently with git.git in some special cases.
      
      Convert `p_fnmatch` to use `wildmatch`. The `FNM_LEADINGDIR` flag
      cannot be translated to `wildmatch`, but in fact git.git doesn't
      use it here either. And in fact, dropping it while we go
      increases compatibility with git.git.
      Patrick Steinhardt committed
    • config_file: do not include trailing '/' for "gitdir" conditionals · cf1a114b
      When evaluating "gitdir:" and "gitdir/i:" conditionals, we
      currently compare the given pattern with the value of
      `git_repository_path`. Thing is though that `git_repository_path`
      returns the gitdir path with trailing '/', while we actually need
      to match against the gitdir without it.
      
      Fix this issue by stripping the trailing '/' previous to
      matching. Add various tests to ensure we get this right.
      Patrick Steinhardt committed
  7. 10 Jun, 2018 1 commit
  8. 31 Oct, 2017 1 commit
  9. 09 Oct, 2017 2 commits