1. 03 Jul, 2017 1 commit
    • Make sure to always include "common.h" first · 0c7f49dd
      Next to including several files, our "common.h" header also declares
      various macros which are then used throughout the project. As such, we
      have to make sure to always include this file first in all
      implementation files. Otherwise, we might encounter problems or even
      silent behavioural differences due to macros or defines not being
      defined as they should be. So in fact, our header and implementation
      files should make sure to always include "common.h" first.
      
      This commit does so by establishing a common include pattern. Header
      files inside of "src" will now always include "common.h" as its first
      other file, separated by a newline from all the other includes to make
      it stand out as special. There are two cases for the implementation
      files. If they do have a matching header file, they will always include
      this one first, leading to "common.h" being transitively included as
      first file. If they do not have a matching header file, they instead
      include "common.h" as first file themselves.
      
      This fixes the outlined problems and will become our standard practice
      for header and source files inside of the "src/" from now on.
      Patrick Steinhardt committed
  2. 29 Dec, 2016 1 commit
  3. 19 Aug, 2015 1 commit
  4. 02 Jun, 2015 1 commit
  5. 27 May, 2015 3 commits
  6. 13 Feb, 2015 2 commits
  7. 26 Jun, 2014 2 commits
  8. 18 Apr, 2014 4 commits
    • Introduce git_cred_ssh_interactive_new() · 478408c0
      This allows for keyboard-interactive based SSH authentication
      Jacques Germishuys committed
    • cred: tighten username rules · bd270b70
      The ssh-specific credentials allow the username to be missing. The idea
      being that the ssh transport will then use the username provided in the
      url, if it's available. There are two main issues with this.
      
      The credential callback already knows what username was provided by the
      url and needs to figure out whether it wants to ask the user for it or
      it can reuse it, so passing NULL as the username means the credential
      callback is suspicious.
      
      The username provided in the url is not in fact used by the
      transport. The only time it even considers it is for the user/pass
      credential, which asserts the existence of a username in its
      constructor. For the ssh-specific ones, it passes in the username stored
      in the credential, which is NULL. The libssh2 macro we use runs strlen()
      against this value (which is no different from what we would be doing
      ourselves), so we then crash.
      
      As the documentation doesn't suggest to leave out the username, assert
      the need for a username in the code, which removes this buggy behavior
      and removes implicit state.
      
      git_cred_has_username() becomes a blacklist of credential types that do
      not have a username. The only one at the moment is the 'default' one,
      which is meant to call up some Microsoft magic.
      Carlos Martín Nieto committed
  9. 20 Nov, 2013 1 commit
  10. 18 Nov, 2013 1 commit
  11. 23 Oct, 2013 1 commit
  12. 21 Oct, 2013 1 commit
  13. 12 Aug, 2013 1 commit
  14. 10 Jul, 2013 1 commit
  15. 09 Jul, 2013 4 commits
  16. 17 Jun, 2013 1 commit
  17. 15 May, 2013 2 commits
  18. 07 May, 2013 2 commits
  19. 04 May, 2013 1 commit
  20. 09 Jan, 2013 2 commits
  21. 08 Jan, 2013 1 commit
  22. 29 Nov, 2012 1 commit
  23. 27 Nov, 2012 1 commit
  24. 06 Nov, 2012 1 commit