1. 04 May, 2018 3 commits
    • tests: iterator::workdir: fix GCC warning · 1bf57b5a
      Since GCC 8.1, the compiler performs some bounds checking when
      copying static data into arrays with a known size. In one test,
      we print a format string of "%s/sub%02d" into a buffer of 64
      bytes. The input buffer for the first "%s" is bounded to at most
      63 characters, plus four bytes for the static string "/sub" plus
      two more bytes for "%02d". Thus, our target buffer needs to be at
      least 70 bytes in size, including the NUL byte. There seems to be
      a bug in the analysis, though, because GCC will not account for
      the limiting "%02" prefix, treating it as requiring the same
      count of bytes as a "%d".
      
      Thus, we end up at 79 bytes that are required to fix the
      warning. To make it look nicer and less special, we just round
      the buffer size up to 80 bytes.
      Patrick Steinhardt committed
    • tests: refs::normalize: simplify code to avoid GCC warning · 0750d0cc
      Since version 8.1, GCC will do some automatic bounds checking
      when printing static content into a buffer with known size. The
      bounds checking doesn't yet work quite right in all scenarios and
      may thus lead to false positives. Fix one of these false
      positives in refs::normalize by simplifying the code.
      Patrick Steinhardt committed
    • streams: openssl: fix bogus warning on unused parameter · ba5e39ac
      Our provided callback function `threadid_cb(CRYPTO_THREADID
      *threadid)` sets up a unique thread ID by asking pthread for the
      current thread ID.  Since openssl version 1.1,
      `CRYPTO_THREADID_set_numeric` is simply a no-op macro, leaving
      the `threadid` argument unused after the preprocessor has
      processed the macro. GCC does not account for that situation and
      will thus complain about `threadid` being unused.
      
      Silence this warning by using `GIT_UNUSED(threadid)`.
      Patrick Steinhardt committed
  2. 30 Apr, 2018 3 commits
  3. 26 Apr, 2018 1 commit
  4. 25 Apr, 2018 2 commits
  5. 22 Apr, 2018 3 commits
  6. 20 Apr, 2018 10 commits
  7. 19 Apr, 2018 1 commit
  8. 17 Apr, 2018 10 commits
  9. 16 Apr, 2018 5 commits
  10. 12 Apr, 2018 2 commits
    • revwalk: fix uninteresting revs sometimes not limiting graphwalk · 54fd80e3
      When we want to limit our graphwalk, we use the heuristic of checking
      whether the newest limiting (uninteresting) revision is newer than the
      oldest interesting revision. We do so by inspecting whether the first
      item's commit time of the user-supplied list of revisions is newer than
      the last added interesting revision. This is wrong though, as the user
      supplied list is in no way guaranteed to be sorted by increasing commit
      dates. This could lead us to abort the revwalk early before applying all
      relevant limiting revisions, outputting revisions which should in fact
      have been hidden.
      
      Fix the heuristic by instead checking whether _any_ of the limiting
      commits was made earlier than the last interesting commit. Add a test.
      Patrick Steinhardt committed
    • Merge pull request #4613 from pks-t/pks/local-fetch-symrefs · c587d806
      transports: local: fix assert when fetching into repo with symrefs
      Patrick Steinhardt committed