Minor fixes

Return -1 to stop the iteration instead of not-0

git_tree_walk callback return value semantic does not match documentation

Fix message prettify length check

If you want to be absolutely safe with git_message_prettify, you
can now pass a NULL pointer for the buffer and get back the number
of bytes that would be copied into the buffer.

This means that an error is a non-negative return code and a
success will be greater than zero from this function.

git_note_foreach: Fix documentation for notes_ref parameter

git_note_oid: Fix the documentation to reference parameters using the correct names

git_note_create: Copyediting on documentation for the oid parameter

Fix incorrect array size in example for git_config_get_mapped

Config file parser includes = in name if no space around it

Returning a negative cancels the walk, and returning a positive one
causes us to skip an entry, which was previously done by a negative
value.

This allows us to stay consistent with the rest of the functions that
take a callback and keeps the skipping functionality.

However, there should be a way to cancel the walk and another to skip
the entry.

Okay, this is probably cleaner and it is also less net change
from the original version

This makes the message prettify buffer length check accurate.

The config file parser was not working right if there was no
whitespace between the value name and the equals sign.  This
fixes that.

In the documentation for git_config_get_mapped, the sample mapping
array uses [3] but has 4 entries.  Fix by dropping the size entirely and
letting the compiler figure it out.

Export git_attr_value

Commit 0c9eacf3 introduced the function
git_attr_value and switched the GIT_ATTR_* macros to use it, but
attempting to use that function leads to a linker error (undefined
reference to `git_attr_value').  Export git_attr_value so programs can
actually call it.

Parse ref oids without trailing newline

There is a little cleanup necessary from PR #843.  Since the
new callbacks return `GIT_EUSER` we have to be a little careful
about return values when they are used internally to the library.

Also, callbacks should be checked for non-zero return values,
not just less than zero.

Conflicts:
	src/notes.c
	src/transports/git.c
	src/transports/http.c
	src/transports/local.c
	tests-clar/odb/foreach.c

Otherwise we get an incomplete type error, since git_remote_callbacks
isn't declared yet.

Missed this one, ironically enough.

This updates all the `foreach()` type functions across the library
that take callbacks from the user to have a consistent behavior.
The rules are:

* A callback terminates the loop by returning any non-zero value
* Once the callback returns non-zero, it will not be called again
  (i.e. the loop stops all iteration regardless of state)
* If the callback returns non-zero, the parent fn returns GIT_EUSER
* Although the parent returns GIT_EUSER, no error will be set in
  the library and `giterr_last()` will return NULL if called.

This commit makes those changes across the library and adds tests
for most of the iteration APIs to make sure that they follow the
above rules.