- 27 Feb, 2013 1 commit
-
-
When creating files, instead of actually using GIT_FILEMODE_BLOB and the other various constants that happen to correspond to mode values, apparently I should be just using 0666 and 0777, and relying on the umask to clear bits and make the value sane. This fixes the rules for copying a template directory and fixes the checks to match that new behavior. (Further changes to the checkout logic to follow separately.)
Russell Belfer committed
-
- 26 Feb, 2013 2 commits
-
-
The new tests were not taking core.filemode into account when testing file modes after repo initialization. Fixed that and some other Windows warnings that have crept in.
Russell Belfer committed -
When PR #1359 removed the hooks from the test resources/template directory, it made me realize that the tests for git_repository_init_ext using templates must be pretty shabby because we could not have been testing if the hooks were getting created correctly. So, this started with me recreating a couple of hooks, including a sample and symlink, and adding tests that they got created correctly in the various circumstances, including with the SHARED modes, etc. Unfortunately this uncovered some issues with how directories and symlinks were copied and chmod'ed. Also, there was a FIXME in the code related to the chmod behavior as well. Going back over the directory creation logic for setting up a repository, I found it was a little difficult to read and could result in creating and/or chmod'ing directories that the user almost certainly didn't intend. So that let to this work which makes repo initialization much more careful (and hopefully easier to follow). It required a couple of extensions / changes to core fileops utilities, but I also think those are for the better, at least for git_futils_cp_r in terms of being careful about what actions it takes.
Russell Belfer committed
-
- 25 Feb, 2013 2 commits
-
-
Remove sample hook files
Vicent Martí committed -
Getting rid of sample hook files from test repos as they just take up space with no value.
Martin Woodward committed
-
- 23 Feb, 2013 1 commit
-
-
Portability fixes for Solaris
Vicent Martí committed
-
- 22 Feb, 2013 11 commits
-
-
Do not fail if .gitignore is directory
Vicent Martí committed -
This is designed to fix libgit2sharp #350 where if .gitignore is a directory we abort all operations that process ignores instead of just skipping it as core git does. Also added test that fails without this change and passes with it.
Russell Belfer committed -
Philip Kelley committed
-
Teach git_branch_remote_name() to work with orphaned heads
Vicent Martí committed -
Fix git_stash_drop()
Vicent Martí committed -
Philip Kelley committed
-
nulltoken committed
-
nulltoken committed
-
nulltoken committed
-
nulltoken committed
-
nulltoken committed
-
- 21 Feb, 2013 2 commits
-
-
add a sorter to the reuc on index creation
Vicent Martí committed -
Edward Thomson committed
-
- 20 Feb, 2013 11 commits
-
-
Add more treebuilder tests
Vicent Martí committed -
The recent changes with git_treebuilder_entrycount point out that the test coverage for git_treebuilder_remove and git_treebuilder_entrycount is completely absent. This adds tests.
Russell Belfer committed -
Add explicit entrycount to tree builder
Vicent Martí committed -
This replaces most of the explicit vector iteration with calls to git_vector_foreach, adds in some git__free and giterr_clear calls to clean up during some error paths, and a couple of other code simplifications.
Russell Belfer committed -
The treebuilder entries vector flags removed items which means we can't rely on the entries vector length to accurately get the number of entries. This adds an entrycount value and maintains it while updating the treebuilder entries.
Russell Belfer committed -
Simplify signature parsing
Russell Belfer committed -
Disable caching in Clar
Vicent Martí committed -
Vicent Marti committed
-
Vicent Marti committed
-
Vicent Marti committed
-
Vicent Marti committed
-
- 17 Feb, 2013 1 commit
-
-
Fix static analyzer issues
Vicent Martí committed
-
- 16 Feb, 2013 2 commits
-
-
The cppcheck static analyzer generates warnings for a bunch of places in the libgit2 code base. All the ones fixed in this commit are actually false positives, but I've reorganized the code to hopefully make it easier for static analysis tools to correctly understand the structure. I wouldn't do this if I felt like it was making the code harder to read or worse for humans, but in this case, these fixes don't seem too bad and will hopefully make it easier for better analysis tools to get at any real issues.
Russell Belfer committed -
If gethostbyname() fails on platforms with NO_ADDRINFO, the code leaks the struct addrinfo that was allocated. This fixes that (and a number of code formatting issues in that area of code in src/posix.c).
Russell Belfer committed
-
- 15 Feb, 2013 3 commits
-
-
There were a number of functions assigning their return value to `error` without much explanation. I added in some rudimentary error checking to help flesh out the example. Also, I reformatted all of the comments down to 80 cols (and in some cases, slightly updated the wording).
Russell Belfer committed -
push: fix typo in git_push_finish() doc
Vicent Martí committed -
Alessandro Ghedini committed
-
- 14 Feb, 2013 4 commits
-
-
Topic/diff tree coverage
Vicent Martí committed -
push: improve docs on success / failure of git_push_finish
Vicent Martí committed -
Michael Schubert committed
-
Ben Straub committed
-