1. 27 Feb, 2013 1 commit
    • Make mode handling during init more like git · 18f08264
      When creating files, instead of actually using GIT_FILEMODE_BLOB
      and the other various constants that happen to correspond to
      mode values, apparently I should be just using 0666 and 0777, and
      relying on the umask to clear bits and make the value sane.
      
      This fixes the rules for copying a template directory and fixes
      the checks to match that new behavior.  (Further changes to the
      checkout logic to follow separately.)
      Russell Belfer committed
  2. 26 Feb, 2013 2 commits
    • Fix portability issues on Windows · 0d1b094b
      The new tests were not taking core.filemode into account when
      testing file modes after repo initialization.  Fixed that and some
      other Windows warnings that have crept in.
      Russell Belfer committed
    • Fix initialization of repo directories · 3c42e4ef
      When PR #1359 removed the hooks from the test resources/template
      directory, it made me realize that the tests for
      git_repository_init_ext using templates must be pretty shabby
      because we could not have been testing if the hooks were getting
      created correctly.
      
      So, this started with me recreating a couple of hooks, including
      a sample and symlink, and adding tests that they got created
      correctly in the various circumstances, including with the SHARED
      modes, etc.  Unfortunately this uncovered some issues with how
      directories and symlinks were copied and chmod'ed.  Also, there
      was a FIXME in the code related to the chmod behavior as well.
      
      Going back over the directory creation logic for setting up a
      repository, I found it was a little difficult to read and could
      result in creating and/or chmod'ing directories that the user
      almost certainly didn't intend.
      
      So that let to this work which makes repo initialization much
      more careful (and hopefully easier to follow).  It required a
      couple of extensions / changes to core fileops utilities, but I
      also think those are for the better, at least for git_futils_cp_r
      in terms of being careful about what actions it takes.
      Russell Belfer committed
  3. 25 Feb, 2013 2 commits
  4. 23 Feb, 2013 1 commit
  5. 22 Feb, 2013 11 commits
  6. 21 Feb, 2013 2 commits
  7. 20 Feb, 2013 11 commits
  8. 17 Feb, 2013 1 commit
  9. 16 Feb, 2013 2 commits
    • Clear up warnings from cppcheck · 56543a60
      The cppcheck static analyzer generates warnings for a bunch of
      places in the libgit2 code base.  All the ones fixed in this
      commit are actually false positives, but I've reorganized the
      code to hopefully make it easier for static analysis tools to
      correctly understand the structure.  I wouldn't do this if I
      felt like it was making the code harder to read or worse for
      humans, but in this case, these fixes don't seem too bad and will
      hopefully make it easier for better analysis tools to get at any
      real issues.
      Russell Belfer committed
    • Fix memory leak in p_getaddrinfo on Amiga · 71d62d39
      If gethostbyname() fails on platforms with NO_ADDRINFO, the code
      leaks the struct addrinfo that was allocated.  This fixes that
      (and a number of code formatting issues in that area of code in
      src/posix.c).
      Russell Belfer committed
  10. 15 Feb, 2013 3 commits
  11. 14 Feb, 2013 4 commits