1. 23 Feb, 2022 1 commit
  2. 17 Oct, 2021 1 commit
    • str: introduce `git_str` for internal, `git_buf` is external · f0e693b1
      libgit2 has two distinct requirements that were previously solved by
      `git_buf`.  We require:
      
      1. A general purpose string class that provides a number of utility APIs
         for manipulating data (eg, concatenating, truncating, etc).
      2. A structure that we can use to return strings to callers that they
         can take ownership of.
      
      By using a single class (`git_buf`) for both of these purposes, we have
      confused the API to the point that refactorings are difficult and
      reasoning about correctness is also difficult.
      
      Move the utility class `git_buf` to be called `git_str`: this represents
      its general purpose, as an internal string buffer class.  The name also
      is an homage to Junio Hamano ("gitstr").
      
      The public API remains `git_buf`, and has a much smaller footprint.  It
      is generally only used as an "out" param with strict requirements that
      follow the documentation.  (Exceptions exist for some legacy APIs to
      avoid breaking callers unnecessarily.)
      
      Utility functions exist to convert a user-specified `git_buf` to a
      `git_str` so that we can call internal functions, then converting it
      back again.
      Edward Thomson committed
  3. 11 Oct, 2020 1 commit
  4. 24 Jan, 2020 2 commits
    • http: use the new httpclient · b9c5b15a
      Untangle the notion of the http transport from the actual http
      implementation.  The http transport now uses the httpclient.
      Edward Thomson committed
    • httpclient: support expect/continue · 7372573b
      Allow users to opt-in to expect/continue handling when sending a POST
      and we're authenticated with a "connection-based" authentication
      mechanism like NTLM or Negotiate.
      
      If the response is a 100, return to the caller (to allow them to post
      their body).  If the response is *not* a 100, buffer the response for
      the caller.
      
      HTTP expect/continue is generally safe, but some legacy servers
      have not implemented it correctly.  Require it to be opt-in.
      Edward Thomson committed
  5. 10 Jun, 2019 1 commit
    • http: increase the replay count · 956ba48b
      Increase the permissible replay count; with multiple-step authentication
      schemes (NTLM, Negotiate), proxy authentication and redirects, we need
      to be mindful of the number of steps it takes to get connected.
      
      7 seems high but can be exhausted quickly with just a single authentication
      failure over a redirected multi-state authentication pipeline.
      Edward Thomson committed
  6. 28 Nov, 2018 1 commit
  7. 10 Feb, 2018 1 commit
    • http: standardize user-agent addition · ee6be190
      The winhttp and posix http each need to add the user-agent to their
      requests.  Standardize on a single function to include this so that we
      do not get the version numbers we're sending out of sync.
      
      Assemble the complete user agent in `git_http__user_agent`, returning
      assembled strings.
      
      Co-authored-by: Patrick Steinhardt <ps@pks.im>
      Edward Thomson committed