Skip to content

G
git2
Switch branch/tag
  1. 09 May, 2018 1 commit
    • cmake: resolve libraries found by pkg-config · 0f62e4c7 
      Libraries found by CMake modules are usually handled with their full
path. This makes linking against those libraries a lot more robust when
it comes to libraries in non-standard locations, as otherwise we might
mix up libraries from different locations when link directories are
given.

One excemption are libraries found by PKG_CHECK_MODULES. Instead of
returning libraries with their complete path, it will return the
variable names as well as a set of link directories. In case where
multiple sets of the same library are installed in different locations,
this can lead the compiler to link against the wrong libraries in the
end, when link directories of other dependencies are added.

To fix this shortcoming, we need to manually resolve library paths
returned by CMake against their respective library directories. This is
an easy task to do with `FIND_LIBRARY`.
      Patrick Steinhardt committed
  3. 22 Apr, 2018 3 commits
  5. 20 Apr, 2018 9 commits
  7. 19 Apr, 2018 1 commit
  9. 17 Apr, 2018 10 commits
  11. 16 Apr, 2018 5 commits
  13. 12 Apr, 2018 3 commits
    • revwalk: fix uninteresting revs sometimes not limiting graphwalk · 54fd80e3 
      When we want to limit our graphwalk, we use the heuristic of checking
whether the newest limiting (uninteresting) revision is newer than the
oldest interesting revision. We do so by inspecting whether the first
item's commit time of the user-supplied list of revisions is newer than
the last added interesting revision. This is wrong though, as the user
supplied list is in no way guaranteed to be sorted by increasing commit
dates. This could lead us to abort the revwalk early before applying all
relevant limiting revisions, outputting revisions which should in fact
have been hidden.

Fix the heuristic by instead checking whether _any_ of the limiting
commits was made earlier than the last interesting commit. Add a test.
      Patrick Steinhardt committed
    • Merge pull request #4613 from pks-t/pks/local-fetch-symrefs · c587d806 
      transports: local: fix assert when fetching into repo with symrefs
      Patrick Steinhardt committed
    • attr_file: fix handling of directory patterns with trailing spaces · 251d8771 
      When comparing whether a path matches a directory rule, we pass the
both the path and directory name to `fnmatch` with
`GIT_ATTR_FNMATCH_DIRECTORY` being set. `fnmatch` expects the pattern to
contain no trailing directory '/', which is why we try to always strip
patterns of trailing slashes. We do not handle that case correctly
though when the pattern itself has trailing spaces, causing the match to
fail.

Fix the issue by stripping trailing spaces and tabs for a rule previous
to checking whether the pattern is a directory pattern with a trailing
'/'. This replaces the whitespace-stripping in our ignore file parsing
code, which was stripping whitespaces too late. Add a test to catch
future breakage.
      Patrick Steinhardt committed
  15. 11 Apr, 2018 8 commits