- 14 Nov, 2021 1 commit
-
-
When building under gcc 11, there is a warning about a misaligned guard clause because there were mixed spaces and tabs: ``` [128/634] Building C object src/CMakeFiles/git2internal.dir/threadstate.c.o ../src/threadstate.c: In function ‘threadstate_dispose’: ../src/threadstate.c:39:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 39 | if (threadstate->error_t.message != git_str__initstr) | ^~ ../src/threadstate.c:41:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’ 41 | threadstate->error_t.message = NULL; | ^~~~~~~~~~~ ../src/threadstate.c: At top level: ``` This change indents the code with tabs for consistency with the rest of the code, which makes the warning go away.
lhchavez committed
-
- 11 Nov, 2021 34 commits
-
-
Add missing-declarations warning globally
Edward Thomson committed -
We should enforce declarations throughout the code-base, including examples, fuzzers and tests, not just in the `src` tree.
Edward Thomson committed -
Edward Thomson committed
-
Edward Thomson committed
-
Edward Thomson committed
-
Edward Thomson committed
-
Edward Thomson committed
-
Edward Thomson committed
-
Edward Thomson committed
-
Edward Thomson committed
-
Edward Thomson committed
-
Older versions of gcc do not believe that we've adequately declared our test functions. Include `clar_suite.h` conditionally for those old versions. Do not do this on newer compilers to avoid unnecessary recompilation of the entire suite when we add or remove a test function.
Edward Thomson committed -
We may want to have test function declarations; produce a header file with (only) the test declarations. Update clar to avoid overwriting the file unnecessarily to avoid bumping timestamps and potentially recompiling unnecessarily.
Edward Thomson committed -
cmake refactorings
Edward Thomson committed -
str: git_str_free is never a function
Edward Thomson committed -
Move zlib selection into its own cmake module.
Edward Thomson committed -
Move WinHTTP selection into its own cmake module.
Edward Thomson committed -
Move SSH selection into its own cmake module.
Edward Thomson committed -
Move regex selection into its own cmake module.
Edward Thomson committed -
Move http_parser selection into its own cmake module.
Edward Thomson committed -
Edward Thomson committed
-
Edward Thomson committed
-
Edward Thomson committed
-
Edward Thomson committed
-
Edward Thomson committed
-
There's no need to add the deprecation at the top-level. Our tests add deprecation explicitly.
Edward Thomson committed -
Edward Thomson committed
-
Edward Thomson committed
-
WinHTTP can now be disabled with `USE_WINHTTP=OFF` instead of `WINHTTP=OFF` to better support the other cmake semantics.
Edward Thomson committed -
Threading can now be disabled with `USE_THREADS=OFF` instead of `THREADSAFE=OFF` to better support the other cmake semantics. Nanosecond support is the default _if_ we can detect it. This should be our default always - like threads - and people can opt out explicitly.
Edward Thomson committed -
Edward Thomson committed
-
path: refactor utility path functions
Edward Thomson committed -
Support checking for object existence without refresh
Edward Thomson committed -
Document that `git_odb` is thread-safe
Edward Thomson committed
-
- 10 Nov, 2021 1 commit
-
-
Commit 4ae41f9c made `git_odb` race-free, and added internal locking. Update `docs/threading.md` accordingly, so that APIs built atop libgit2 (e.g. language bindings) can count on this.
Josh Triplett committed
-
- 09 Nov, 2021 4 commits
-
-
Edward Thomson committed
-
Edward Thomson committed
-
Edward Thomson committed
-
Edward Thomson committed
-