- 27 Feb, 2022 6 commits
-
-
Edward Thomson committed
-
Mistakenly `&&` when we should have `||`d.
Edward Thomson committed -
When we encounter a situation where we need to exit, simply `return -1` instead of trying to set `len = -1` and then jumping to the exit handler, which would erroneously do work based on the `len` value.
Edward Thomson committed -
If we're safely asserting (and returning an error to the caller), we should still unlock our mutex.
Edward Thomson committed -
Now that we safely assert and return, we may need to be in a place where we need to unlock mutexes or cleanup resources. Provide `ASSERT_WITH_CLEANUP` that permits for this behavior by taking a block.
Edward Thomson committed -
Edward Thomson committed
-
- 26 Feb, 2022 9 commits
-
-
CLI (redux)
Edward Thomson committed -
Introduce a simple command that emulates `git hash-object`.
Edward Thomson committed -
Edward Thomson committed
-
Edward Thomson committed
-
Introduce a simple command that emulates `git cat-file`.
Edward Thomson committed -
Support `help <command>` by re-invoking the command itself with the `--help` argument. This allows us to keep the help logic with the commands itself.
Edward Thomson committed -
Add a framework for commands to be defined, and add our first one, "help". When `git2_cli help` is run, the `cmd_help` function will be invoked with the remaining command line arguments. This allows users to invoke `git2_cli help foo` to get information about the `foo` subcommand.
Edward Thomson committed -
Our argument parser (https://github.com/ethomson/adopt) includes a function to print a usage message based on the allowed options. Omit this and use a cutom function that understands that we have subcommands ("checkout", "revert", etc) that each have their own options.
Edward Thomson committed -
Introduce a command-line interface for libgit2. The goal is for it to be git-compatible. 1. The libgit2 developers can more easily dogfood libgit2 to find bugs, and performance issues. 2. There is growing usage of libgit2's examples as a client; libgit2's examples should be exactly that - simple code samples that illustrate libgit2's usage. This satisfies that need directly. 3. By producing a client ourselves, we can better understand the needs of client creators, possibly producing a shared "middleware" for commonly-used pieces of client functionality like interacting with external tools. 4. Since git is the reference implementation, we may be able to benefit from git's unit tests, running their test suite against our CLI to ensure correct behavior. This commit introduces a simple infrastructure for the CLI. The CLI is currently links libgit2 statically; this is because the utility layer is required for libgit2 _but_ shares the error state handling with libgit2 itself. There's no obviously good solution here without introducing annoying indirection or more complexity. Until we can untangle that dependency, this is a good step forward. In the meantime, we link the libgit2 object files, but we do not include the (private) libgit2 headers. This constrains the CLI to the public libgit2 interfaces.
Edward Thomson committed
-
- 23 Feb, 2022 12 commits
-
-
Edward Thomson committed
-
Edward Thomson committed
-
Edward Thomson committed
-
Edward Thomson committed
-
Like we want to separate libgit2 and utility source code, we want to separate libgit2 and utility tests. Start by moving all the tests into libgit2.
Edward Thomson committed -
The `git2internal` target is actually the git library; call it such so that IDE users have visibility into it.
Edward Thomson committed -
Edward Thomson committed
-
Edward Thomson committed
-
Instead of simply including the utility files directly, make them a cmake object library for easy reusability between other projects within libgit2. Now the top-level `src` is responsible for platform selection, while the next-level `libgit2` and `util` configurations are responsible for identifying what objects they include.
Edward Thomson committed -
Edward Thomson committed
-
The `git_error_set` function is useful for callers who implement backends and advanced callbacks. Expose it.
Edward Thomson committed -
Newer gcc is complaining about `object` being potentially not initialized; initialize it.
Edward Thomson committed
-
- 22 Feb, 2022 1 commit
-
-
win32: `find_system_dirs` does not return `GIT_ENOTFOUND`
Edward Thomson committed
-
- 21 Feb, 2022 4 commits
-
-
Allow for no Git for Windows installation. When there is no GfW found in the path or registry, `git_win32__find_system_dirs` would return a `GIT_ENOTFOUND`. Callers were not expecting this. Since this is no error, we simply return `0` so that callers can move on with their lives.
Edward Thomson committed -
remote: do store the update_tips callback error value
Edward Thomson committed -
Carlos Martín Nieto committed
-
We use `git_error_set_after_callback_function` to determine whether `update_tips` returned an error but do not store its return value making us think it always returns 0. Fix it by adding the common patter of storing it inside the `if` when calling it.
Carlos Martín Nieto committed
-
- 18 Feb, 2022 4 commits
-
-
meta: update version number to v1.5.0-alpha
Edward Thomson committed -
xdiff: use xdl_free not free
Edward Thomson committed -
Free parent and ref in lg2_commit before returning.
Edward Thomson committed -
cmake: Fix package name for system http-parser
Edward Thomson committed
-
- 17 Feb, 2022 1 commit
-
-
We've added a lovely abstraction layer in xdiff so that it can call our allocation functions. But it also needs to call our free functions. We missed some `free` calls in `xmerge.c`. Update them to use `xdl_free`. Without this, we will pass a pointer allocated with a custom allocator to the system free function.
💣 Edward Thomson committed
-
- 14 Feb, 2022 3 commits
-
-
Edward Thomson committed
-
Edward Thomson committed
-
Update the version number in main to v1.5.0-alpha. This helps people understand that the main builds are not part of the v1.4.0 release train. We use "alpha" to indicate builds out of main (or nightlies) as semver v2 requires the prerelease component is compared lexicographically. Thus, our "beta" and "rc" releases should follow.
Edward Thomson committed
-