Adjust the local transport for the common refspec parser

Notes API consistency fixes

The iterator is the last argument. There is also no returned notes, just
ids, so the comment about freeing is out of place.

Make it consistent between git_note_create() and git_note_remote() by
putting it after the repository.

This is not our code and it adds unecessary changes from the upstream
code.

Spelling fixes

init: return the number of initializations

Add missing else directive

Add missing else directive to fix compiler warning: control reaches
end of non-void function

win32: clear connection data on close

fix cl_git_mkfile() to test for -1 rather than 0 for errors from p_creat...

describe: check error codes

Regain non-threadsafe builds and make the valgrind build failable

peel: reject bad queries with EPEEL

We no longer have NULL strings, but empty ones and duplicate the sides
if necessar, so the first check will never do anything.

While in the area, remove unnecessary ifs and early returns.

Valgrind is now clean except for libssl and libgcrypt.

There are some combination of objects and target types which we know
cannot be fulfilled. Return EINVALIDSPEC for those to signify that there
is a mismatch in the user-provided data and what the object model is
capable of satisfying.

If we start at a tag and in the course of peeling find out that we
cannot reach a particular type, we return EPEEL.

When flipping the default to threadsafe, we never made sure that the
tests were building non-threadsafe variants. Specify which thead-safety
we want for each.

We don't need to know the result of the travis run before determining
whether we want to consider the merge as successful.

Fix for misleading "missing delta bases" error.

Do not assume blob contents are NULL terminated

That's a bad assumption to make, even though right now it holds
(because of the way we've implemented decompression of packfiles),
this may change in the future, given that ODB objects can be
binary data.

Furthermore, the ODB object can return a NULL pointer if the object
is empty. Copying the NULL pointer to the strbuf lets us handle it
like an empty string. Again, the NULL pointer is valid behavior because
you're supposed to check the *size* of the object before working
on it.

Run shell scripts through shellcheck

Fix for memory leak issue in indexer.c, that surfaces on windows

odb: `git_odb_object` contents are never NULL

This is a contract that we made in the library and that we need to uphold. The
contents of a blob can never be NULL because several parts of the library (including
the filter and attributes code) expect `git_blob_rawcontent` to always return a
valid pointer.