- 20 Apr, 2014 1 commit
-
-
Philip Kelley committed
-
- 18 Mar, 2014 1 commit
-
-
Philip Kelley committed
-
- 11 Dec, 2013 1 commit
-
-
This changes the behavior of callbacks so that the callback error code is not converted into GIT_EUSER and instead we propagate the return value through to the caller. Instead of using the giterr_capture and giterr_restore functions, we now rely on all functions to pass back the return value from a callback. To avoid having a return value with no error message, the user can call the public giterr_set_str or some such function to set an error message. There is a new helper 'giterr_set_callback' that functions can invoke after making a callback which ensures that some error message was set in case the callback did not set one. In places where the sign of the callback return value is meaningful (e.g. positive to skip, negative to abort), only the negative values are returned back to the caller, obviously, since the other values allow for continuing the loop. The hardest parts of this were in the checkout code where positive return values were overloaded as meaningful values for checkout. I fixed this by adding an output parameter to many of the internal checkout functions and removing the overload. This added some code, but it is probably a better implementation. There is some funkiness in the network code where user provided callbacks could be returning a positive or a negative value and we want to rely on that to cancel the loop. There are still a couple places where an user error might get turned into GIT_EUSER there, I think, though none exercised by the tests.
Russell Belfer committed
-
- 18 Nov, 2013 2 commits
-
-
Edward Thomson committed
-
Edward Thomson committed
-
- 25 Oct, 2013 1 commit
-
-
Edward Thomson committed
-
- 08 Oct, 2013 2 commits
-
-
Ben Straub committed
-
Ben Straub committed
-
- 26 Sep, 2013 3 commits
-
-
Ben Straub committed
-
...and have that call manage replaced memory in the output structure.
Ben Straub committed -
Ben Straub committed
-
- 25 Sep, 2013 2 commits
-
-
Ben Straub committed
-
Ben Straub committed
-
- 19 Sep, 2013 1 commit
-
-
Linquize committed
-
- 28 Aug, 2013 1 commit
-
-
Edward Thomson committed
-
- 13 Aug, 2013 2 commits
-
-
Russell Belfer committed
-
Vicent Marti committed
-
- 08 Aug, 2013 2 commits
-
-
Ben Straub committed
-
Ben Straub committed
-
- 07 Aug, 2013 1 commit
-
-
...and normalize the signatures of the two conversion functions.
Ben Straub committed
-
- 05 Aug, 2013 1 commit
-
-
Also fixed up call-sites to use the correct buffer sizes, especially when converting to utf-8.
Ben Straub committed
-
- 12 Jun, 2013 1 commit
-
-
This fixes problems with missing function prototypes and 64-bit data issues on Windows.
Russell Belfer committed
-
- 11 May, 2013 1 commit
-
-
Linquize committed
-
- 01 Apr, 2013 1 commit
-
-
Philip Kelley committed
-
- 31 Mar, 2013 1 commit
-
-
Philip Kelley committed
-
- 14 Mar, 2013 1 commit
-
-
This fixes various build warnings on Mac and Windows (64-bit).
Russell Belfer committed
-
- 16 Feb, 2013 1 commit
-
-
The cppcheck static analyzer generates warnings for a bunch of places in the libgit2 code base. All the ones fixed in this commit are actually false positives, but I've reorganized the code to hopefully make it easier for static analysis tools to correctly understand the structure. I wouldn't do this if I felt like it was making the code harder to read or worse for humans, but in this case, these fixes don't seem too bad and will hopefully make it easier for better analysis tools to get at any real issues.
Russell Belfer committed
-
- 31 Jan, 2013 4 commits
-
-
Ben Straub committed
-
Ben Straub committed
-
Ben Straub committed
-
Ben Straub committed
-
- 11 Jan, 2013 1 commit
-
-
nulltoken committed
-
- 08 Jan, 2013 1 commit
-
-
Edward Thomson committed
-
- 10 Dec, 2012 1 commit
-
-
Ben Straub committed
-
- 29 Nov, 2012 2 commits
-
-
Philip Kelley committed
-
Philip Kelley committed
-
- 28 Nov, 2012 1 commit
-
-
Philip Kelley committed
-
- 27 Nov, 2012 1 commit
-
-
Russell Belfer committed
-
- 09 Nov, 2012 1 commit
-
-
Philip Kelley committed
-
- 06 Nov, 2012 1 commit
-
-
Philip Kelley committed
-