1. 10 Jun, 2018 1 commit
  2. 03 Jul, 2017 1 commit
    • Make sure to always include "common.h" first · 0c7f49dd
      Next to including several files, our "common.h" header also declares
      various macros which are then used throughout the project. As such, we
      have to make sure to always include this file first in all
      implementation files. Otherwise, we might encounter problems or even
      silent behavioural differences due to macros or defines not being
      defined as they should be. So in fact, our header and implementation
      files should make sure to always include "common.h" first.
      
      This commit does so by establishing a common include pattern. Header
      files inside of "src" will now always include "common.h" as its first
      other file, separated by a newline from all the other includes to make
      it stand out as special. There are two cases for the implementation
      files. If they do have a matching header file, they will always include
      this one first, leading to "common.h" being transitively included as
      first file. If they do not have a matching header file, they instead
      include "common.h" as first file themselves.
      
      This fixes the outlined problems and will become our standard practice
      for header and source files inside of the "src/" from now on.
      Patrick Steinhardt committed
  3. 13 Jun, 2017 1 commit
  4. 07 Apr, 2017 1 commit
    • filter: only close filter if it's been initialized correctly · cf07db2f
      In the function `git_filter_list_stream_data`, we initialize, write and
      subesquently close the stream which should receive content processed by
      the filter. While we skip writing to the stream if its initialization
      failed, we still try to close it unconditionally -- even if the
      initialization failed, where the stream might not be set at all, leading
      us to segfault.
      
      Semantics in this code is not really clear. The function handling the
      same logic for files instead of data seems to do the right thing here in
      only closing the stream when initialization succeeded. When stepping
      back a bit, this is only reasonable: if a stream cannot be initialized,
      the caller would not expect it to be closed again. So actually, both
      callers of `stream_list_init` fail to do so. The data streaming function
      will always close the stream and the file streaming function will not
      close the stream if writing to it has failed.
      
      The fix is thus two-fold:
      
      - callers of `stream_list_init` now close the stream iff it has been
        initialized
      - `stream_list_init` now closes the lastly initialized stream if
        the current stream in the chain failed to initialize
      
      Add a test which segfaulted previous to these changes.
      Patrick Steinhardt committed
  5. 29 Dec, 2016 1 commit
  6. 09 Feb, 2016 1 commit
  7. 12 Jul, 2015 1 commit
  8. 01 Jul, 2015 1 commit
  9. 10 Jun, 2015 2 commits
  10. 11 May, 2015 1 commit
  11. 07 May, 2015 1 commit
  12. 28 Apr, 2015 1 commit
    • Fix some build warnings · 69f0032b
      In checkout.c and filter.c we were casting a sub struct
      to a parent struct which breaks the strict aliasing rules
      in C. However we can use .parent or .base to access the
      parent struct to avoid the build warnings.
      
      In remote.c the local variable error was not initialized
      or updated in some cases. For unintialized error a build
      warning will be generated. So always keep error variable
      up-to-date.
      Leo Yang committed
  13. 25 Mar, 2015 1 commit
  14. 06 Mar, 2015 2 commits
  15. 19 Feb, 2015 4 commits
  16. 18 Feb, 2015 2 commits
  17. 17 Feb, 2015 4 commits
  18. 13 Feb, 2015 2 commits
  19. 03 Feb, 2015 1 commit
    • attrcache: don't re-read attrs during checkout · 9f779aac
      During checkout, assume that the .gitattributes files aren't
      modified during the checkout.  Instead, create an "attribute session"
      during checkout.  Assume that attribute data read in the same
      checkout "session" hasn't been modified since the checkout started.
      (But allow subsequent checkouts to invalidate the cache.)
      
      Further, cache nonexistent git_attr_file data even when .gitattributes
      files are not found to prevent re-scanning for nonexistent files.
      Edward Thomson committed
  20. 09 Oct, 2014 1 commit
  21. 08 May, 2014 2 commits
  22. 06 May, 2014 1 commit
    • Add filter options and ALLOW_UNSAFE · 5269008c
      Diff and status do not want core.safecrlf to actually raise an
      error regardless of the setting, so this extends the filter API
      with an additional options flags parameter and adds a flag so that
      filters can be applied with GIT_FILTER_OPT_ALLOW_UNSAFE, indicating
      that unsafe filter application should be downgraded from a failure
      to a warning.
      Russell Belfer committed
  23. 25 Apr, 2014 1 commit
  24. 12 Dec, 2013 1 commit
    • Cleanups, renames, and leak fixes · 9cfce273
      This renames git_vector_free_all to the better git_vector_free_deep
      and also contains a couple of memory leak fixes based on valgrind
      checks.  The fixes are specifically: failure to free global dir
      path variables when not compiled with threading on and failure to
      free filters from the filter registry that had not be initialized
      fully.
      Russell Belfer committed
  25. 24 Sep, 2013 1 commit
  26. 17 Sep, 2013 4 commits
    • Bug fixes and cleanups · eefc32d5
      This contains a few bug fixes and some header and API cleanups.
      
      The main API change is that filters should now use GIT_PASSTHROUGH
      to indicate that they wish to skip processing a file instead of
      GIT_ENOTFOUND.
      
      The bug fixes include a possible out-of-range buffer access in
      the ident filter, a filter ordering problem I introduced into the
      custom filter tests on Windows, and a filter buf NUL termination
      issue that was coming up on Linux.
      Russell Belfer committed
    • Some tests with ident and crlf filters · 37f9e409
      Fixed the filter order to match core Git, too.
      
      This test demonstrates an interesting behavior of core Git (which
      is totally reasonable and which libgit2 matches, although mostly
      by coincidence).  If you use the ident filter and commit a file
      with a garbage ident in it, like '$Id: this is just garbage$' and
      then immediately do a 'git checkout-index' with the new file, Git
      will not consider the file out of date and will not overwrite the
      file with an updated $Id$.  Libgit2 has the same behavior.  If you
      remove the file and then do a checkout-index, it will be replaced
      with a filtered version that has injected the OID correctly.
      Russell Belfer committed
    • Fix win32 warnings · e399c7ee
      I wish MSVC understood that "const char **" is not a const ptr,
      but it a non-const pointer to an array of const ptrs.  Does that
      seem like too much to ask.
      Russell Belfer committed
    • Port tests from PR 1683 · b47349b8
      This ports over some of the tests from
          https://github.com/libgit2/libgit2/pull/1683
      by @yorah and @ethomson
      Russell Belfer committed