Commit fcb48e06 by Sven Strickroth

Set p->mwf.fd to -1 on error

If p->mwf.fd is e.g. -2 then it is closed in packfile_free and an exception might be thrown.

Signed-off-by: Sven Strickroth <email@cs-ware.de>
parent c4d8df27
...@@ -564,8 +564,10 @@ static int packfile_open(struct git_pack_file *p) ...@@ -564,8 +564,10 @@ static int packfile_open(struct git_pack_file *p)
/* TODO: open with noatime */ /* TODO: open with noatime */
p->mwf.fd = git_futils_open_ro(p->pack_name); p->mwf.fd = git_futils_open_ro(p->pack_name);
if (p->mwf.fd < 0) if (p->mwf.fd < 0) {
return p->mwf.fd; p->mwf.fd = -1;
return -1;
}
if (p_fstat(p->mwf.fd, &st) < 0 || if (p_fstat(p->mwf.fd, &st) < 0 ||
git_mwindow_file_register(&p->mwf) < 0) git_mwindow_file_register(&p->mwf) < 0)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment