Merge pull request #6651 from 7Ji/download_leak_fix

remote: fix memory leak in git_remote_download()

Merge pull request #6651 from 7Ji/download_leak_fix
remote: fix memory leak in git_remote_download()
d9475611 · Edward Thomson · GitHub · 95adbdeb · ffc12e66 · d9475611
Unverified Commit d9475611 authored Nov 20, 2023 by Edward Thomson Committed by GitHub Nov 20, 2023
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletions

src/libgit2/remote.c
+5 -1

No files found.
--- a/src/libgit2/remote.c
+++ b/src/libgit2/remote.c
@@ -1339,7 +1339,11 @@ int git_remote_download(
 	if ((error = connect_or_reset_options(remote, GIT_DIRECTION_FETCH, &connect_opts)) < 0)
 		return error;

-	return git_remote__download(remote, refspecs, opts);
+	error = git_remote__download(remote, refspecs, opts);
+
+	git_remote_connect_options_dispose(&connect_opts);
+
+	return error;
 }

 int git_remote_fetch(