Commit b31283a6 by Carlos Martín Nieto

refdb: disable concurrent compress in the threading tests on Windows

This is far from an ideal situation, but this causes issues on Windows which
make it harder to develop anything, as these tests hit issues which relate
specifically to the Windows filesystem like permission errors for files we
should be able to access. There is an issue likely related to the ordering of
the repack, but there's enough noise that it does not currently help us to run
this aspect of the test in CI.
parent 8339c660
...@@ -5,6 +5,12 @@ ...@@ -5,6 +5,12 @@
static git_repository *g_repo; static git_repository *g_repo;
static int g_expected = 0; static int g_expected = 0;
#ifdef GIT_WIN32
static bool concurrent_compress = false;
#else
static bool concurrent_compress = true;
#endif
void test_threads_refdb__initialize(void) void test_threads_refdb__initialize(void)
{ {
g_repo = NULL; g_repo = NULL;
...@@ -79,7 +85,7 @@ static void *create_refs(void *arg) ...@@ -79,7 +85,7 @@ static void *create_refs(void *arg)
} while (error == GIT_ELOCKED); } while (error == GIT_ELOCKED);
cl_git_thread_pass(data, error); cl_git_thread_pass(data, error);
if (i == NREFS/2) { if (concurrent_compress && i == NREFS/2) {
git_refdb *refdb; git_refdb *refdb;
cl_git_thread_pass(data, git_repository_refdb(&refdb, repo)); cl_git_thread_pass(data, git_repository_refdb(&refdb, repo));
do { do {
...@@ -125,7 +131,7 @@ static void *delete_refs(void *arg) ...@@ -125,7 +131,7 @@ static void *delete_refs(void *arg)
git_reference_free(ref); git_reference_free(ref);
} }
if (i == NREFS/2) { if (concurrent_compress && i == NREFS/2) {
git_refdb *refdb; git_refdb *refdb;
cl_git_thread_pass(data, git_repository_refdb(&refdb, repo)); cl_git_thread_pass(data, git_repository_refdb(&refdb, repo));
do { do {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment