Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
git2
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
lvzhengyang
git2
Commits
9db56cc4
Commit
9db56cc4
authored
Nov 12, 2013
by
Ben Straub
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix buffer blame with new lines at end of file
parent
089297b2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
11 deletions
+9
-11
src/blame.c
+6
-9
tests-clar/blame/buffer.c
+3
-2
No files found.
src/blame.c
View file @
9db56cc4
...
@@ -386,9 +386,13 @@ static int buffer_hunk_cb(
...
@@ -386,9 +386,13 @@ static int buffer_hunk_cb(
wedge_line
=
(
hunk
->
old_lines
==
0
)
?
hunk
->
new_start
:
hunk
->
old_start
;
wedge_line
=
(
hunk
->
old_lines
==
0
)
?
hunk
->
new_start
:
hunk
->
old_start
;
blame
->
current_diff_line
=
wedge_line
;
blame
->
current_diff_line
=
wedge_line
;
/* If this hunk doesn't start between existing hunks, split a hunk up so it does */
blame
->
current_hunk
=
(
git_blame_hunk
*
)
git_blame_get_hunk_byline
(
blame
,
wedge_line
);
blame
->
current_hunk
=
(
git_blame_hunk
*
)
git_blame_get_hunk_byline
(
blame
,
wedge_line
);
if
(
!
hunk_starts_at_or_after_line
(
blame
->
current_hunk
,
wedge_line
)){
if
(
!
blame
->
current_hunk
)
{
/* Line added at the end of the file */
blame
->
current_hunk
=
new_hunk
(
wedge_line
,
0
,
wedge_line
,
blame
->
path
);
git_vector_insert
(
&
blame
->
hunks
,
blame
->
current_hunk
);
}
else
if
(
!
hunk_starts_at_or_after_line
(
blame
->
current_hunk
,
wedge_line
)){
/* If this hunk doesn't start between existing hunks, split a hunk up so it does */
blame
->
current_hunk
=
split_hunk_in_vector
(
&
blame
->
hunks
,
blame
->
current_hunk
,
blame
->
current_hunk
=
split_hunk_in_vector
(
&
blame
->
hunks
,
blame
->
current_hunk
,
wedge_line
-
blame
->
current_hunk
->
orig_start_line_number
,
true
);
wedge_line
-
blame
->
current_hunk
->
orig_start_line_number
,
true
);
}
}
...
@@ -409,13 +413,6 @@ static int buffer_line_cb(
...
@@ -409,13 +413,6 @@ static int buffer_line_cb(
GIT_UNUSED
(
hunk
);
GIT_UNUSED
(
hunk
);
GIT_UNUSED
(
line
);
GIT_UNUSED
(
line
);
#ifdef DO_DEBUG
{
char
*
str
=
git__substrdup
(
content
,
content_len
);
git__free
(
str
);
}
#endif
if
(
line
->
origin
==
GIT_DIFF_LINE_ADDITION
)
{
if
(
line
->
origin
==
GIT_DIFF_LINE_ADDITION
)
{
if
(
hunk_is_bufferblame
(
blame
->
current_hunk
)
&&
if
(
hunk_is_bufferblame
(
blame
->
current_hunk
)
&&
hunk_ends_at_or_before_line
(
blame
->
current_hunk
,
blame
->
current_diff_line
))
{
hunk_ends_at_or_before_line
(
blame
->
current_hunk
,
blame
->
current_diff_line
))
{
...
...
tests-clar/blame/buffer.c
View file @
9db56cc4
...
@@ -152,8 +152,9 @@ CCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCC
...
@@ -152,8 +152,9 @@ CCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCC
CCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCC
\n
\
CCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCC
\n
\
CCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCC
\n
\
CCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCC
\n
\
CCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCC
\n
\
CCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCC
\n
\
\n
\
abc
\n
\
abc
\n
\
\n
"
;
def
\n
"
;
cl_git_pass
(
git_blame_buffer
(
&
g_bufferblame
,
g_fileblame
,
buffer
,
strlen
(
buffer
)));
cl_git_pass
(
git_blame_buffer
(
&
g_bufferblame
,
g_fileblame
,
buffer
,
strlen
(
buffer
)));
cl_assert_equal_i
(
5
,
git_blame_get_hunk_count
(
g_bufferblame
));
cl_assert_equal_i
(
5
,
git_blame_get_hunk_count
(
g_bufferblame
));
...
@@ -161,6 +162,6 @@ abc\n\
...
@@ -161,6 +162,6 @@ abc\n\
check_blame_hunk_index
(
g_repo
,
g_bufferblame
,
1
,
5
,
1
,
1
,
"b99f7ac0"
,
"b.txt"
);
check_blame_hunk_index
(
g_repo
,
g_bufferblame
,
1
,
5
,
1
,
1
,
"b99f7ac0"
,
"b.txt"
);
check_blame_hunk_index
(
g_repo
,
g_bufferblame
,
2
,
6
,
5
,
0
,
"63d671eb"
,
"b.txt"
);
check_blame_hunk_index
(
g_repo
,
g_bufferblame
,
2
,
6
,
5
,
0
,
"63d671eb"
,
"b.txt"
);
check_blame_hunk_index
(
g_repo
,
g_bufferblame
,
3
,
11
,
5
,
0
,
"aa06ecca"
,
"b.txt"
);
check_blame_hunk_index
(
g_repo
,
g_bufferblame
,
3
,
11
,
5
,
0
,
"aa06ecca"
,
"b.txt"
);
check_blame_hunk_index
(
g_repo
,
g_bufferblame
,
4
,
16
,
1
,
0
,
"00000000"
,
"b.txt"
);
check_blame_hunk_index
(
g_repo
,
g_bufferblame
,
4
,
16
,
2
,
0
,
"00000000"
,
"b.txt"
);
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment