Skip to content

G
git2
Commit 8c36a3cd by Ben Straub
Options

Remove double-free segfaults

parent 016179d6
Showing with 6 additions and 6 deletions
src/transports/git.c
...@@ -179,7 +179,7 @@ static int _git_uploadpack_ls( ...@@ -179,7 +179,7 @@ static int _git_uploadpack_ls(
const char *url, const char *url,
git_smart_subtransport_stream **stream) git_smart_subtransport_stream **stream)
{ {
char *host, *port, *user, *pass; char *host, *port, *user=NULL, *pass=NULL;
git_stream *s; git_stream *s;
*stream = NULL; *stream = NULL;
...@@ -201,8 +201,8 @@ static int _git_uploadpack_ls( ...@@ -201,8 +201,8 @@ static int _git_uploadpack_ls(
t->current_stream = s; t->current_stream = s;
git__free(host); git__free(host);
git__free(port); git__free(port);
git__free(user); if (user) git__free(user);
git__free(pass); if (pass) git__free(pass);
return 0; return 0;
on_error: on_error:
...@@ -235,7 +235,7 @@ static int _git_receivepack_ls( ...@@ -235,7 +235,7 @@ static int _git_receivepack_ls(
const char *url, const char *url,
git_smart_subtransport_stream **stream) git_smart_subtransport_stream **stream)
{ {
char *host, *port, *user, *pass; char *host, *port, *user=NULL, *pass=NULL;
git_stream *s; git_stream *s;
*stream = NULL; *stream = NULL;
...@@ -257,8 +257,8 @@ static int _git_receivepack_ls( ...@@ -257,8 +257,8 @@ static int _git_receivepack_ls(
t->current_stream = s; t->current_stream = s;
git__free(host); git__free(host);
git__free(port); git__free(port);
git__free(user); if (user) git__free(user);
git__free(pass); if (pass) git__free(pass);
return 0; return 0;
on_error: on_error:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment