Commit 8a4d77f9 by Carlos Martín Nieto

path: don't let direach overwrite the callback's error message

This function deals with functions doing IO which means the amount of
errors that can happen is quit large. It does not help if it always
ovewrites the underlying error message with a less understandable
version of "something went wrong".

Instead, only use this generic message if there was no error set by the
callback.
parent 9042693e
......@@ -1060,11 +1060,13 @@ int git_path_direach(
if ((error = git_buf_put(path, de_path, de_len)) < 0)
break;
giterr_clear();
error = fn(arg, path);
git_buf_truncate(path, wd_len); /* restore path */
if (error != 0) {
/* Only set our own error if the callback did not set one already */
if (error != 0 && !giterr_last()) {
giterr_set_after_callback(error);
break;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment