Merge pull request #6599 from steven9724/fix-ssh-memleak

ssh: fix known_hosts leak in _git_ssh_setup_conn

Merge pull request #6599 from steven9724/fix-ssh-memleak
ssh: fix known_hosts leak in _git_ssh_setup_conn
782c4d4d · Edward Thomson · GitHub · 593ff41b · 1a146417 · 782c4d4d
Unverified Commit 782c4d4d authored Jul 30, 2023 by Edward Thomson Committed by GitHub Jul 30, 2023
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

src/libgit2/transports/ssh.c
+3 -2

No files found.
--- a/src/libgit2/transports/ssh.c
+++ b/src/libgit2/transports/ssh.c
@@ -877,11 +877,12 @@ static int _git_ssh_setup_conn(
 	t->current_stream = s;

 done:
+	if (known_hosts)
+		libssh2_knownhost_free(known_hosts);
+
 	if (error < 0) {
 		ssh_stream_free(*stream);

-		if (known_hosts)
-			libssh2_knownhost_free(known_hosts);
 		if (session)
 			libssh2_session_free(session);
 	}