Commit 71424f63 by Drew DeVault Committed by Patrick Steinhardt

patch_parse.c: Handle CRLF in parse_header_start

parent 4ec209cd
...@@ -328,7 +328,8 @@ static int parse_header_start(git_patch_parsed *patch, git_patch_parse_ctx *ctx) ...@@ -328,7 +328,8 @@ static int parse_header_start(git_patch_parsed *patch, git_patch_parse_ctx *ctx)
* proceeed here. We then hope for the "---" and "+++" lines to fix that * proceeed here. We then hope for the "---" and "+++" lines to fix that
* for us. * for us.
*/ */
if (!git_parse_ctx_contains(&ctx->parse_ctx, "\n", 1)) { if (!git_parse_ctx_contains(&ctx->parse_ctx, "\n", 1) &&
!git_parse_ctx_contains(&ctx->parse_ctx, "\r\n", 2)) {
git_parse_advance_chars(&ctx->parse_ctx, ctx->parse_ctx.line_len - 1); git_parse_advance_chars(&ctx->parse_ctx, ctx->parse_ctx.line_len - 1);
git__free(patch->header_old_path); git__free(patch->header_old_path);
......
...@@ -360,6 +360,7 @@ void test_diff_parse__lineinfo(void) ...@@ -360,6 +360,7 @@ void test_diff_parse__lineinfo(void)
git_diff_free(diff); git_diff_free(diff);
} }
void test_diff_parse__new_file_with_space(void) void test_diff_parse__new_file_with_space(void)
{ {
const char *content = PATCH_ORIGINAL_NEW_FILE_WITH_SPACE; const char *content = PATCH_ORIGINAL_NEW_FILE_WITH_SPACE;
...@@ -377,3 +378,21 @@ void test_diff_parse__new_file_with_space(void) ...@@ -377,3 +378,21 @@ void test_diff_parse__new_file_with_space(void)
git_patch_free(patch); git_patch_free(patch);
git_diff_free(diff); git_diff_free(diff);
} }
void test_diff_parse__crlf(void)
{
const char *text = PATCH_CRLF;
git_diff *diff;
git_patch *patch;
const git_diff_delta *delta;
cl_git_pass(git_diff_from_buffer(&diff, text, strlen(text)));
cl_git_pass(git_patch_from_diff(&patch, diff, 0));
delta = git_patch_get_delta(patch);
cl_assert_equal_s(delta->old_file.path, "test-file");
cl_assert_equal_s(delta->new_file.path, "test-file");
git_patch_free(patch);
git_diff_free(diff);
}
...@@ -850,3 +850,12 @@ ...@@ -850,3 +850,12 @@
"+++ b/sp ace.txt\n" \ "+++ b/sp ace.txt\n" \
"@@ -0,0 +1 @@\n" \ "@@ -0,0 +1 @@\n" \
"+a\n" "+a\n"
#define PATCH_CRLF \
"diff --git a/test-file b/test-file\r\n" \
"new file mode 100644\r\n" \
"index 0000000..af431f2 100644\r\n" \
"--- /dev/null\r\n" \
"+++ b/test-file\r\n" \
"@@ -0,0 +1 @@\r\n" \
"+a contents\r\n"
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment