Merge pull request #4328 from libgit2/peff/hashcmp-is-memcmp

oid: use memcmp in git_oid__hashcmp

Merge pull request #4328 from libgit2/peff/hashcmp-is-memcmp
oid: use memcmp in git_oid__hashcmp
577aeef7 · Edward Thomson · GitHub · f908b184 · c9b1e646 · 577aeef7
Commit 577aeef7 authored Aug 14, 2017 by Edward Thomson Committed by GitHub Aug 14, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 1 additions and 8 deletions

src/oid.h
+1 -8

No files found.
--- a/src/oid.h
+++ b/src/oid.h
@@ -22,14 +22,7 @@ char *git_oid_allocfmt(const git_oid *id);

 GIT_INLINE(int) git_oid__hashcmp(const unsigned char *sha1, const unsigned char *sha2)
 {
-	int i;
-
-	for (i = 0; i < GIT_OID_RAWSZ; i++, sha1++, sha2++) {
-		if (*sha1 != *sha2)
-			return *sha1 - *sha2;
-	}
-
-	return 0;
+	return memcmp(sha1, sha2, GIT_OID_RAWSZ);
 }

 /*