Merge pull request #6544 from libgit2/ethomson/repo_env

repo: honor environment variables for more scenarios

src/libgit2/repository.h

@@ -151,8 +151,9 @@ struct git_repository {
 
 	git_array_t(git_str) reserved_names;
 
-	unsigned is_bare:1;
-	unsigned is_worktree:1;
+	unsigned use_env:1,
+	         is_bare:1,
+	         is_worktree:1;
 	git_oid_t oid_type;
 
 	unsigned int lru_counter;

tests/libgit2/repo/discover.c

@@ -122,7 +122,10 @@ void test_repo_discover__cleanup(void)
 void test_repo_discover__discovering_repo_with_exact_path_succeeds(void)
 {
 	cl_git_pass(git_repository_discover(&discovered, DISCOVER_FOLDER, 0, ceiling_dirs.ptr));
+	git_buf_dispose(&discovered);
+
 	cl_git_pass(git_repository_discover(&discovered, SUB_REPOSITORY_FOLDER, 0, ceiling_dirs.ptr));
+	git_buf_dispose(&discovered);
 }
 
 void test_repo_discover__discovering_nonexistent_dir_fails(void)

tests/libgit2/repo/env.c

@@ -31,6 +31,10 @@ void test_repo_env__cleanup(void)
 	if (git_fs_path_isdir("peeled.git"))
 		git_futils_rmdir_r("peeled.git", NULL, GIT_RMDIR_REMOVE_FILES);
 
+	cl_fixture_cleanup("test_workdir");
+	cl_fixture_cleanup("test_global_conf");
+	cl_fixture_cleanup("test_system_conf");
+
 	clear_git_env();
 }
 
@@ -275,3 +279,91 @@ void test_repo_env__open(void)
 
 	clear_git_env();
 }
+
+void test_repo_env__work_tree(void)
+{
+	git_repository *repo;
+	const char *test_path;
+
+	cl_fixture_sandbox("attr");
+	cl_git_pass(p_rename("attr/.gitted", "attr/.git"));
+
+	cl_must_pass(p_mkdir("test_workdir", 0777));
+	test_path = cl_git_sandbox_path(1, "test_workdir", NULL);
+
+	cl_setenv("GIT_WORK_TREE", test_path);
+	cl_git_pass(git_repository_open_ext(&repo, "attr", GIT_REPOSITORY_OPEN_FROM_ENV, NULL));
+	cl_assert_equal_s(test_path, git_repository_workdir(repo));
+	git_repository_free(repo);
+	cl_setenv("GIT_WORK_TREE", NULL);
+}
+
+void test_repo_env__commondir(void)
+{
+	git_repository *repo;
+	const char *test_path;
+
+	cl_fixture_sandbox("attr");
+	cl_git_pass(p_rename("attr/.gitted", "attr/.git"));
+
+	cl_fixture_sandbox("testrepo.git");
+	cl_git_pass(p_rename("testrepo.git", "test_commondir"));
+
+	test_path = cl_git_sandbox_path(1, "test_commondir", NULL);
+
+	cl_setenv("GIT_COMMON_DIR", test_path);
+	cl_git_pass(git_repository_open_ext(&repo, "attr", GIT_REPOSITORY_OPEN_FROM_ENV, NULL));
+	cl_assert_equal_s(test_path, git_repository_commondir(repo));
+	git_repository_free(repo);
+	cl_setenv("GIT_COMMON_DIR", NULL);
+}
+
+void test_repo_env__config(void)
+{
+	git_repository *repo;
+	git_config *config;
+	const char *system_path, *global_path;
+	int s, g;
+
+	cl_fixture_sandbox("attr");
+	cl_git_pass(p_rename("attr/.gitted", "attr/.git"));
+
+	cl_git_rewritefile("test_system_conf", "[tttest]\n\tsys = true\n");
+	cl_git_rewritefile("test_global_conf", "[tttest]\n\tglb = true\n");
+
+	system_path = cl_git_sandbox_path(0, "test_system_conf", NULL);
+	cl_setenv("GIT_CONFIG_SYSTEM", system_path);
+
+	global_path = cl_git_sandbox_path(0, "test_global_conf", NULL);
+	cl_setenv("GIT_CONFIG_GLOBAL", global_path);
+
+	/* Ensure we can override the system and global files */
+
+	cl_git_pass(git_repository_open_ext(&repo, "attr", GIT_REPOSITORY_OPEN_FROM_ENV, NULL));
+	cl_git_pass(git_repository_config(&config, repo));
+
+	cl_git_pass(git_config_get_bool(&s, config, "tttest.sys"));
+	cl_assert_equal_i(1, s);
+	cl_git_pass(git_config_get_bool(&g, config, "tttest.glb"));
+	cl_assert_equal_i(1, g);
+
+	git_config_free(config);
+	git_repository_free(repo);
+
+	/* Further ensure we can ignore the system file. */
+	cl_setenv("GIT_CONFIG_NOSYSTEM", "TrUe");
+
+	cl_git_pass(git_repository_open_ext(&repo, "attr", GIT_REPOSITORY_OPEN_FROM_ENV, NULL));
+	cl_git_pass(git_repository_config(&config, repo));
+
+	cl_git_fail_with(GIT_ENOTFOUND, git_config_get_bool(&s, config, "tttest.sys"));
+	cl_git_pass(git_config_get_bool(&g, config, "tttest.glb"));
+	cl_assert_equal_i(1, g);
+
+	git_config_free(config);
+	git_repository_free(repo);
+
+	cl_setenv("GIT_CONFIG_NOSYSTEM", NULL);
+	cl_setenv("GIT_CONFIG_SYSTEM", NULL);
+	cl_setenv("GIT_CONFIG_GLOBAL", NULL);
+}