Commit 1ba48b7c by Vicent Marti

notes: Do not assume blob contents are NULL-terminated

parent 72d00241
...@@ -313,6 +313,7 @@ static int note_new( ...@@ -313,6 +313,7 @@ static int note_new(
git_blob *blob) git_blob *blob)
{ {
git_note *note = NULL; git_note *note = NULL;
git_buf note_contents = GIT_BUF_INIT;
note = (git_note *)git__malloc(sizeof(git_note)); note = (git_note *)git__malloc(sizeof(git_note));
GITERR_CHECK_ALLOC(note); GITERR_CHECK_ALLOC(note);
...@@ -323,11 +324,10 @@ static int note_new( ...@@ -323,11 +324,10 @@ static int note_new(
git_signature_dup(&note->committer, git_commit_committer(commit)) < 0) git_signature_dup(&note->committer, git_commit_committer(commit)) < 0)
return -1; return -1;
note->message = git__strdup((char *)git_blob_rawcontent(blob)); git_buf_put(&note_contents, git_blob_rawcontent(blob), git_blob_rawsize(blob));
GITERR_CHECK_ALLOC(note->message); note->message = git_buf_detach(&note_contents);
*out = note; *out = note;
return 0; return 0;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment