666a779eed16847c6930a71c0547a34e52db409e
62 Bytes
-
[midx] Fix an undefined behavior (left-shift signed overflow) · 33b1d3fd
There was a missing check to ensure that the `off64_t` (which is a signed value) didn't overflow when parsing it from the midx file. This shouldn't have huge repercusions since the parsed value is immediately validated afterwards, but then again, there is no such thing as "benign" undefined behavior. This change makes all the bitwise arithmetic happen with unsigned types and is only casted to `off64_t` until the very end. Thanks to Taotao Gu for finding and reporting this!
lhchavez committed