racy.c 9.06 KB
Newer Older
1
#include "clar_libgit2.h"
2
#include "../checkout/checkout_helpers.h"
3 4

#include "buffer.h"
5
#include "index.h"
6
#include "repository.h"
7 8 9

static git_repository *g_repo;

10
void test_index_racy__initialize(void)
11 12 13 14
{
	cl_git_pass(git_repository_init(&g_repo, "diff_racy", false));
}

15
void test_index_racy__cleanup(void)
16
{
17 18 19 20
	git_repository_free(g_repo);
	g_repo = NULL;

	cl_fixture_cleanup("diff_racy");
21 22
}

23
void test_index_racy__diff(void)
24 25 26 27 28 29 30 31 32 33 34 35 36 37 38
{
	git_index *index;
	git_diff *diff;
	git_buf path = GIT_BUF_INIT;

	cl_git_pass(git_buf_joinpath(&path, git_repository_workdir(g_repo), "A"));
	cl_git_mkfile(path.ptr, "A");

	/* Put 'A' into the index */
	cl_git_pass(git_repository_index(&index, g_repo));
	cl_git_pass(git_index_add_bypath(index, "A"));
	cl_git_pass(git_index_write(index));

	cl_git_pass(git_diff_index_to_workdir(&diff, g_repo, index, NULL));
	cl_assert_equal_i(0, git_diff_num_deltas(diff));
39
	git_diff_free(diff);
40 41 42 43 44 45

	/* Change its contents quickly, so we get the same timestamp */
	cl_git_mkfile(path.ptr, "B");

	cl_git_pass(git_diff_index_to_workdir(&diff, g_repo, index, NULL));
	cl_assert_equal_i(1, git_diff_num_deltas(diff));
46 47 48

	git_index_free(index);
	git_diff_free(diff);
49
	git_buf_dispose(&path);
50
}
51

52
void test_index_racy__write_index_just_after_file(void)
53 54 55 56
{
	git_index *index;
	git_diff *diff;
	git_buf path = GIT_BUF_INIT;
57
	struct p_timeval times[2];
58 59 60 61 62 63 64

	/* Make sure we do have a timestamp */
	cl_git_pass(git_repository_index(&index, g_repo));
	cl_git_pass(git_index_write(index));

	cl_git_pass(git_buf_joinpath(&path, git_repository_workdir(g_repo), "A"));
	cl_git_mkfile(path.ptr, "A");
65
	/* Force the file's timestamp to be a second after we wrote the index */
66 67 68 69
	times[0].tv_sec = index->stamp.mtime.tv_sec + 1;
	times[0].tv_usec = index->stamp.mtime.tv_nsec / 1000;
	times[1].tv_sec = index->stamp.mtime.tv_sec + 1;
	times[1].tv_usec = index->stamp.mtime.tv_nsec / 1000;
70
	cl_git_pass(p_utimes(path.ptr, times));
71 72 73 74

	/*
	 * Put 'A' into the index, the size field will be filled,
	 * because the index' on-disk timestamp does not match the
75
	 * file's timestamp.
76 77 78 79 80
	 */
	cl_git_pass(git_index_add_bypath(index, "A"));
	cl_git_pass(git_index_write(index));

	cl_git_mkfile(path.ptr, "B");
81
	/*
Dmitriy Olshevskiy committed
82
	 * Pretend this index' modification happened a second after the
83 84
	 * file update, and rewrite the file in that same second.
	 */
85 86 87 88
	times[0].tv_sec = index->stamp.mtime.tv_sec + 2;
	times[0].tv_usec = index->stamp.mtime.tv_nsec / 1000;
	times[1].tv_sec = index->stamp.mtime.tv_sec + 2;
	times[0].tv_usec = index->stamp.mtime.tv_nsec / 1000;
89 90 91 92 93

	cl_git_pass(p_utimes(git_index_path(index), times));
	cl_git_pass(p_utimes(path.ptr, times));

	cl_git_pass(git_index_read(index, true));
94 95 96

	cl_git_pass(git_diff_index_to_workdir(&diff, g_repo, index, NULL));
	cl_assert_equal_i(1, git_diff_num_deltas(diff));
97

98
	git_buf_dispose(&path);
99 100
	git_diff_free(diff);
	git_index_free(index);
101
}
102

103 104

static void setup_race(void)
105 106
{
	git_buf path = GIT_BUF_INIT;
107
	git_index *index;
108 109
	git_index_entry *entry;
	struct stat st;
110 111

	/* Make sure we do have a timestamp */
112
	cl_git_pass(git_repository_index__weakptr(&index, g_repo));
113 114 115 116
	cl_git_pass(git_index_write(index));

	cl_git_pass(git_buf_joinpath(&path, git_repository_workdir(g_repo), "A"));

117 118
	cl_git_mkfile(path.ptr, "A");
	cl_git_pass(git_index_add_bypath(index, "A"));
119

120 121
	cl_git_mkfile(path.ptr, "B");
	cl_git_pass(git_index_write(index));
122

123
	cl_git_mkfile(path.ptr, "");
124

125 126
	cl_git_pass(p_stat(path.ptr, &st));
	cl_assert(entry = (git_index_entry *)git_index_get_bypath(index, "A", 0));
127

128
	/* force a race */
129 130
	entry->mtime.seconds = (int32_t)st.st_mtime;
	entry->mtime.nanoseconds = (int32_t)st.st_mtime_nsec;
131

132
	git_buf_dispose(&path);
133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151
}

void test_index_racy__smudges_index_entry_on_save(void)
{
	git_index *index;
	const git_index_entry *entry;

	setup_race();

	/* write the index, which will smudge anything that had the same timestamp
	 * as the index when the index was loaded.  that way future loads of the
	 * index (with the new timestamp) will know that these files were not
	 * clean.
	 */

	cl_git_pass(git_repository_index__weakptr(&index, g_repo));
	cl_git_pass(git_index_write(index));

	cl_assert(entry = git_index_get_bypath(index, "A", 0));
152
	cl_assert_equal_i(0, entry->file_size);
153 154 155 156 157 158 159 160 161 162
}

void test_index_racy__detects_diff_of_change_in_identical_timestamp(void)
{
	git_index *index;
	git_diff *diff;

	cl_git_pass(git_repository_index__weakptr(&index, g_repo));

	setup_race();
163 164 165

	cl_git_pass(git_diff_index_to_workdir(&diff, g_repo, index, NULL));
	cl_assert_equal_i(1, git_diff_num_deltas(diff));
166 167

	git_diff_free(diff);
168
}
169 170 171 172 173

static void setup_uptodate_files(void)
{
	git_buf path = GIT_BUF_INIT;
	git_index *index;
174
	const git_index_entry *a_entry;
175
	git_index_entry new_entry = {{0}};
176 177 178 179 180 181 182 183 184

	cl_git_pass(git_repository_index(&index, g_repo));

	cl_git_pass(git_buf_joinpath(&path, git_repository_workdir(g_repo), "A"));
	cl_git_mkfile(path.ptr, "A");

	/* Put 'A' into the index */
	cl_git_pass(git_index_add_bypath(index, "A"));

185 186
	cl_assert((a_entry = git_index_get_bypath(index, "A", 0)));

187 188 189
	/* Put 'B' into the index */
	new_entry.path = "B";
	new_entry.mode = GIT_FILEMODE_BLOB;
190
	git_oid_cpy(&new_entry.id, &a_entry->id);
191 192 193 194 195
	cl_git_pass(git_index_add(index, &new_entry));

	/* Put 'C' into the index */
	new_entry.path = "C";
	new_entry.mode = GIT_FILEMODE_BLOB;
196
	cl_git_pass(git_index_add_from_buffer(index, &new_entry, "hello!\n", 7));
197 198

	git_index_free(index);
199
	git_buf_dispose(&path);
200 201 202 203 204 205 206 207 208 209 210 211 212
}

void test_index_racy__adding_to_index_is_uptodate(void)
{
	git_index *index;
	const git_index_entry *entry;

	setup_uptodate_files();

	cl_git_pass(git_repository_index(&index, g_repo));

	/* ensure that they're all uptodate */
	cl_assert((entry = git_index_get_bypath(index, "A", 0)));
213
	cl_assert_equal_i(GIT_INDEX_ENTRY_UPTODATE, (entry->flags_extended & GIT_INDEX_ENTRY_UPTODATE));
214 215

	cl_assert((entry = git_index_get_bypath(index, "B", 0)));
216
	cl_assert_equal_i(GIT_INDEX_ENTRY_UPTODATE, (entry->flags_extended & GIT_INDEX_ENTRY_UPTODATE));
217 218

	cl_assert((entry = git_index_get_bypath(index, "C", 0)));
219
	cl_assert_equal_i(GIT_INDEX_ENTRY_UPTODATE, (entry->flags_extended & GIT_INDEX_ENTRY_UPTODATE));
220 221 222 223 224 225 226 227 228 229 230 231

	cl_git_pass(git_index_write(index));

	git_index_free(index);
}

void test_index_racy__reading_clears_uptodate_bit(void)
{
	git_index *index;
	const git_index_entry *entry;

	setup_uptodate_files();
232

233 234 235 236 237 238 239
	cl_git_pass(git_repository_index(&index, g_repo));
	cl_git_pass(git_index_write(index));

	cl_git_pass(git_index_read(index, true));

	/* ensure that no files are uptodate */
	cl_assert((entry = git_index_get_bypath(index, "A", 0)));
240
	cl_assert_equal_i(0, (entry->flags_extended & GIT_INDEX_ENTRY_UPTODATE));
241 242

	cl_assert((entry = git_index_get_bypath(index, "B", 0)));
243
	cl_assert_equal_i(0, (entry->flags_extended & GIT_INDEX_ENTRY_UPTODATE));
244 245

	cl_assert((entry = git_index_get_bypath(index, "C", 0)));
246
	cl_assert_equal_i(0, (entry->flags_extended & GIT_INDEX_ENTRY_UPTODATE));
247 248 249

	git_index_free(index);
}
250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266

void test_index_racy__read_tree_clears_uptodate_bit(void)
{
	git_index *index;
	git_tree *tree;
	const git_index_entry *entry;
	git_oid id;

	setup_uptodate_files();

	cl_git_pass(git_repository_index(&index, g_repo));
	cl_git_pass(git_index_write_tree_to(&id, index, g_repo));
	cl_git_pass(git_tree_lookup(&tree, g_repo, &id));
	cl_git_pass(git_index_read_tree(index, tree));

	/* ensure that no files are uptodate */
	cl_assert((entry = git_index_get_bypath(index, "A", 0)));
267
	cl_assert_equal_i(0, (entry->flags_extended & GIT_INDEX_ENTRY_UPTODATE));
268 269

	cl_assert((entry = git_index_get_bypath(index, "B", 0)));
270
	cl_assert_equal_i(0, (entry->flags_extended & GIT_INDEX_ENTRY_UPTODATE));
271 272

	cl_assert((entry = git_index_get_bypath(index, "C", 0)));
273
	cl_assert_equal_i(0, (entry->flags_extended & GIT_INDEX_ENTRY_UPTODATE));
274 275 276 277

	git_tree_free(tree);
	git_index_free(index);
}
278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313

void test_index_racy__read_index_smudges(void)
{
	git_index *index, *newindex;
	const git_index_entry *entry;

	/* if we are reading an index into our new index, ensure that any
	 * racy entries in the index that we're reading are smudged so that
	 * we don't propagate their timestamps without further investigation.
	 */
	setup_race();

	cl_git_pass(git_repository_index(&index, g_repo));
	cl_git_pass(git_index_new(&newindex));
	cl_git_pass(git_index_read_index(newindex, index));

	cl_assert(entry = git_index_get_bypath(newindex, "A", 0));
	cl_assert_equal_i(0, entry->file_size);

	git_index_free(index);
	git_index_free(newindex);
}

void test_index_racy__read_index_clears_uptodate_bit(void)
{
	git_index *index, *newindex;
	const git_index_entry *entry;

	setup_uptodate_files();

	cl_git_pass(git_repository_index(&index, g_repo));
	cl_git_pass(git_index_new(&newindex));
	cl_git_pass(git_index_read_index(newindex, index));

	/* ensure that files brought in from the other index are not uptodate */
	cl_assert((entry = git_index_get_bypath(newindex, "A", 0)));
314
	cl_assert_equal_i(0, (entry->flags_extended & GIT_INDEX_ENTRY_UPTODATE));
315 316

	cl_assert((entry = git_index_get_bypath(newindex, "B", 0)));
317
	cl_assert_equal_i(0, (entry->flags_extended & GIT_INDEX_ENTRY_UPTODATE));
318 319

	cl_assert((entry = git_index_get_bypath(newindex, "C", 0)));
320
	cl_assert_equal_i(0, (entry->flags_extended & GIT_INDEX_ENTRY_UPTODATE));
321 322 323 324

	git_index_free(index);
	git_index_free(newindex);
}