parse.c 13.3 KB
Newer Older
1 2 3 4 5
#include "clar_libgit2.h"
#include "commit.h"
#include "object.h"
#include "signature.h"

6 7 8 9
static void assert_commit_parses(
	const char *data,
	size_t datalen,
	git_oid_t oid_type,
10 11 12 13 14 15 16 17 18 19
	const char *expected_treeid,
	const char *expected_author,
	const char *expected_committer,
	const char *expected_encoding,
	const char *expected_message,
	size_t expected_parents)
{
	git_commit *commit;
	if (!datalen)
		datalen = strlen(data);
20
	cl_git_pass(git_object__from_raw((git_object **) &commit, data, datalen, GIT_OBJECT_COMMIT, oid_type));
21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56

	if (expected_author) {
		git_signature *author;
		cl_git_pass(git_signature_from_buffer(&author, expected_author));
		cl_assert(git_signature__equal(author, commit->author));
		cl_assert_equal_s(author->name, commit->author->name);
		cl_assert_equal_s(author->email, commit->author->email);
		cl_assert_equal_i(author->when.time, commit->author->when.time);
		cl_assert_equal_i(author->when.offset, commit->author->when.offset);
		cl_assert_equal_i(author->when.sign, commit->author->when.sign);
		git_signature_free(author);
	}

	if (expected_committer) {
		git_signature *committer;
		cl_git_pass(git_signature_from_buffer(&committer, expected_committer));
		cl_assert_equal_s(committer->name, commit->committer->name);
		cl_assert_equal_s(committer->email, commit->committer->email);
		cl_assert_equal_i(committer->when.time, commit->committer->when.time);
		cl_assert_equal_i(committer->when.offset, commit->committer->when.offset);
		cl_assert_equal_i(committer->when.sign, commit->committer->when.sign);
		git_signature_free(committer);
	}

	if (expected_encoding)
		cl_assert_equal_s(commit->message_encoding, expected_encoding);
	else
		cl_assert_equal_p(commit->message_encoding, NULL);

	if (expected_message)
		cl_assert_equal_s(commit->raw_message, expected_message);
	else
		cl_assert_equal_p(commit->message_encoding, NULL);

	if (expected_treeid) {
		git_oid tree_oid;
57
		cl_git_pass(git_oid__fromstr(&tree_oid, expected_treeid, oid_type));
58 59 60 61 62 63 64 65
		cl_assert_equal_oid(&tree_oid, &commit->tree_id);
	}

	cl_assert_equal_i(commit->parent_ids.size, expected_parents);

	git_object__free(&commit->object);
}

66 67 68 69
static void assert_commit_fails(
	const char *data,
	size_t datalen,
	git_oid_t oid_type)
70 71 72 73
{
	git_object *object;
	if (!datalen)
		datalen = strlen(data);
74
	cl_git_fail(git_object__from_raw(&object, data, datalen, GIT_OBJECT_COMMIT, oid_type));
75 76
}

77
void test_object_commit_parse__sha1_parsing_commit_succeeds(void)
78 79 80 81 82 83 84 85
{
	const char *commit =
		"tree 3e7ac388cadacccdf1c6c5f3445895b71d9cb0f8\n"
		"author Author <author@example.com>\n"
		"committer Committer <committer@example.com>\n"
		"encoding Encoding\n"
		"\n"
		"Message";
86
	assert_commit_parses(commit, 0, GIT_OID_SHA1,
87 88 89 90 91 92 93
		"3e7ac388cadacccdf1c6c5f3445895b71d9cb0f8",
		"Author <author@example.com>",
		"Committer <committer@example.com>",
		"Encoding",
		"Message", 0);
}

94
void test_object_commit_parse__sha1_parsing_commit_without_encoding_succeeds(void)
95 96 97 98 99 100 101
{
	const char *commit =
		"tree 3e7ac388cadacccdf1c6c5f3445895b71d9cb0f8\n"
		"author Author <author@example.com>\n"
		"committer Committer <committer@example.com>\n"
		"\n"
		"Message";
102
	assert_commit_parses(commit, 0, GIT_OID_SHA1,
103 104 105 106 107 108 109
		"3e7ac388cadacccdf1c6c5f3445895b71d9cb0f8",
		"Author <author@example.com>",
		"Committer <committer@example.com>",
		NULL,
		"Message", 0);
}

110
void test_object_commit_parse__sha1_parsing_commit_with_multiple_authors_succeeds(void)
111 112 113 114 115 116 117 118 119 120
{
	const char *commit =
		"tree 3e7ac388cadacccdf1c6c5f3445895b71d9cb0f8\n"
		"author Author1 <author@example.com>\n"
		"author Author2 <author@example.com>\n"
		"author Author3 <author@example.com>\n"
		"author Author4 <author@example.com>\n"
		"committer Committer <committer@example.com>\n"
		"\n"
		"Message";
121
	assert_commit_parses(commit, 0, GIT_OID_SHA1,
122 123 124 125 126 127 128
		"3e7ac388cadacccdf1c6c5f3445895b71d9cb0f8",
		"Author1 <author@example.com>",
		"Committer <committer@example.com>",
		NULL,
		"Message", 0);
}

129
void test_object_commit_parse__sha1_parsing_commit_with_multiple_committers_succeeds(void)
130 131 132 133 134 135 136 137 138 139
{
	const char *commit =
		"tree 3e7ac388cadacccdf1c6c5f3445895b71d9cb0f8\n"
		"author Author <author@example.com>\n"
		"committer Committer1 <committer@example.com>\n"
		"committer Committer2 <committer@example.com>\n"
		"committer Committer3 <committer@example.com>\n"
		"committer Committer4 <committer@example.com>\n"
		"\n"
		"Message";
140
	assert_commit_parses(commit, 0, GIT_OID_SHA1,
141 142 143 144 145 146 147
		"3e7ac388cadacccdf1c6c5f3445895b71d9cb0f8",
		"Author <author@example.com>",
		"Committer1 <committer@example.com>",
		NULL,
		"Message", 0);
}

148
void test_object_commit_parse__sha1_parsing_commit_without_message_succeeds(void)
149 150 151 152 153
{
	const char *commit =
		"tree 3e7ac388cadacccdf1c6c5f3445895b71d9cb0f8\n"
		"author Author <author@example.com>\n"
		"committer Committer <committer@example.com>\n";
154
	assert_commit_parses(commit, 0, GIT_OID_SHA1,
155 156 157 158 159 160 161
		"3e7ac388cadacccdf1c6c5f3445895b71d9cb0f8",
		"Author <author@example.com>",
		"Committer <committer@example.com>",
		NULL,
		"", 0);
}

162
void test_object_commit_parse__sha1_parsing_commit_with_unknown_fields_succeeds(void)
163 164 165 166 167 168 169 170 171
{
	const char *commit =
		"tree 3e7ac388cadacccdf1c6c5f3445895b71d9cb0f8\n"
		"author Author <author@example.com>\n"
		"committer Committer <committer@example.com>\n"
		"foo bar\n"
		"more garbage\n"
		"\n"
		"Message";
172
	assert_commit_parses(commit, 0, GIT_OID_SHA1,
173 174 175 176 177 178 179
		"3e7ac388cadacccdf1c6c5f3445895b71d9cb0f8",
		"Author <author@example.com>",
		"Committer <committer@example.com>",
		NULL,
		"Message", 0);
}

180
void test_object_commit_parse__sha1_parsing_commit_with_invalid_tree_fails(void)
181 182 183 184 185 186 187
{
	const char *commit =
		"tree 3e7ac388cadacccdf1xxx5f3445895b71d9cb0f8\n"
		"author Author <author@example.com>\n"
		"committer Committer <committer@example.com>\n"
		"\n"
		"Message";
188
	assert_commit_fails(commit, 0, GIT_OID_SHA1);
189 190
}

191
void test_object_commit_parse__sha1_parsing_commit_with_sha256_tree_fails(void)
192 193
{
	const char *commit =
194
		"tree f2a108f86a3b4fd9ad75ed55e9cb3cb46e348fca3b9dba3db64f7c9f64b8a736\n"
195 196 197 198
		"author Author <author@example.com>\n"
		"committer Committer <committer@example.com>\n"
		"\n"
		"Message";
199
	assert_commit_fails(commit, 0, GIT_OID_SHA1);
200 201
}

202 203 204 205 206 207 208 209 210 211 212
void test_object_commit_parse__sha1_parsing_commit_without_tree_fails(void)
{
	const char *commit =
		"author Author <author@example.com>\n"
		"committer Committer <committer@example.com>\n"
		"\n"
		"Message";
	assert_commit_fails(commit, 0, GIT_OID_SHA1);
}

void test_object_commit_parse__sha1_parsing_commit_without_author_fails(void)
213 214 215 216 217 218
{
	const char *commit =
		"tree 3e7ac388cadacccdf1c6c5f3445895b71d9cb0f8\n"
		"committer Committer <committer@example.com>\n"
		"\n"
		"Message";
219
	assert_commit_fails(commit, 0, GIT_OID_SHA1);
220 221
}

222
void test_object_commit_parse__sha1_parsing_commit_without_committer_fails(void)
223 224 225 226 227 228
{
	const char *commit =
		"tree 3e7ac388cadacccdf1c6c5f3445895b71d9cb0f8\n"
		"author Author <author@example.com>\n"
		"\n"
		"Message";
229
	assert_commit_fails(commit, 0, GIT_OID_SHA1);
230
}
231

232
void test_object_commit_parse__sha1_parsing_encoding_will_not_cause_oob_read(void)
233 234 235 236 237 238 239 240 241 242
{
	const char *commit =
		"tree 3e7ac388cadacccdf1c6c5f3445895b71d9cb0f8\n"
		"author <>\n"
		"committer <>\n"
		"encoding foo\n";
	/*
	 * As we ignore unknown fields, the cut-off encoding field will be
	 * parsed just fine.
	 */
243 244 245
	assert_commit_parses(
		commit, strlen(commit) - strlen("ncoding foo\n"),
		GIT_OID_SHA1,
246 247 248 249 250 251
		"3e7ac388cadacccdf1c6c5f3445895b71d9cb0f8",
		"<>",
		"<>",
		NULL,
		"", 0);
}
252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476


void test_object_commit_parse__sha256_parsing_commit_succeeds(void)
{
#ifndef GIT_EXPERIMENTAL_SHA256
	cl_skip();
#else
	const char *commit =
		"tree f2a108f86a3b4fd9ad75ed55e9cb3cb46e348fca3b9dba3db64f7c9f64b8a736\n"
		"author Author <author@example.com>\n"
		"committer Committer <committer@example.com>\n"
		"encoding Encoding\n"
		"\n"
		"Message";
	assert_commit_parses(commit, 0, GIT_OID_SHA256,
		"f2a108f86a3b4fd9ad75ed55e9cb3cb46e348fca3b9dba3db64f7c9f64b8a736",
		"Author <author@example.com>",
		"Committer <committer@example.com>",
		"Encoding",
		"Message", 0);
#endif
}

void test_object_commit_parse__sha256_parsing_commit_without_encoding_succeeds(void)
{
#ifndef GIT_EXPERIMENTAL_SHA256
	cl_skip();
#else
	const char *commit =
		"tree f2a108f86a3b4fd9ad75ed55e9cb3cb46e348fca3b9dba3db64f7c9f64b8a736\n"
		"author Author <author@example.com>\n"
		"committer Committer <committer@example.com>\n"
		"\n"
		"Message";
	assert_commit_parses(commit, 0, GIT_OID_SHA256,
		"f2a108f86a3b4fd9ad75ed55e9cb3cb46e348fca3b9dba3db64f7c9f64b8a736",
		"Author <author@example.com>",
		"Committer <committer@example.com>",
		NULL,
		"Message", 0);
#endif
}

void test_object_commit_parse__sha256_parsing_commit_with_multiple_authors_succeeds(void)
{
#ifndef GIT_EXPERIMENTAL_SHA256
	cl_skip();
#else
	const char *commit =
		"tree f2a108f86a3b4fd9ad75ed55e9cb3cb46e348fca3b9dba3db64f7c9f64b8a736\n"
		"author Author1 <author@example.com>\n"
		"author Author2 <author@example.com>\n"
		"author Author3 <author@example.com>\n"
		"author Author4 <author@example.com>\n"
		"committer Committer <committer@example.com>\n"
		"\n"
		"Message";
	assert_commit_parses(commit, 0, GIT_OID_SHA256,
		"f2a108f86a3b4fd9ad75ed55e9cb3cb46e348fca3b9dba3db64f7c9f64b8a736",
		"Author1 <author@example.com>",
		"Committer <committer@example.com>",
		NULL,
		"Message", 0);
#endif
}

void test_object_commit_parse__sha256_parsing_commit_with_multiple_committers_succeeds(void)
{
#ifndef GIT_EXPERIMENTAL_SHA256
	cl_skip();
#else
	const char *commit =
		"tree f2a108f86a3b4fd9ad75ed55e9cb3cb46e348fca3b9dba3db64f7c9f64b8a736\n"
		"author Author <author@example.com>\n"
		"committer Committer1 <committer@example.com>\n"
		"committer Committer2 <committer@example.com>\n"
		"committer Committer3 <committer@example.com>\n"
		"committer Committer4 <committer@example.com>\n"
		"\n"
		"Message";
	assert_commit_parses(commit, 0, GIT_OID_SHA256,
		"f2a108f86a3b4fd9ad75ed55e9cb3cb46e348fca3b9dba3db64f7c9f64b8a736",
		"Author <author@example.com>",
		"Committer1 <committer@example.com>",
		NULL,
		"Message", 0);
#endif
}

void test_object_commit_parse__sha256_parsing_commit_without_message_succeeds(void)
{
#ifndef GIT_EXPERIMENTAL_SHA256
	cl_skip();
#else
	const char *commit =
		"tree f2a108f86a3b4fd9ad75ed55e9cb3cb46e348fca3b9dba3db64f7c9f64b8a736\n"
		"author Author <author@example.com>\n"
		"committer Committer <committer@example.com>\n";
	assert_commit_parses(commit, 0, GIT_OID_SHA256,
		"f2a108f86a3b4fd9ad75ed55e9cb3cb46e348fca3b9dba3db64f7c9f64b8a736",
		"Author <author@example.com>",
		"Committer <committer@example.com>",
		NULL,
		"", 0);
#endif
}

void test_object_commit_parse__sha256_parsing_commit_with_unknown_fields_succeeds(void)
{
#ifndef GIT_EXPERIMENTAL_SHA256
	cl_skip();
#else
	const char *commit =
		"tree f2a108f86a3b4fd9ad75ed55e9cb3cb46e348fca3b9dba3db64f7c9f64b8a736\n"
		"author Author <author@example.com>\n"
		"committer Committer <committer@example.com>\n"
		"foo bar\n"
		"more garbage\n"
		"\n"
		"Message";
	assert_commit_parses(commit, 0, GIT_OID_SHA256,
		"f2a108f86a3b4fd9ad75ed55e9cb3cb46e348fca3b9dba3db64f7c9f64b8a736",
		"Author <author@example.com>",
		"Committer <committer@example.com>",
		NULL,
		"Message", 0);
#endif
}

void test_object_commit_parse__sha256_parsing_commit_with_invalid_tree_fails(void)
{
#ifndef GIT_EXPERIMENTAL_SHA256
	cl_skip();
#else
	const char *commit =
		"tree f2a108f86a3b4fd9adxxxd55e9cb3cb46e348fca3b9dba3db64f7c9f64b8a736\n"
		"author Author <author@example.com>\n"
		"committer Committer <committer@example.com>\n"
		"\n"
		"Message";
	assert_commit_fails(commit, 0, GIT_OID_SHA256);
#endif
}

void test_object_commit_parse__sha256_parsing_commit_with_sha1_tree_fails(void)
{
#ifndef GIT_EXPERIMENTAL_SHA256
	cl_skip();
#else
	const char *commit =
		"tree 3e7ac388cadacccdf1c6c5f3445895b71d9cb0f8\n"
		"author Author <author@example.com>\n"
		"committer Committer <committer@example.com>\n"
		"\n"
		"Message";
	assert_commit_fails(commit, 0, GIT_OID_SHA256);
#endif
}

void test_object_commit_parse__sha256_parsing_commit_without_tree_fails(void)
{
#ifndef GIT_EXPERIMENTAL_SHA256
	cl_skip();
#else
	const char *commit =
		"author Author <author@example.com>\n"
		"committer Committer <committer@example.com>\n"
		"\n"
		"Message";
	assert_commit_fails(commit, 0, GIT_OID_SHA256);
#endif
}

void test_object_commit_parse__sha256_parsing_commit_without_author_fails(void)
{
#ifndef GIT_EXPERIMENTAL_SHA256
	cl_skip();
#else
	const char *commit =
		"tree f2a108f86a3b4fd9ad75ed55e9cb3cb46e348fca3b9dba3db64f7c9f64b8a736\n"
		"committer Committer <committer@example.com>\n"
		"\n"
		"Message";
	assert_commit_fails(commit, 0, GIT_OID_SHA256);
#endif
}

void test_object_commit_parse__sha256_parsing_commit_without_committer_fails(void)
{
#ifndef GIT_EXPERIMENTAL_SHA256
	cl_skip();
#else
	const char *commit =
		"tree f2a108f86a3b4fd9ad75ed55e9cb3cb46e348fca3b9dba3db64f7c9f64b8a736\n"
		"author Author <author@example.com>\n"
		"\n"
		"Message";
	assert_commit_fails(commit, 0, GIT_OID_SHA256);
#endif
}

void test_object_commit_parse__sha256_parsing_encoding_will_not_cause_oob_read(void)
{
#ifndef GIT_EXPERIMENTAL_SHA256
	cl_skip();
#else
	const char *commit =
		"tree f2a108f86a3b4fd9ad75ed55e9cb3cb46e348fca3b9dba3db64f7c9f64b8a736\n"
		"author <>\n"
		"committer <>\n"
		"encoding foo\n";
	/*
	 * As we ignore unknown fields, the cut-off encoding field will be
	 * parsed just fine.
	 */
	assert_commit_parses(
		commit, strlen(commit) - strlen("ncoding foo\n"),
		GIT_OID_SHA256,
		"f2a108f86a3b4fd9ad75ed55e9cb3cb46e348fca3b9dba3db64f7c9f64b8a736",
		"<>",
		"<>",
		NULL,
		"", 0);
#endif
}