Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
V
verl
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
ZhangXiaoyun
verl
Commits
021db112
Unverified
Commit
021db112
authored
Feb 28, 2025
by
Shawn/Yuxuan Tong
Committed by
GitHub
Feb 28, 2025
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[Fix] No Shuffling for `val_dataloader` (#423)
Validation should not have shuffling.
parent
6e4a445f
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
2 deletions
+2
-2
verl/trainer/fsdp_sft_trainer.py
+1
-1
verl/trainer/ppo/ray_trainer.py
+1
-1
No files found.
verl/trainer/fsdp_sft_trainer.py
View file @
021db112
...
...
@@ -167,7 +167,7 @@ class FSDPSFTTrainer(object):
drop_last
=
True
)
self
.
val_sampler
=
DistributedSampler
(
self
.
val_dataset
,
shuffle
=
Tru
e
,
shuffle
=
Fals
e
,
num_replicas
=
world_size
,
rank
=
rank
,
drop_last
=
True
)
...
...
verl/trainer/ppo/ray_trainer.py
View file @
021db112
...
...
@@ -523,7 +523,7 @@ class RayPPOTrainer(object):
# Validation datasets are sent to inference engines as a whole batch,
# which will schedule the memory themselves.
batch_size
=
len
(
self
.
val_dataset
),
shuffle
=
Tru
e
,
shuffle
=
Fals
e
,
drop_last
=
False
,
collate_fn
=
collate_fn
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment