Commit aef6a97c by Jakub Jelinek Committed by Jakub Jelinek

re PR sanitizer/77567 (ASAN: Bugus error "alloc-dealloc-mismatch (malloc vs…

re PR sanitizer/77567 (ASAN: Bugus error "alloc-dealloc-mismatch (malloc vs operator delete [])" with C++17's over-aligned types)

	PR sanitizer/77567
	* asan/asan_new_delete.cc: Cherry-pick upstream r282019.

From-SVN: r240316
parent de4c144a
2016-09-21 Jakub Jelinek <jakub@redhat.com>
PR sanitizer/77567
* asan/asan_new_delete.cc: Cherry-pick upstream r282019.
2016-09-05 Jakub Jelinek <jakub@redhat.com> 2016-09-05 Jakub Jelinek <jakub@redhat.com>
PR sanitizer/77396 PR sanitizer/77396
......
...@@ -27,17 +27,30 @@ ...@@ -27,17 +27,30 @@
using namespace __asan; // NOLINT using namespace __asan; // NOLINT
// FreeBSD prior v9.2 have wrong definition of 'size_t'.
// http://svnweb.freebsd.org/base?view=revision&revision=232261
#if SANITIZER_FREEBSD && SANITIZER_WORDSIZE == 32
#include <sys/param.h>
#if __FreeBSD_version <= 902001 // v9.2
#define size_t unsigned
#endif // __FreeBSD_version
#endif // SANITIZER_FREEBSD && SANITIZER_WORDSIZE == 32
// This code has issues on OSX. // This code has issues on OSX.
// See https://code.google.com/p/address-sanitizer/issues/detail?id=131. // See https://code.google.com/p/address-sanitizer/issues/detail?id=131.
// Fake std::nothrow_t to avoid including <new>. // Fake std::nothrow_t and std::align_val_t to avoid including <new>.
namespace std { namespace std {
struct nothrow_t {}; struct nothrow_t {};
enum class align_val_t: size_t {};
} // namespace std } // namespace std
#define OPERATOR_NEW_BODY(type) \ #define OPERATOR_NEW_BODY(type) \
GET_STACK_TRACE_MALLOC;\ GET_STACK_TRACE_MALLOC;\
return asan_memalign(0, size, &stack, type); return asan_memalign(0, size, &stack, type);
#define OPERATOR_NEW_BODY_ALIGN(type) \
GET_STACK_TRACE_MALLOC;\
return asan_memalign((uptr)align, size, &stack, type);
// On OS X it's not enough to just provide our own 'operator new' and // On OS X it's not enough to just provide our own 'operator new' and
// 'operator delete' implementations, because they're going to be in the // 'operator delete' implementations, because they're going to be in the
...@@ -47,15 +60,6 @@ struct nothrow_t {}; ...@@ -47,15 +60,6 @@ struct nothrow_t {};
// To make sure that C++ allocation/deallocation operators are overridden on // To make sure that C++ allocation/deallocation operators are overridden on
// OS X we need to intercept them using their mangled names. // OS X we need to intercept them using their mangled names.
#if !SANITIZER_MAC #if !SANITIZER_MAC
// FreeBSD prior v9.2 have wrong definition of 'size_t'.
// http://svnweb.freebsd.org/base?view=revision&revision=232261
#if SANITIZER_FREEBSD && SANITIZER_WORDSIZE == 32
#include <sys/param.h>
#if __FreeBSD_version <= 902001 // v9.2
#define size_t unsigned
#endif // __FreeBSD_version
#endif // SANITIZER_FREEBSD && SANITIZER_WORDSIZE == 32
CXX_OPERATOR_ATTRIBUTE CXX_OPERATOR_ATTRIBUTE
void *operator new(size_t size) { OPERATOR_NEW_BODY(FROM_NEW); } void *operator new(size_t size) { OPERATOR_NEW_BODY(FROM_NEW); }
CXX_OPERATOR_ATTRIBUTE CXX_OPERATOR_ATTRIBUTE
...@@ -66,6 +70,18 @@ void *operator new(size_t size, std::nothrow_t const&) ...@@ -66,6 +70,18 @@ void *operator new(size_t size, std::nothrow_t const&)
CXX_OPERATOR_ATTRIBUTE CXX_OPERATOR_ATTRIBUTE
void *operator new[](size_t size, std::nothrow_t const&) void *operator new[](size_t size, std::nothrow_t const&)
{ OPERATOR_NEW_BODY(FROM_NEW_BR); } { OPERATOR_NEW_BODY(FROM_NEW_BR); }
CXX_OPERATOR_ATTRIBUTE
void *operator new(size_t size, std::align_val_t align)
{ OPERATOR_NEW_BODY_ALIGN(FROM_NEW); }
CXX_OPERATOR_ATTRIBUTE
void *operator new[](size_t size, std::align_val_t align)
{ OPERATOR_NEW_BODY_ALIGN(FROM_NEW_BR); }
CXX_OPERATOR_ATTRIBUTE
void *operator new(size_t size, std::align_val_t align, std::nothrow_t const&)
{ OPERATOR_NEW_BODY_ALIGN(FROM_NEW); }
CXX_OPERATOR_ATTRIBUTE
void *operator new[](size_t size, std::align_val_t align, std::nothrow_t const&)
{ OPERATOR_NEW_BODY_ALIGN(FROM_NEW_BR); }
#else // SANITIZER_MAC #else // SANITIZER_MAC
INTERCEPTOR(void *, _Znwm, size_t size) { INTERCEPTOR(void *, _Znwm, size_t size) {
...@@ -113,6 +129,32 @@ void operator delete[](void *ptr, size_t size) NOEXCEPT { ...@@ -113,6 +129,32 @@ void operator delete[](void *ptr, size_t size) NOEXCEPT {
GET_STACK_TRACE_FREE; GET_STACK_TRACE_FREE;
asan_sized_free(ptr, size, &stack, FROM_NEW_BR); asan_sized_free(ptr, size, &stack, FROM_NEW_BR);
} }
CXX_OPERATOR_ATTRIBUTE
void operator delete(void *ptr, std::align_val_t) NOEXCEPT {
OPERATOR_DELETE_BODY(FROM_NEW);
}
CXX_OPERATOR_ATTRIBUTE
void operator delete[](void *ptr, std::align_val_t) NOEXCEPT {
OPERATOR_DELETE_BODY(FROM_NEW_BR);
}
CXX_OPERATOR_ATTRIBUTE
void operator delete(void *ptr, std::align_val_t, std::nothrow_t const&) {
OPERATOR_DELETE_BODY(FROM_NEW);
}
CXX_OPERATOR_ATTRIBUTE
void operator delete[](void *ptr, std::align_val_t, std::nothrow_t const&) {
OPERATOR_DELETE_BODY(FROM_NEW_BR);
}
CXX_OPERATOR_ATTRIBUTE
void operator delete(void *ptr, size_t size, std::align_val_t) NOEXCEPT {
GET_STACK_TRACE_FREE;
asan_sized_free(ptr, size, &stack, FROM_NEW);
}
CXX_OPERATOR_ATTRIBUTE
void operator delete[](void *ptr, size_t size, std::align_val_t) NOEXCEPT {
GET_STACK_TRACE_FREE;
asan_sized_free(ptr, size, &stack, FROM_NEW_BR);
}
#else // SANITIZER_MAC #else // SANITIZER_MAC
INTERCEPTOR(void, _ZdlPv, void *ptr) { INTERCEPTOR(void, _ZdlPv, void *ptr) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment