Commit 9c3da8cc by Jakub Jelinek

typo fix: Fix probablity, becuse, sucessor and destinarion typos [PR93912]

2020-02-25  Jakub Jelinek  <jakub@redhat.com>

	PR other/93912
	* config/sh/sh.c (expand_cbranchdi4): Fix comment typo, probablity
	-> probability.
	* cfghooks.c (verify_flow_info): Likewise.
	* predict.c (combine_predictions_for_bb): Likewise.
	* bb-reorder.c (connect_better_edge_p): Likewise.  Fix comment typo,
	sucessor -> successor.
	(find_traces_1_round): Fix comment typo, destinarion -> destination.
	* omp-expand.c (expand_oacc_for): Fix comment typo, sucessors ->
	successors.
	* tree-ssa-loop-ch.c (should_duplicate_loop_header_p): Fix dump
	message typo, sucessors -> successors.
c/
	* gimple-parser.c (c_parser_gimple_parse_bb_spec_edge_probability):
	Rename last argument from probablity to probability.
parent 68f8763d
2020-02-25 Jakub Jelinek <jakub@redhat.com>
PR other/93912
* config/sh/sh.c (expand_cbranchdi4): Fix comment typo, probablity
-> probability.
* cfghooks.c (verify_flow_info): Likewise.
* predict.c (combine_predictions_for_bb): Likewise.
* bb-reorder.c (connect_better_edge_p): Likewise. Fix comment typo,
sucessor -> successor.
(find_traces_1_round): Fix comment typo, destinarion -> destination.
* omp-expand.c (expand_oacc_for): Fix comment typo, sucessors ->
successors.
* tree-ssa-loop-ch.c (should_duplicate_loop_header_p): Fix dump
message typo, sucessors -> successors.
2020-02-25 Martin Sebor <msebor@redhat.com> 2020-02-25 Martin Sebor <msebor@redhat.com>
* doc/extend.texi (attribute access): Correct an example. * doc/extend.texi (attribute access): Correct an example.
......
...@@ -592,7 +592,7 @@ find_traces_1_round (int branch_th, profile_count count_th, ...@@ -592,7 +592,7 @@ find_traces_1_round (int branch_th, profile_count count_th,
/* If the best destination has multiple successors or predecessors, /* If the best destination has multiple successors or predecessors,
don't allow it to be added when optimizing for size. This makes don't allow it to be added when optimizing for size. This makes
sure predecessors with smaller index are handled before the best sure predecessors with smaller index are handled before the best
destinarion. It breaks long trace and reduces long jumps. destination. It breaks long trace and reduces long jumps.
Take if-then-else as an example. Take if-then-else as an example.
A A
...@@ -1023,8 +1023,8 @@ connect_better_edge_p (const_edge e, bool src_index_p, int best_len, ...@@ -1023,8 +1023,8 @@ connect_better_edge_p (const_edge e, bool src_index_p, int best_len,
e_index = e->src->index; e_index = e->src->index;
/* We are looking for predecessor, so probabilities are not that /* We are looking for predecessor, so probabilities are not that
informative. We do not want to connect A to B becuse A has informative. We do not want to connect A to B because A has
only one sucessor (probablity is 100%) while there is edge only one successor (probability is 100%) while there is edge
A' to B where probability is 90% but which is much more frequent. */ A' to B where probability is 90% but which is much more frequent. */
if (e->count () > cur_best_edge->count ()) if (e->count () > cur_best_edge->count ())
/* The edge has higher probability than the temporary best edge. */ /* The edge has higher probability than the temporary best edge. */
......
2020-02-25 Jakub Jelinek <jakub@redhat.com>
PR other/93912
* gimple-parser.c (c_parser_gimple_parse_bb_spec_edge_probability):
Rename last argument from probablity to probability.
2020-02-13 Jakub Jelinek <jakub@redhat.com> 2020-02-13 Jakub Jelinek <jakub@redhat.com>
PR c/93576 PR c/93576
......
...@@ -149,12 +149,13 @@ static bool ...@@ -149,12 +149,13 @@ static bool
c_parser_gimple_parse_bb_spec_edge_probability (tree val, c_parser_gimple_parse_bb_spec_edge_probability (tree val,
gimple_parser &parser, gimple_parser &parser,
int *index, int *index,
profile_probability *probablity) profile_probability
*probability)
{ {
bool return_p = c_parser_gimple_parse_bb_spec (val, index); bool return_p = c_parser_gimple_parse_bb_spec (val, index);
if (return_p) if (return_p)
{ {
*probablity = profile_probability::uninitialized (); *probability = profile_probability::uninitialized ();
/* Parse frequency if provided. */ /* Parse frequency if provided. */
if (c_parser_next_token_is (parser, CPP_OPEN_PAREN)) if (c_parser_next_token_is (parser, CPP_OPEN_PAREN))
{ {
...@@ -188,7 +189,7 @@ c_parser_gimple_parse_bb_spec_edge_probability (tree val, ...@@ -188,7 +189,7 @@ c_parser_gimple_parse_bb_spec_edge_probability (tree val,
} }
unsigned int value = TREE_INT_CST_LOW (f); unsigned int value = TREE_INT_CST_LOW (f);
*probablity = profile_probability (value, quality); *probability = profile_probability (value, quality);
c_parser_consume_token (parser); c_parser_consume_token (parser);
if (!c_parser_require (parser, CPP_CLOSE_PAREN, "expected %<)%>")) if (!c_parser_require (parser, CPP_CLOSE_PAREN, "expected %<)%>"))
......
...@@ -153,7 +153,7 @@ verify_flow_info (void) ...@@ -153,7 +153,7 @@ verify_flow_info (void)
err = 1; err = 1;
} }
/* FIXME: Graphite and SLJL and target code still tends to produce /* FIXME: Graphite and SLJL and target code still tends to produce
edges with no probablity. */ edges with no probability. */
if (profile_status_for_fn (cfun) >= PROFILE_GUESSED if (profile_status_for_fn (cfun) >= PROFILE_GUESSED
&& !bb->count.initialized_p () && !flag_graphite && 0) && !bb->count.initialized_p () && !flag_graphite && 0)
{ {
...@@ -170,7 +170,7 @@ verify_flow_info (void) ...@@ -170,7 +170,7 @@ verify_flow_info (void)
err = 1; err = 1;
} }
/* FIXME: Graphite and SLJL and target code still tends to produce /* FIXME: Graphite and SLJL and target code still tends to produce
edges with no probablity. */ edges with no probability. */
if (profile_status_for_fn (cfun) >= PROFILE_GUESSED if (profile_status_for_fn (cfun) >= PROFILE_GUESSED
&& !e->probability.initialized_p () && !flag_graphite && 0) && !e->probability.initialized_p () && !flag_graphite && 0)
{ {
......
...@@ -2108,7 +2108,7 @@ expand_cbranchdi4 (rtx *operands, enum rtx_code comparison) ...@@ -2108,7 +2108,7 @@ expand_cbranchdi4 (rtx *operands, enum rtx_code comparison)
lsw_taken = EQ; lsw_taken = EQ;
if (prob.initialized_p ()) if (prob.initialized_p ())
{ {
/* FIXME: This is not optimal. We do not really know the probablity /* FIXME: This is not optimal. We do not really know the probability
that values differ by MCW only, but we should probably distribute that values differ by MCW only, but we should probably distribute
probabilities more evenly. */ probabilities more evenly. */
msw_skip_prob = rev_prob; msw_skip_prob = rev_prob;
......
...@@ -6029,7 +6029,7 @@ expand_oacc_for (struct omp_region *region, struct omp_for_data *fd) ...@@ -6029,7 +6029,7 @@ expand_oacc_for (struct omp_region *region, struct omp_for_data *fd)
basic_block cont_bb = region->cont; /* BB ending in OMP_CONTINUE */ basic_block cont_bb = region->cont; /* BB ending in OMP_CONTINUE */
basic_block bottom_bb = NULL; basic_block bottom_bb = NULL;
/* entry_bb has two sucessors; the branch edge is to the exit /* entry_bb has two successors; the branch edge is to the exit
block, fallthrough edge to body. */ block, fallthrough edge to body. */
gcc_assert (EDGE_COUNT (entry_bb->succs) == 2 gcc_assert (EDGE_COUNT (entry_bb->succs) == 2
&& BRANCH_EDGE (entry_bb)->dest == exit_bb); && BRANCH_EDGE (entry_bb)->dest == exit_bb);
......
...@@ -1367,7 +1367,7 @@ combine_predictions_for_bb (basic_block bb, bool dry_run) ...@@ -1367,7 +1367,7 @@ combine_predictions_for_bb (basic_block bb, bool dry_run)
/* If we have only one successor which is unknown, we can compute missing /* If we have only one successor which is unknown, we can compute missing
probablity. */ probability. */
if (nunknown == 1) if (nunknown == 1)
{ {
profile_probability prob = profile_probability::always (); profile_probability prob = profile_probability::always ();
......
...@@ -83,7 +83,7 @@ should_duplicate_loop_header_p (basic_block header, class loop *loop, ...@@ -83,7 +83,7 @@ should_duplicate_loop_header_p (basic_block header, class loop *loop,
{ {
if (dump_file && (dump_flags & TDF_DETAILS)) if (dump_file && (dump_flags & TDF_DETAILS))
fprintf (dump_file, fprintf (dump_file,
" Not duplicating bb %i: both sucessors are in loop.\n", " Not duplicating bb %i: both successors are in loop.\n",
loop->num); loop->num);
return false; return false;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment