Commit 888ed1a3 by Jan Hubicka Committed by Jan Hubicka

predict.c: Include ipa-utils.h

	* predict.c: Include ipa-utils.h
	(tree_bb_level_prediction): Predict recursive calls.
	(tree_estimate_probability_bb): Skip inexpensive calls for call
	predictor.
	* predict.def (PRED_RECURSIVE_CALL): New.

	* gcc.dg/predict-10.c: New test.

From-SVN: r237780
parent 1527dee9
2016-06-24 Jan Hubicka <hubicka@ucw.cz>
* predict.c: Include ipa-utils.h
(tree_bb_level_prediction): Predict recursive calls.
(tree_estimate_probability_bb): Skip inexpensive calls for call
predictor.
* predict.def (PRED_RECURSIVE_CALL): New.
2016-06-24 Bill Schmidt <wschmidt@linux.vnet.ibm.com> 2016-06-24 Bill Schmidt <wschmidt@linux.vnet.ibm.com>
* config/rs6000/rs6000-builtin.def (BU_FLOAT128_2): New #define. * config/rs6000/rs6000-builtin.def (BU_FLOAT128_2): New #define.
......
...@@ -54,6 +54,7 @@ along with GCC; see the file COPYING3. If not see ...@@ -54,6 +54,7 @@ along with GCC; see the file COPYING3. If not see
#include "tree-ssa-loop-niter.h" #include "tree-ssa-loop-niter.h"
#include "tree-ssa-loop.h" #include "tree-ssa-loop.h"
#include "tree-scalar-evolution.h" #include "tree-scalar-evolution.h"
#include "ipa-utils.h"
/* Enum with reasons why a predictor is ignored. */ /* Enum with reasons why a predictor is ignored. */
...@@ -2425,6 +2426,9 @@ tree_bb_level_predictions (void) ...@@ -2425,6 +2426,9 @@ tree_bb_level_predictions (void)
DECL_ATTRIBUTES (decl))) DECL_ATTRIBUTES (decl)))
predict_paths_leading_to (bb, PRED_COLD_FUNCTION, predict_paths_leading_to (bb, PRED_COLD_FUNCTION,
NOT_TAKEN); NOT_TAKEN);
if (decl && recursive_call_p (current_function_decl, decl))
predict_paths_leading_to (bb, PRED_RECURSIVE_CALL,
NOT_TAKEN);
} }
else if (gimple_code (stmt) == GIMPLE_PREDICT) else if (gimple_code (stmt) == GIMPLE_PREDICT)
{ {
...@@ -2539,6 +2543,7 @@ tree_estimate_probability_bb (basic_block bb) ...@@ -2539,6 +2543,7 @@ tree_estimate_probability_bb (basic_block bb)
{ {
gimple *stmt = gsi_stmt (bi); gimple *stmt = gsi_stmt (bi);
if (is_gimple_call (stmt) if (is_gimple_call (stmt)
&& !gimple_inexpensive_call_p (as_a <gcall *> (stmt))
/* Constant and pure calls are hardly used to signalize /* Constant and pure calls are hardly used to signalize
something exceptional. */ something exceptional. */
&& gimple_has_side_effects (stmt)) && gimple_has_side_effects (stmt))
......
...@@ -112,6 +112,9 @@ DEF_PREDICTOR (PRED_TREE_FPOPCODE, "fp_opcode (on trees)", HITRATE (90), 0) ...@@ -112,6 +112,9 @@ DEF_PREDICTOR (PRED_TREE_FPOPCODE, "fp_opcode (on trees)", HITRATE (90), 0)
/* Branch guarding call is probably taken. */ /* Branch guarding call is probably taken. */
DEF_PREDICTOR (PRED_CALL, "call", HITRATE (67), 0) DEF_PREDICTOR (PRED_CALL, "call", HITRATE (67), 0)
/* Recursive calls are usually not taken or the function will recurse indefinitely. */
DEF_PREDICTOR (PRED_RECURSIVE_CALL, "recursive call", HITRATE (75), 0)
/* Branch causing function to terminate is probably not taken. /* Branch causing function to terminate is probably not taken.
FIXME: early return currently predicts code: FIXME: early return currently predicts code:
int foo (int a) int foo (int a)
......
2016-06-24 Jan Hubicka <hubicka@ucw.cz>
* gcc.dg/predict-10.c: New test.
2016-06-24 Bill Schmidt <wschmidt@linux.vnet.ibm.com> 2016-06-24 Bill Schmidt <wschmidt@linux.vnet.ibm.com>
* gcc.target/powerpc/abs128-1.c: New. * gcc.target/powerpc/abs128-1.c: New.
......
/* { dg-do compile } */
/* { dg-options "-O2 -fdump-tree-profile_estimate" } */
int
ee(int i)
{
if (i>2)
return (ee(i-1)+ee(i-2))/2;
else
return i;
}
/* { dg-final { scan-tree-dump-times "recursive call" 1 "profile_estimate"} } */
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment