Commit 5589f3e5 by Michael Koch Committed by Michael Koch

2004-04-20 Michael Koch <konqueror@gmx.de>

	* javax/print/attribute/EnumSyntax.java
	(getOffset): Made protected.
	* javax/print/attribute/HashAttributeSet.java
	(HashAttributeSet): Likewise.
	* javax/print/attribute/ResolutionSyntax.java
	(getFeedResolution): Fixed typo in exception name.
	(getCrossFeedResolution): Likewise.
	* javax/print/attribute/SetOfIntegerSyntax.java
	(SetOfIntegerSyntax): Fixed HTML entities in javadoc.
	* javax/print/attribute/TextSyntax.java
	(TextSyntax): Handle locale correctly.
	(hashCode): Calc better hashcode value.
	(equals): Fixed @return tag.
	(toString): New method.

From-SVN: r80892
parent 0150fc22
2004-04-20 Michael Koch <konqueror@gmx.de> 2004-04-20 Michael Koch <konqueror@gmx.de>
* javax/print/attribute/EnumSyntax.java
(getOffset): Made protected.
* javax/print/attribute/HashAttributeSet.java
(HashAttributeSet): Likewise.
* javax/print/attribute/ResolutionSyntax.java
(getFeedResolution): Fixed typo in exception name.
(getCrossFeedResolution): Likewise.
* javax/print/attribute/SetOfIntegerSyntax.java
(SetOfIntegerSyntax): Fixed HTML entities in javadoc.
* javax/print/attribute/TextSyntax.java
(TextSyntax): Handle locale correctly.
(hashCode): Calc better hashcode value.
(equals): Fixed @return tag.
(toString): New method.
2004-04-20 Michael Koch <konqueror@gmx.de>
* gnu/java/nio/FileLockImpl.java * gnu/java/nio/FileLockImpl.java
(static): Removed, not needed anymore. (static): Removed, not needed anymore.
* gnu/java/nio/channels/FileChannelImpl.java * gnu/java/nio/channels/FileChannelImpl.java
......
...@@ -139,7 +139,7 @@ public abstract class EnumSyntax implements Cloneable, Serializable ...@@ -139,7 +139,7 @@ public abstract class EnumSyntax implements Cloneable, Serializable
return null; return null;
} }
public int getOffset() protected int getOffset()
{ {
return 0; return 0;
} }
......
...@@ -151,7 +151,7 @@ public class HashAttributeSet implements AttributeSet, Serializable ...@@ -151,7 +151,7 @@ public class HashAttributeSet implements AttributeSet, Serializable
* @exception ClassCastException if any element of attributes is not an * @exception ClassCastException if any element of attributes is not an
* interface of interfaceName * interface of interfaceName
*/ */
public HashAttributeSet(AttributeSet attributes, Class interfaceName) protected HashAttributeSet(AttributeSet attributes, Class interfaceName)
{ {
this(interfaceName); this(interfaceName);
......
...@@ -104,7 +104,7 @@ public abstract class ResolutionSyntax ...@@ -104,7 +104,7 @@ public abstract class ResolutionSyntax
* *
* @return the resolution * @return the resolution
* *
* @exception IllegalArgumenException if units < 1 * @exception IllegalArgumentException if units < 1
*/ */
public int getCrossFeedResolution(int units) public int getCrossFeedResolution(int units)
{ {
...@@ -130,7 +130,7 @@ public abstract class ResolutionSyntax ...@@ -130,7 +130,7 @@ public abstract class ResolutionSyntax
* *
* @return the resolution * @return the resolution
* *
* @exception IllegalArgumenException if units < 1 * @exception IllegalArgumentException if units < 1
*/ */
public int getFeedResolution(int units) public int getFeedResolution(int units)
{ {
......
...@@ -148,8 +148,8 @@ public abstract class SetOfIntegerSyntax ...@@ -148,8 +148,8 @@ public abstract class SetOfIntegerSyntax
* @param lowerBound the lower bound value * @param lowerBound the lower bound value
* @param upperBound the upper bound value * @param upperBound the upper bound value
* *
* @exception IllegalArgumentException if lowerBound <= uppbound * @exception IllegalArgumentException if lowerBound &lt;= upperbound
* and lowerBound < 0 * and lowerBound &lt; 0
*/ */
protected SetOfIntegerSyntax(int lowerBound, int upperBound) protected SetOfIntegerSyntax(int lowerBound, int upperBound)
{ {
......
/* TextSyntax.java -- /* TextSyntax.java --
Copyright (C) 2003 Free Software Foundation, Inc. Copyright (C) 2003, 2004 Free Software Foundation, Inc.
This file is part of GNU Classpath. This file is part of GNU Classpath.
...@@ -57,12 +57,12 @@ public abstract class TextSyntax implements Cloneable, Serializable ...@@ -57,12 +57,12 @@ public abstract class TextSyntax implements Cloneable, Serializable
* @param value the value for this syntax * @param value the value for this syntax
* @param locale the locale to use * @param locale the locale to use
* *
* @exception NullPointerException if value is null * @exception NullPointerException if value and/or locale is null
*/ */
protected TextSyntax(String value, Locale locale) protected TextSyntax(String value, Locale locale)
{ {
if (value == null) if (value == null || locale == null)
throw new NullPointerException("value may not be null"); throw new NullPointerException("value and/or locale may not be null");
this.value = value; this.value = value;
this.locale = locale; this.locale = locale;
...@@ -95,7 +95,7 @@ public abstract class TextSyntax implements Cloneable, Serializable ...@@ -95,7 +95,7 @@ public abstract class TextSyntax implements Cloneable, Serializable
*/ */
public int hashCode() public int hashCode()
{ {
return value.hashCode() + locale.hashCode(); return value.hashCode() ^ locale.hashCode();
} }
/** /**
...@@ -103,7 +103,7 @@ public abstract class TextSyntax implements Cloneable, Serializable ...@@ -103,7 +103,7 @@ public abstract class TextSyntax implements Cloneable, Serializable
* *
* @param obj the object to test * @param obj the object to test
* *
* @returns true if both objects are equal, false otherwise. * @return true if both objects are equal, false otherwise.
*/ */
public boolean equals(Object obj) public boolean equals(Object obj)
{ {
...@@ -115,4 +115,12 @@ public abstract class TextSyntax implements Cloneable, Serializable ...@@ -115,4 +115,12 @@ public abstract class TextSyntax implements Cloneable, Serializable
return (value.equals(tmp.getValue()) return (value.equals(tmp.getValue())
&& locale.equals(tmp.getLocale())); && locale.equals(tmp.getLocale()));
} }
/**
* Returns a string representing the object.
*/
public String toString()
{
return value;
}
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment