Commit 4ee494c0 by Jakub Jelinek Committed by Jakub Jelinek

re PR ipa/80000 (diagnostics: trailing spaces in "one definition rule ")

	PR ipa/80000
	* ipa-devirt.c (compare_virtual_tables): Remove two trailing spaces
	from diagnostics.  Formatting fixes.

	PR target/85665
	* ipa-devirt.c (odr_types_equivalent_p): Fix grammar in
	warn_odr diagnostics.

From-SVN: r269488
parent 0d7bac69
2019-03-08 Jakub Jelinek <jakub@redhat.com> 2019-03-08 Jakub Jelinek <jakub@redhat.com>
PR ipa/80000
* ipa-devirt.c (compare_virtual_tables): Remove two trailing spaces
from diagnostics. Formatting fixes.
PR target/85665
* ipa-devirt.c (odr_types_equivalent_p): Fix grammar in
warn_odr diagnostics.
PR other/80058 PR other/80058
* lra-constraints.c (process_alt_operands): Avoid one space before * lra-constraints.c (process_alt_operands): Avoid one space before
" at the end of line and another after " on another line in a string " at the end of line and another after " on another line in a string
......
...@@ -842,17 +842,16 @@ compare_virtual_tables (varpool_node *prevailing, varpool_node *vtable) ...@@ -842,17 +842,16 @@ compare_virtual_tables (varpool_node *prevailing, varpool_node *vtable)
{ {
class_type->odr_violated = true; class_type->odr_violated = true;
auto_diagnostic_group d; auto_diagnostic_group d;
if (warning_at (DECL_SOURCE_LOCATION tree ctx = TYPE_NAME (DECL_CONTEXT (vtable->decl));
(TYPE_NAME (DECL_CONTEXT (vtable->decl))), if (warning_at (DECL_SOURCE_LOCATION (ctx), OPT_Wodr,
OPT_Wodr,
"virtual table of type %qD violates " "virtual table of type %qD violates "
"one definition rule ", "one definition rule",
DECL_CONTEXT (vtable->decl))) DECL_CONTEXT (vtable->decl)))
{ {
inform (DECL_SOURCE_LOCATION ctx = TYPE_NAME (DECL_CONTEXT (prevailing->decl));
(TYPE_NAME (DECL_CONTEXT (prevailing->decl))), inform (DECL_SOURCE_LOCATION (ctx),
"the conflicting type defined in another translation " "the conflicting type defined in another translation"
"unit has virtual table of different size"); " unit has virtual table of different size");
} }
} }
return; return;
...@@ -1607,7 +1606,8 @@ odr_types_equivalent_p (tree t1, tree t2, bool warn, bool *warned, ...@@ -1607,7 +1606,8 @@ odr_types_equivalent_p (tree t1, tree t2, bool warn, bool *warned,
if (DECL_BIT_FIELD (f1) != DECL_BIT_FIELD (f2)) if (DECL_BIT_FIELD (f1) != DECL_BIT_FIELD (f2))
{ {
warn_odr (t1, t2, f1, f2, warn, warned, warn_odr (t1, t2, f1, f2, warn, warned,
G_("one field is bitfield while other is not")); G_("one field is a bitfield while the other "
"is not"));
return false; return false;
} }
else else
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment