Skip to content

R
riscv-gcc-1
Commit 4b6d0c0e by Uros Bizjak Committed by Uros Bizjak
Options

re PR target/78904 (zero-extracts are not effective) 

	PR target/78904
	* config/i386/constraints.md (Bc): New special memory constraint.
	* config/i386/i386.md (*cmpqi_ext_1, *extvqi, *extzvqi): Use Bc
	constraint with nonimmediate_operand to allow constant memory operands.
	(*cmpqi_ext_3, insv<mode>_1, addqi_ext_1, *testqi_ext_1, andqi_ext_1)
	(*<any_or:code>qi_ext_1, *xorqi_ext_1_cc): Use Bc constraint
	with general_operand to allow constant memory operands.

testsuite/ChangeLog:

	PR target/78904
	* gcc.target/i386/pr78904-3.c: New test.

From-SVN: r243937
parent 8ba4f506
Showing with 74 additions and 11 deletions
gcc/ChangeLog
2016-12-27 Uros Bizjak <ubizjak@gmail.com>
PR target/78904
* config/i386/constraints.md (Bc): New special memory constraint.
* config/i386/i386.md (*cmpqi_ext_1, *extvqi, *extzvqi): Use Bc
constraint with nonimmediate_operand to allow constant memory operands.
(*cmpqi_ext_3, insv<mode>_1, addqi_ext_1, *testqi_ext_1, andqi_ext_1)
(*<any_or:code>qi_ext_1, *xorqi_ext_1_cc): Use Bc constraint
with general_operand to allow constant memory operands.
2016-12-27 Alexander Ivchenko <alexander.ivchenko@intel.com> 2016-12-27 Alexander Ivchenko <alexander.ivchenko@intel.com>
* c-family/c.opt (flag_chkp_flexible_struct_trailing_arrays): * c-family/c.opt (flag_chkp_flexible_struct_trailing_arrays):
gcc/config/i386/constraints.md
...@@ -168,6 +168,7 @@ ...@@ -168,6 +168,7 @@
;; f FLAGS_REG ;; f FLAGS_REG
;; g GOT memory operand. ;; g GOT memory operand.
;; m Vector memory operand ;; m Vector memory operand
;; c Constant memory operand
;; s Sibcall memory operand, not valid for TARGET_X32 ;; s Sibcall memory operand, not valid for TARGET_X32
;; w Call memory operand, not valid for TARGET_X32 ;; w Call memory operand, not valid for TARGET_X32
;; z Constant call address operand. ;; z Constant call address operand.
...@@ -185,6 +186,11 @@ ...@@ -185,6 +186,11 @@
"@internal Vector memory operand." "@internal Vector memory operand."
(match_operand 0 "vector_memory_operand")) (match_operand 0 "vector_memory_operand"))
(define_special_memory_constraint "Bc"
"@internal Constant memory operand."
(and (match_operand 0 "memory_operand")
(match_test "constant_address_p (XEXP (op, 0))")))
(define_constraint "Bs" (define_constraint "Bs"
"@internal Sibcall memory operand." "@internal Sibcall memory operand."
(ior (and (not (match_test "TARGET_X32")) (ior (and (not (match_test "TARGET_X32"))
......
gcc/config/i386/i386.md
...@@ -1295,7 +1295,7 @@ ...@@ -1295,7 +1295,7 @@
(define_insn "*cmpqi_ext_1" (define_insn "*cmpqi_ext_1"
[(set (reg FLAGS_REG) [(set (reg FLAGS_REG)
(compare (compare
(match_operand:QI 0 "nonimmediate_operand" "Q,m") (match_operand:QI 0 "nonimmediate_operand" "QBc,m")
(subreg:QI (subreg:QI
(zero_extract:SI (zero_extract:SI
(match_operand 1 "ext_register_operand" "Q,Q") (match_operand 1 "ext_register_operand" "Q,Q")
...@@ -1340,7 +1340,7 @@ ...@@ -1340,7 +1340,7 @@
(match_operand 0 "ext_register_operand" "Q,Q") (match_operand 0 "ext_register_operand" "Q,Q")
(const_int 8) (const_int 8)
(const_int 8)) 0) (const_int 8)) 0)
(match_operand:QI 1 "general_operand" "Qn,m")))] (match_operand:QI 1 "general_operand" "QnBc,m")))]
"ix86_match_ccmode (insn, CCmode)" "ix86_match_ccmode (insn, CCmode)"
"cmp{b}\t{%1, %h0|%h0, %1}" "cmp{b}\t{%1, %h0|%h0, %1}"
[(set_attr "isa" "*,nox64") [(set_attr "isa" "*,nox64")
...@@ -2781,7 +2781,7 @@ ...@@ -2781,7 +2781,7 @@
(set_attr "mode" "SI")]) (set_attr "mode" "SI")])
(define_insn "*extvqi" (define_insn "*extvqi"
[(set (match_operand:QI 0 "nonimmediate_operand" "=Q,?R,m") [(set (match_operand:QI 0 "nonimmediate_operand" "=QBc,?R,m")
(sign_extract:QI (match_operand 1 "ext_register_operand" "Q,Q,Q") (sign_extract:QI (match_operand 1 "ext_register_operand" "Q,Q,Q")
(const_int 8) (const_int 8)
(const_int 8)))] (const_int 8)))]
...@@ -2836,7 +2836,7 @@ ...@@ -2836,7 +2836,7 @@
(set_attr "mode" "SI")]) (set_attr "mode" "SI")])
(define_insn "*extzvqi" (define_insn "*extzvqi"
[(set (match_operand:QI 0 "nonimmediate_operand" "=Q,?R,m") [(set (match_operand:QI 0 "nonimmediate_operand" "=QBc,?R,m")
(subreg:QI (subreg:QI
(zero_extract:SI (match_operand 1 "ext_register_operand" "Q,Q,Q") (zero_extract:SI (match_operand 1 "ext_register_operand" "Q,Q,Q")
(const_int 8) (const_int 8)
...@@ -2897,7 +2897,7 @@ ...@@ -2897,7 +2897,7 @@
[(set (zero_extract:SWI248 (match_operand 0 "ext_register_operand" "+Q,Q") [(set (zero_extract:SWI248 (match_operand 0 "ext_register_operand" "+Q,Q")
(const_int 8) (const_int 8)
(const_int 8)) (const_int 8))
(match_operand:SWI248 1 "general_operand" "Qn,m"))] (match_operand:SWI248 1 "general_operand" "QnBc,m"))]
"" ""
{ {
if (CONST_INT_P (operands[1])) if (CONST_INT_P (operands[1]))
...@@ -6087,7 +6087,7 @@ ...@@ -6087,7 +6087,7 @@
(zero_extract:SI (match_operand 1 "ext_register_operand" "0,0") (zero_extract:SI (match_operand 1 "ext_register_operand" "0,0")
(const_int 8) (const_int 8)
(const_int 8)) 0) (const_int 8)) 0)
(match_operand:QI 2 "general_operand" "Qn,m")) 0)) (match_operand:QI 2 "general_operand" "QnBc,m")) 0))
(clobber (reg:CC FLAGS_REG))] (clobber (reg:CC FLAGS_REG))]
"" ""
{ {
...@@ -7889,7 +7889,7 @@ ...@@ -7889,7 +7889,7 @@
(zero_extract:SI (match_operand 0 "ext_register_operand" "Q,Q") (zero_extract:SI (match_operand 0 "ext_register_operand" "Q,Q")
(const_int 8) (const_int 8)
(const_int 8)) 0) (const_int 8)) 0)
(match_operand:QI 1 "general_operand" "Qn,m")) (match_operand:QI 1 "general_operand" "QnBc,m"))
(const_int 0)))] (const_int 0)))]
"ix86_match_ccmode (insn, CCNOmode)" "ix86_match_ccmode (insn, CCNOmode)"
"test{b}\t{%1, %h0|%h0, %1}" "test{b}\t{%1, %h0|%h0, %1}"
...@@ -8417,7 +8417,7 @@ ...@@ -8417,7 +8417,7 @@
(zero_extract:SI (match_operand 1 "ext_register_operand" "0,0") (zero_extract:SI (match_operand 1 "ext_register_operand" "0,0")
(const_int 8) (const_int 8)
(const_int 8)) 0) (const_int 8)) 0)
(match_operand:QI 2 "general_operand" "Qn,m")) 0)) (match_operand:QI 2 "general_operand" "QnBc,m")) 0))
(clobber (reg:CC FLAGS_REG))] (clobber (reg:CC FLAGS_REG))]
"" ""
"and{b}\t{%2, %h0|%h0, %2}" "and{b}\t{%2, %h0|%h0, %2}"
...@@ -8435,7 +8435,7 @@ ...@@ -8435,7 +8435,7 @@
(zero_extract:SI (match_operand 1 "ext_register_operand" "0,0") (zero_extract:SI (match_operand 1 "ext_register_operand" "0,0")
(const_int 8) (const_int 8)
(const_int 8)) 0) (const_int 8)) 0)
(match_operand:QI 2 "general_operand" "Qn,m")) (match_operand:QI 2 "general_operand" "QnBc,m"))
(const_int 0))) (const_int 0)))
(set (zero_extract:SI (match_operand 0 "ext_register_operand" "=Q,Q") (set (zero_extract:SI (match_operand 0 "ext_register_operand" "=Q,Q")
(const_int 8) (const_int 8)
...@@ -8804,7 +8804,7 @@ ...@@ -8804,7 +8804,7 @@
(zero_extract:SI (match_operand 1 "ext_register_operand" "0,0") (zero_extract:SI (match_operand 1 "ext_register_operand" "0,0")
(const_int 8) (const_int 8)
(const_int 8)) 0) (const_int 8)) 0)
(match_operand:QI 2 "general_operand" "Qn,m")) 0)) (match_operand:QI 2 "general_operand" "QnBc,m")) 0))
(clobber (reg:CC FLAGS_REG))] (clobber (reg:CC FLAGS_REG))]
"!TARGET_PARTIAL_REG_STALL || optimize_function_for_size_p (cfun)" "!TARGET_PARTIAL_REG_STALL || optimize_function_for_size_p (cfun)"
"<logic>{b}\t{%2, %h0|%h0, %2}" "<logic>{b}\t{%2, %h0|%h0, %2}"
...@@ -8914,7 +8914,7 @@ ...@@ -8914,7 +8914,7 @@
(zero_extract:SI (match_operand 1 "ext_register_operand" "0,0") (zero_extract:SI (match_operand 1 "ext_register_operand" "0,0")
(const_int 8) (const_int 8)
(const_int 8)) 0) (const_int 8)) 0)
(match_operand:QI 2 "general_operand" "Qn,m")) (match_operand:QI 2 "general_operand" "QnBc,m"))
(const_int 0))) (const_int 0)))
(set (zero_extract:SI (match_operand 0 "ext_register_operand" "=Q,Q") (set (zero_extract:SI (match_operand 0 "ext_register_operand" "=Q,Q")
(const_int 8) (const_int 8)
......
gcc/testsuite/ChangeLog
2016-12-27 Uros Bizjak <ubizjak@gmail.com>
PR target/78904
* gcc.target/i386/pr78904-3.c: New test.
2016-12-27 Alexander Ivchenko <alexander.ivchenko@intel.com> 2016-12-27 Alexander Ivchenko <alexander.ivchenko@intel.com>
* gcc.target/i386/mpx/vla-trailing-1-lbv.c: New test. * gcc.target/i386/mpx/vla-trailing-1-lbv.c: New test.
......
gcc/testsuite/gcc.target/i386/pr78904-3.c 0 → 100644
/* PR target/78904 */
/* { dg-do assemble } */
/* { dg-options "-O2" } */
typedef __SIZE_TYPE__ size_t;
struct S1
{
unsigned char pad1;
unsigned char val;
unsigned short pad2;
};
extern struct S1 t[256];
struct S1 test_and (struct S1 a, size_t i)
{
a.val &= t[i].val;
return a;
}
struct S1 test_or (struct S1 a, size_t i)
{
a.val |= t[i].val;
return a;
}
struct S1 test_xor (struct S1 a, size_t i)
{
a.val ^= t[i].val;
return a;
}
struct S1 test_add (struct S1 a, size_t i)
{
a.val += t[i].val;
return a;
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment