Commit 1fae9801 by Ian Lance Taylor

runtime, runtime/pprof: Fix runtime/pprof test to pass, enable it.

From-SVN: r189878
parent f34ee0b2
......@@ -1794,7 +1794,7 @@ GOTESTFLAGS =
# Check a package.
CHECK = \
GC="$(GOC) $(GOCFLAGS) -L `${PWD_COMMAND}` -L `${PWD_COMMAND}`/.libs"; \
GC="$(GOC) $(GOCFLAGS) $($(subst /,_,$@)_GOCFLAGS) -L `${PWD_COMMAND}` -L `${PWD_COMMAND}`/.libs"; \
export GC; \
GOLIBS="$(MATH_LIBS) $(NET_LIBS)"; \
export GOLIBS; \
......@@ -3012,6 +3012,9 @@ runtime/pprof.lo: $(go_runtime_pprof_files)
runtime/pprof/check: $(CHECK_DEPS)
@$(CHECK)
.PHONY: runtime/pprof/check
# At least for now, we need -static-libgo for this test, because
# otherwise we can't get the line numbers.
runtime_pprof_check_GOCFLAGS = -static-libgo
@go_include@ sync/atomic.lo.dep
sync/atomic.lo.dep: $(go_sync_atomic_files)
......@@ -3548,6 +3551,7 @@ TEST_PACKAGES = \
os/user/check \
path/filepath/check \
regexp/syntax/check \
runtime/pprof/check \
sync/atomic/check \
text/scanner/check \
text/tabwriter/check \
......
......@@ -2029,7 +2029,7 @@ GOTESTFLAGS =
# Check a package.
CHECK = \
GC="$(GOC) $(GOCFLAGS) -L `${PWD_COMMAND}` -L `${PWD_COMMAND}`/.libs"; \
GC="$(GOC) $(GOCFLAGS) $($(subst /,_,$@)_GOCFLAGS) -L `${PWD_COMMAND}` -L `${PWD_COMMAND}`/.libs"; \
export GC; \
GOLIBS="$(MATH_LIBS) $(NET_LIBS)"; \
export GOLIBS; \
......@@ -2089,6 +2089,9 @@ CHECK_DEPS = libgo.la libgobegin.a \
$(toolexeclibgotexttemplate_DATA) \
$(toolexeclibgounicode_DATA)
# At least for now, we need -static-libgo for this test, because
# otherwise we can't get the line numbers.
runtime_pprof_check_GOCFLAGS = -static-libgo
# How to build a .gox file from a .lo file.
BUILDGOX = \
......@@ -2218,6 +2221,7 @@ TEST_PACKAGES = \
os/user/check \
path/filepath/check \
regexp/syntax/check \
runtime/pprof/check \
sync/atomic/check \
text/scanner/check \
text/tabwriter/check \
......
......@@ -71,7 +71,8 @@ func TestCPUProfile(t *testing.T) {
if f == nil {
continue
}
if strings.Contains(f.Name(), "ChecksumIEEE") {
if strings.Contains(f.Name(), "ChecksumIEEE") ||
(strings.Contains(f.Name(), "update") && strings.Contains(f.Name(), "crc32")) {
found = true
}
}
......
......@@ -149,8 +149,7 @@ sig_handler (int sig)
#ifdef SIGPROF
if (sig == SIGPROF)
{
/* FIXME. */
runtime_sigprof (0, 0, nil, nil);
runtime_sigprof ();
return;
}
#endif
......
......@@ -1681,10 +1681,7 @@ static struct {
// Called if we receive a SIGPROF signal.
void
runtime_sigprof(uint8 *pc __attribute__ ((unused)),
uint8 *sp __attribute__ ((unused)),
uint8 *lr __attribute__ ((unused)),
G *gp __attribute__ ((unused)))
runtime_sigprof()
{
int32 n;
......
......@@ -451,7 +451,7 @@ const byte* runtime_getenv(const char*);
int32 runtime_atoi(const byte*);
uint32 runtime_fastrand1(void);
void runtime_sigprof(uint8 *pc, uint8 *sp, uint8 *lr, G *gp);
void runtime_sigprof();
void runtime_resetcpuprofiler(int32);
void runtime_setcpuprofilerate(void(*)(uintptr*, int32), int32);
void runtime_usleep(uint32);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment