decl.c (elaborate_expression_1): Add EXPR_PUBLIC_P local variable.

	* gcc-interface/decl.c (elaborate_expression_1): Add EXPR_PUBLIC_P local
	variable.  Always create the elaboration variable, if any, as constant.

From-SVN: r180541

gcc/ada/ChangeLog

 
 2011-10-26  Eric Botcazou  <ebotcazou@adacore.com>
 
+	* gcc-interface/decl.c (elaborate_expression_1): Add EXPR_PUBLIC_P local
+	variable.  Always create the elaboration variable, if any, as constant.
+
+2011-10-26  Eric Botcazou  <ebotcazou@adacore.com>
+
 	* gcc-interface/decl.c (gnat_to_gnu_entity) <E_Record_Subtype>: Try to
 	make a packable type for fields of union types as well.
 	<is_type>: Use RECORD_OR_UNION_TYPE_P predicate.

gcc/ada/gcc-interface/decl.c

@@ -6085,7 +6085,8 @@ static tree
 elaborate_expression_1 (tree gnu_expr, Entity_Id gnat_entity, tree gnu_name,
 			bool definition, bool need_debug)
 {
-  const bool expr_global_p = Is_Public (gnat_entity) || global_bindings_p ();
+  const bool expr_public_p = Is_Public (gnat_entity);
+  const bool expr_global_p = expr_public_p || global_bindings_p ();
   bool expr_variable_p, use_variable;
 
   /* In most cases, we won't see a naked FIELD_DECL because a discriminant
@@ -6153,11 +6154,10 @@ elaborate_expression_1 (tree gnu_expr, Entity_Id gnat_entity, tree gnu_name,
   if (use_variable || need_debug)
     {
       tree gnu_decl
-	= create_var_decl (create_concat_name (gnat_entity,
-					       IDENTIFIER_POINTER (gnu_name)),
-			   NULL_TREE, TREE_TYPE (gnu_expr), gnu_expr,
-			   !need_debug, Is_Public (gnat_entity),
-			   !definition, expr_global_p, NULL, gnat_entity);
+	= create_var_decl_1
+	  (create_concat_name (gnat_entity, IDENTIFIER_POINTER (gnu_name)),
+	   NULL_TREE, TREE_TYPE (gnu_expr), gnu_expr, true, expr_public_p,
+	   !definition, expr_global_p, !need_debug, NULL, gnat_entity);
 
       if (use_variable)
 	return gnu_decl;

gcc/testsuite/ChangeLog

 2011-10-26  Eric Botcazou  <ebotcazou@adacore.com>
 
+	* gnat.dg/specs/discr1.ads: New test.
+	* gnat.dg/specs/discr1_pkg.ads: New helper.
+
+2011-10-26  Eric Botcazou  <ebotcazou@adacore.com>
+
 	* gnat.dg/specs/unchecked_union.ads: Rename to...
 	* gnat.dg/specs/unchecked_union1.ads: ...this.
 	* gnat.dg/specs/unchecked_union2.ads: New test.

gcc/testsuite/gnat.dg/specs/discr1.ads

+-- { dg-do compile }
+-- { dg-options "-gnatct" }
+
+with Discr1_Pkg; use Discr1_Pkg;
+
+package Discr1 is
+
+  procedure Proc (V : Variable_String_Array);
+
+end Discr1;

gcc/testsuite/gnat.dg/specs/discr1_pkg.ads

+package Discr1_Pkg is
+
+  Maximum_Length : Natural := 80 ;
+
+  subtype String_Length is Natural range 0 .. Maximum_Length;
+
+  type Variable_String (Length : String_Length := 0) is
+    record
+      S : String (1 .. Length);
+    end record;
+
+  type Variable_String_Array is array (Natural range <>) of Variable_String;
+
+end Discr1_Pkg;