Unverified Commit d299a7aa by Edward Thomson Committed by GitHub

Merge pull request #6205 from ccstolley/ccs_fix_http_push_timeout

push: Prepare pack before sending pack header.
parents 1e7c8b1f aceac672
...@@ -1308,7 +1308,7 @@ static int ll_find_deltas(git_packbuilder *pb, git_pobject **list, ...@@ -1308,7 +1308,7 @@ static int ll_find_deltas(git_packbuilder *pb, git_pobject **list,
#define ll_find_deltas(pb, l, ls, w, d) find_deltas(pb, l, &ls, w, d) #define ll_find_deltas(pb, l, ls, w, d) find_deltas(pb, l, &ls, w, d)
#endif #endif
static int prepare_pack(git_packbuilder *pb) int git_packbuilder__prepare(git_packbuilder *pb)
{ {
git_pobject **delta_list; git_pobject **delta_list;
size_t i, n = 0; size_t i, n = 0;
...@@ -1353,7 +1353,7 @@ static int prepare_pack(git_packbuilder *pb) ...@@ -1353,7 +1353,7 @@ static int prepare_pack(git_packbuilder *pb)
return 0; return 0;
} }
#define PREPARE_PACK if (prepare_pack(pb) < 0) { return -1; } #define PREPARE_PACK if (git_packbuilder__prepare(pb) < 0) { return -1; }
int git_packbuilder_foreach(git_packbuilder *pb, int (*cb)(void *buf, size_t size, void *payload), void *payload) int git_packbuilder_foreach(git_packbuilder *pb, int (*cb)(void *buf, size_t size, void *payload), void *payload)
{ {
......
...@@ -100,5 +100,7 @@ struct git_packbuilder { ...@@ -100,5 +100,7 @@ struct git_packbuilder {
}; };
int git_packbuilder__write_buf(git_str *buf, git_packbuilder *pb); int git_packbuilder__write_buf(git_str *buf, git_packbuilder *pb);
int git_packbuilder__prepare(git_packbuilder *pb);
#endif #endif
...@@ -1036,6 +1036,10 @@ int git_smart__push(git_transport *transport, git_push *push) ...@@ -1036,6 +1036,10 @@ int git_smart__push(git_transport *transport, git_push *push)
} }
} }
/* prepare pack before sending pack header to avoid timeouts */
if (need_pack && ((error = git_packbuilder__prepare(push->pb))) < 0)
goto done;
if ((error = git_smart__get_push_stream(t, &packbuilder_payload.stream)) < 0 || if ((error = git_smart__get_push_stream(t, &packbuilder_payload.stream)) < 0 ||
(error = gen_pktline(&pktline, push)) < 0 || (error = gen_pktline(&pktline, push)) < 0 ||
(error = packbuilder_payload.stream->write(packbuilder_payload.stream, git_str_cstr(&pktline), git_str_len(&pktline))) < 0) (error = packbuilder_payload.stream->write(packbuilder_payload.stream, git_str_cstr(&pktline), git_str_len(&pktline))) < 0)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment