Commit 966fb207 by Carlos Martín Nieto

tree: free in error conditions

As reported by coverity, we would leak some memory in error conditions.
parent 5e0f47c3
...@@ -466,6 +466,7 @@ static int append_entry( ...@@ -466,6 +466,7 @@ static int append_entry(
git_strmap_insert(bld->map, entry->filename, entry, error); git_strmap_insert(bld->map, entry->filename, entry, error);
if (error < 0) { if (error < 0) {
git_tree_entry_free(entry);
giterr_set(GITERR_TREE, "failed to append entry %s to the tree builder", filename); giterr_set(GITERR_TREE, "failed to append entry %s to the tree builder", filename);
return -1; return -1;
} }
...@@ -622,6 +623,7 @@ int git_treebuilder_create(git_treebuilder **builder_p, const git_tree *source) ...@@ -622,6 +623,7 @@ int git_treebuilder_create(git_treebuilder **builder_p, const git_tree *source)
GITERR_CHECK_ALLOC(bld); GITERR_CHECK_ALLOC(bld);
if (git_strmap_alloc(&bld->map) < 0) { if (git_strmap_alloc(&bld->map) < 0) {
git__free(bld);
return -1; return -1;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment